2019-06-25 03:26:03

by Colin King

Subject: [PATCH][next] drm/vmwgfx: remove redundant assignment to sub_res

From: Colin Ian King <[email protected]>

Variable sub_res is initialized to a value that is never read and it
is re-assigned later in a for-loop. The initialization is redundant
and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c b/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c
index 862ca44680ca..3257ba689d93 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c
@@ -1914,7 +1914,7 @@ static void vmw_surface_tex_dirty_range_add(struct vmw_resource *res,
} else {
/* Dirty range covers multiple sub-resources */
struct svga3dsurface_loc loc_min, loc_max;
- u32 sub_res = loc1.sub_resource;
+ u32 sub_res;

svga3dsurface_max_loc(cache, loc1.sub_resource, &loc_max);
vmw_subres_dirty_add(dirty, &loc1, &loc_max);
--
2.20.1

2019-07-01 21:14:47

by Deepak Singh Rawat

Subject: Re: [PATCH][next] drm/vmwgfx: remove redundant assignment to sub_res

Hi Colin,

Reviewed-by: Deepak Rawat <[email protected]>

Thanks,
Deepak


On Mon, 2019-06-24 at 23:44 +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Variable sub_res is initialized to a value that is never read and it
> is re-assigned later in a for-loop. The initialization is redundant
> and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c
> b/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c
> index 862ca44680ca..3257ba689d93 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c
> @@ -1914,7 +1914,7 @@ static void
> vmw_surface_tex_dirty_range_add(struct vmw_resource *res,
> } else {
> /* Dirty range covers multiple sub-resources */
> struct svga3dsurface_loc loc_min, loc_max;
> - u32 sub_res = loc1.sub_resource;
> + u32 sub_res;
>
> svga3dsurface_max_loc(cache, loc1.sub_resource,
> &loc_max);
> vmw_subres_dirty_add(dirty, &loc1, &loc_max);