2024-05-31 19:48:16

by Andy Shevchenko

Subject: [PATCH v1 2/8] spi: dw: Use new spi_xfer_is_dma_mapped() helper

Replace a few lines of code by calling a spi_xfer_is_dma_mapped() helper.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/spi/spi-dw-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-dw-core.c b/drivers/spi/spi-dw-core.c
index ddfdb903047a..431788dd848c 100644
--- a/drivers/spi/spi-dw-core.c
+++ b/drivers/spi/spi-dw-core.c
@@ -19,6 +19,7 @@
#include <linux/string.h>
#include <linux/of.h>

+#include "internals.h"
#include "spi-dw.h"

#ifdef CONFIG_DEBUG_FS
@@ -438,8 +439,7 @@ static int dw_spi_transfer_one(struct spi_controller *host,
transfer->effective_speed_hz = dws->current_freq;

/* Check if current transfer is a DMA transaction */
- if (host->can_dma && host->can_dma(host, spi, transfer))
- dws->dma_mapped = host->cur_msg_mapped;
+ dws->dma_mapped = spi_xfer_is_dma_mapped(host, spi, transfer);

/* For poll mode just disable all interrupts */
dw_spi_mask_intr(dws, 0xff);
--
2.43.0.rc1.1336.g36b5255a03ac

2024-06-03 08:29:03

by Serge Semin

Subject: Re: [PATCH v1 2/8] spi: dw: Use new spi_xfer_is_dma_mapped() helper

On Fri, May 31, 2024 at 10:42:34PM +0300, Andy Shevchenko wrote:
> Replace a few lines of code by calling a spi_xfer_is_dma_mapped() helper.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Nice cleanup. Thanks!
Reviewed-by: Serge Semin <[email protected]>

-Serge(y)

> ---
> drivers/spi/spi-dw-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-dw-core.c b/drivers/spi/spi-dw-core.c
> index ddfdb903047a..431788dd848c 100644
> --- a/drivers/spi/spi-dw-core.c
> +++ b/drivers/spi/spi-dw-core.c
> @@ -19,6 +19,7 @@
> #include <linux/string.h>
> #include <linux/of.h>
>
> +#include "internals.h"
> #include "spi-dw.h"
>
> #ifdef CONFIG_DEBUG_FS
> @@ -438,8 +439,7 @@ static int dw_spi_transfer_one(struct spi_controller *host,
> transfer->effective_speed_hz = dws->current_freq;
>
> /* Check if current transfer is a DMA transaction */
> - if (host->can_dma && host->can_dma(host, spi, transfer))
> - dws->dma_mapped = host->cur_msg_mapped;
> + dws->dma_mapped = spi_xfer_is_dma_mapped(host, spi, transfer);
>
> /* For poll mode just disable all interrupts */
> dw_spi_mask_intr(dws, 0xff);
> --
> 2.43.0.rc1.1336.g36b5255a03ac
>