2012-06-06 11:55:23

by Andreas Bießmann

[permalink] [raw]
Subject: [PATCH] arm:gemini: fix irq.c

Commit 9f97da78bf018206fb623cd351d454af2f105fe0 moved disable_hlt() from
arch/arm/include/asm/system.h to arch/arm/include/asm/system_misc.h but missed
to change arch/arm/mach-gemini/irq.c.

This patch fixes following error:

---8<---
arch/arm/mach-gemini/irq.c: In function 'gemini_init_irq':
arch/arm/mach-gemini/irq.c:79:2: error: implicit declaration of function 'disable_hlt' [-Werror=implicit-function-declaration]
--->8---

Signed-off-by: Andreas Bießmann <[email protected]>
cc: Hans Ulli Kroll <[email protected]>
cc: Russell King <[email protected]>
cc: [email protected]
---
Note: this is broken since 3.4 release, 3.3 is sane.

arch/arm/mach-gemini/irq.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-gemini/irq.c b/arch/arm/mach-gemini/irq.c
index ca70e5f..020852d 100644
--- a/arch/arm/mach-gemini/irq.c
+++ b/arch/arm/mach-gemini/irq.c
@@ -17,6 +17,7 @@
#include <linux/sched.h>
#include <asm/irq.h>
#include <asm/mach/irq.h>
+#include <asm/system_misc.h>
#include <mach/hardware.h>

#define IRQ_SOURCE(base_addr) (base_addr + 0x00)
--
1.7.10


2012-06-29 20:45:07

by Andreas Bießmann

[permalink] [raw]
Subject: Re: [PATCH] arm:gemini: fix irq.c

On 06.06.12 13:22, Andreas Bießmann wrote:
> Commit 9f97da78bf018206fb623cd351d454af2f105fe0 moved disable_hlt() from
> arch/arm/include/asm/system.h to arch/arm/include/asm/system_misc.h but missed
> to change arch/arm/mach-gemini/irq.c.
>
> This patch fixes following error:
>
> ---8<---
> arch/arm/mach-gemini/irq.c: In function 'gemini_init_irq':
> arch/arm/mach-gemini/irq.c:79:2: error: implicit declaration of function 'disable_hlt' [-Werror=implicit-function-declaration]
> --->8---
>
> Signed-off-by: Andreas Bießmann <[email protected]>
> cc: Hans Ulli Kroll <[email protected]>
> cc: Russell King <[email protected]>
> cc: [email protected]
> ---
> Note: this is broken since 3.4 release, 3.3 is sane.

ping

>
> arch/arm/mach-gemini/irq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-gemini/irq.c b/arch/arm/mach-gemini/irq.c
> index ca70e5f..020852d 100644
> --- a/arch/arm/mach-gemini/irq.c
> +++ b/arch/arm/mach-gemini/irq.c
> @@ -17,6 +17,7 @@
> #include <linux/sched.h>
> #include <asm/irq.h>
> #include <asm/mach/irq.h>
> +#include <asm/system_misc.h>
> #include <mach/hardware.h>
>
> #define IRQ_SOURCE(base_addr) (base_addr + 0x00)
>

2012-08-01 07:33:23

by Andreas Bießmann

[permalink] [raw]
Subject: Re: [PATCH] arm:gemini: fix irq.c

ping

On 29.06.12 22:44, Andreas Bießmann wrote:
> On 06.06.12 13:22, Andreas Bießmann wrote:
>> Commit 9f97da78bf018206fb623cd351d454af2f105fe0 moved disable_hlt() from
>> arch/arm/include/asm/system.h to arch/arm/include/asm/system_misc.h but missed
>> to change arch/arm/mach-gemini/irq.c.
>>
>> This patch fixes following error:
>>
>> ---8<---
>> arch/arm/mach-gemini/irq.c: In function 'gemini_init_irq':
>> arch/arm/mach-gemini/irq.c:79:2: error: implicit declaration of function 'disable_hlt' [-Werror=implicit-function-declaration]
>> --->8---
>>
>> Signed-off-by: Andreas Bießmann <[email protected]>
>> cc: Hans Ulli Kroll <[email protected]>
>> cc: Russell King <[email protected]>
>> cc: [email protected]
>> ---
>> Note: this is broken since 3.4 release, 3.3 is sane.
>
> ping
>
>>
>> arch/arm/mach-gemini/irq.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/mach-gemini/irq.c b/arch/arm/mach-gemini/irq.c
>> index ca70e5f..020852d 100644
>> --- a/arch/arm/mach-gemini/irq.c
>> +++ b/arch/arm/mach-gemini/irq.c
>> @@ -17,6 +17,7 @@
>> #include <linux/sched.h>
>> #include <asm/irq.h>
>> #include <asm/mach/irq.h>
>> +#include <asm/system_misc.h>
>> #include <mach/hardware.h>
>>
>> #define IRQ_SOURCE(base_addr) (base_addr + 0x00)
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>