2012-08-09 15:13:54

by Paolo Bonzini

[permalink] [raw]
Subject: Re: [net-next RFC V5 3/5] virtio: intorduce an API to set affinity for a virtqueue

Il 05/07/2012 12:29, Jason Wang ha scritto:
> Sometimes, virtio device need to configure irq affiniry hint to maximize the
> performance. Instead of just exposing the irq of a virtqueue, this patch
> introduce an API to set the affinity for a virtqueue.
>
> The api is best-effort, the affinity hint may not be set as expected due to
> platform support, irq sharing or irq type. Currently, only pci method were
> implemented and we set the affinity according to:
>
> - if device uses INTX, we just ignore the request
> - if device has per vq vector, we force the affinity hint
> - if the virtqueues share MSI, make the affinity OR over all affinities
> requested
>
> Signed-off-by: Jason Wang <[email protected]>

It looks like both I and Jason will need these patches during the 3.7
merge window, and from different trees (net-next vs. scsi). How do we
synchronize?

Paolo


2012-08-09 15:37:44

by Avi Kivity

[permalink] [raw]
Subject: Re: [net-next RFC V5 3/5] virtio: intorduce an API to set affinity for a virtqueue

On 08/09/2012 06:13 PM, Paolo Bonzini wrote:
> Il 05/07/2012 12:29, Jason Wang ha scritto:
>> Sometimes, virtio device need to configure irq affiniry hint to maximize the
>> performance. Instead of just exposing the irq of a virtqueue, this patch
>> introduce an API to set the affinity for a virtqueue.
>>
>> The api is best-effort, the affinity hint may not be set as expected due to
>> platform support, irq sharing or irq type. Currently, only pci method were
>> implemented and we set the affinity according to:
>>
>> - if device uses INTX, we just ignore the request
>> - if device has per vq vector, we force the affinity hint
>> - if the virtqueues share MSI, make the affinity OR over all affinities
>> requested
>>
>> Signed-off-by: Jason Wang <[email protected]>
>
> It looks like both I and Jason will need these patches during the 3.7
> merge window, and from different trees (net-next vs. scsi). How do we
> synchronize?

Get one of them to promise not to rebase, merge it, and base your
patches on top of the merge.

--
error compiling committee.c: too many arguments to function