2012-08-30 15:05:15

by Marco Stornelli

Subject: [PATCH 5/8] hpfs: drop lock/unlock super

Removed lock/unlock super.

Signed-off-by: Marco Stornelli <[email protected]>
---
fs/hpfs/super.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/fs/hpfs/super.c b/fs/hpfs/super.c
index 706a12c..8af2cdc 100644
--- a/fs/hpfs/super.c
+++ b/fs/hpfs/super.c
@@ -389,7 +389,6 @@ static int hpfs_remount_fs(struct super_block *s, int *flags, char *data)
*flags |= MS_NOATIME;

hpfs_lock(s);
- lock_super(s);
uid = sbi->sb_uid; gid = sbi->sb_gid;
umask = 0777 & ~sbi->sb_mode;
lowercase = sbi->sb_lowercase;
@@ -422,12 +421,10 @@ static int hpfs_remount_fs(struct super_block *s, int *flags, char *data)

replace_mount_options(s, new_opts);

- unlock_super(s);
hpfs_unlock(s);
return 0;

out_err:
- unlock_super(s);
hpfs_unlock(s);
kfree(new_opts);
return -EINVAL;
--
1.7.3.4

2012-08-30 23:59:13

by Mikulas Patocka

Subject: Re: [PATCH 5/8] hpfs: drop lock/unlock super

It looks ok.

Mikulas

On Thu, 30 Aug 2012, Marco Stornelli wrote:

> Removed lock/unlock super.
>
> Signed-off-by: Marco Stornelli <[email protected]>
> ---
> fs/hpfs/super.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/fs/hpfs/super.c b/fs/hpfs/super.c
> index 706a12c..8af2cdc 100644
> --- a/fs/hpfs/super.c
> +++ b/fs/hpfs/super.c
> @@ -389,7 +389,6 @@ static int hpfs_remount_fs(struct super_block *s, int *flags, char *data)
> *flags |= MS_NOATIME;
>
> hpfs_lock(s);
> - lock_super(s);
> uid = sbi->sb_uid; gid = sbi->sb_gid;
> umask = 0777 & ~sbi->sb_mode;
> lowercase = sbi->sb_lowercase;
> @@ -422,12 +421,10 @@ static int hpfs_remount_fs(struct super_block *s, int *flags, char *data)
>
> replace_mount_options(s, new_opts);
>
> - unlock_super(s);
> hpfs_unlock(s);
> return 0;
>
> out_err:
> - unlock_super(s);
> hpfs_unlock(s);
> kfree(new_opts);
> return -EINVAL;
> --
> 1.7.3.4
>