2007-05-17 11:26:46

by Borislav Petkov

Subject: [PATCH] ide.c: microscopic size and readability optimization

-----
From: [email protected]

A very small size (object file 432 bytes smaller) and readability optimization of ide.c

Signed-off-by: Borislav Petkov <[email protected]>

--
Index: 22-rc1/drivers/ide/ide.c
===================================================================
--- 22-rc1/drivers/ide/ide.c.orig
+++ 22-rc1/drivers/ide/ide.c
@@ -568,10 +568,8 @@ void ide_unregister(unsigned int index)
ide_hwgroup_t *hwgroup;
int irq_count = 0, unit;

- BUG_ON(index >= MAX_HWIFS);
+ BUG_ON(index >= MAX_HWIFS || in_interrupt() || irqs_disabled());

- BUG_ON(in_interrupt());
- BUG_ON(irqs_disabled());
down(&ide_cfg_sem);
spin_lock_irq(&ide_lock);
hwif = &ide_hwifs[index];

2007-05-17 11:34:14

by Paul Sokolovsky

Subject: Re: [PATCH] ide.c: microscopic size and readability optimization

Hello Borislav,

Thursday, May 17, 2007, 2:25:54 PM, you wrote:

> -----
> From: [email protected]

> A very small size (object file 432 bytes smaller) and readability optimization of ide.c

And how these "optimizations" fit with BUG_ON() purpose - to
be able to easily identify cause and place of the failure? You
could just remove them altogether and claim that you did even "better"
"optimization".

> Signed-off-by: Borislav Petkov <[email protected]>

> --
> Index: 22-rc1/drivers/ide/ide.c
> ===================================================================
> --- 22-rc1/drivers/ide/ide.c.orig
> +++ 22-rc1/drivers/ide/ide.c
> @@ -568,10 +568,8 @@ void ide_unregister(unsigned int index)
> ide_hwgroup_t *hwgroup;
> int irq_count = 0, unit;

> - BUG_ON(index >= MAX_HWIFS);
> + BUG_ON(index >= MAX_HWIFS || in_interrupt() || irqs_disabled());

> - BUG_ON(in_interrupt());
> - BUG_ON(irqs_disabled());
> down(&ide_cfg_sem);



--
Best regards,
Paul mailto:[email protected]

2007-05-17 12:02:18

by Alan

Subject: Re: [PATCH] ide.c: microscopic size and readability optimization

On Thu, 17 May 2007 13:25:54 +0200
Borislav Petkov <[email protected]> wrote:

> -----
> From: [email protected]
>
> A very small size (object file 432 bytes smaller) and readability optimization of ide.c
>
> Signed-off-by: Borislav Petkov <[email protected]>

Bad idea. Now you won't know which of the conditions caused the BUG() to
occur.

2007-05-18 08:34:58

by Borislav Petkov

Subject: Re: [PATCH] ide.c: microscopic size and readability optimization

--- Alan Cox <[email protected]> schrieb:

> On Thu, 17 May 2007 13:25:54 +0200
> Borislav Petkov <[email protected]> wrote:
>
> > -----
> > From: [email protected]
> >
> > A very small size (object file 432 bytes smaller)
> and readability optimization of ide.c
> >
> > Signed-off-by: Borislav Petkov <[email protected]>
>
> Bad idea. Now you won't know which of the conditions
> caused the BUG() to
> occur.

Ups, sorry, that I hadn't considered. Nevermind the
noise.

Boris.




___________________________________________________________
Telefonate ohne weitere Kosten vom PC zum PC: http://messenger.yahoo.de