2019-08-03 14:04:50

by Yannick FERTRE

Subject: [PATCH] ARM: dts: stm32: move ltdc pinctrl on stm32mp157a dk1 board

The ltdc pinctrl must be in the display controller node and
not in the peripheral node (hdmi bridge).

Signed-off-by: Yannick Fertré <[email protected]>
---
arch/arm/boot/dts/stm32mp157a-dk1.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/stm32mp157a-dk1.dts b/arch/arm/boot/dts/stm32mp157a-dk1.dts
index f3f0e37..1285cfc 100644
--- a/arch/arm/boot/dts/stm32mp157a-dk1.dts
+++ b/arch/arm/boot/dts/stm32mp157a-dk1.dts
@@ -99,9 +99,6 @@
reset-gpios = <&gpioa 10 GPIO_ACTIVE_LOW>;
interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
interrupt-parent = <&gpiog>;
- pinctrl-names = "default", "sleep";
- pinctrl-0 = <&ltdc_pins_a>;
- pinctrl-1 = <&ltdc_pins_sleep_a>;
status = "okay";

ports {
@@ -276,6 +273,9 @@
};

&ltdc {
+ pinctrl-names = "default", "sleep";
+ pinctrl-0 = <&ltdc_pins_a>;
+ pinctrl-1 = <&ltdc_pins_sleep_a>;
status = "okay";

port {
--
2.7.4

2019-09-02 08:54:35

by Philippe Cornu

Subject: Re: [PATCH] ARM: dts: stm32: move ltdc pinctrl on stm32mp157a dk1 board

Hi Yannick,

On 8/2/19 4:08 PM, Yannick Fertré wrote:
> The ltdc pinctrl must be in the display controller node and
> not in the peripheral node (hdmi bridge).
>
> Signed-off-by: Yannick Fertré <[email protected]>
> ---
> arch/arm/boot/dts/stm32mp157a-dk1.dts | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp157a-dk1.dts b/arch/arm/boot/dts/stm32mp157a-dk1.dts
> index f3f0e37..1285cfc 100644
> --- a/arch/arm/boot/dts/stm32mp157a-dk1.dts
> +++ b/arch/arm/boot/dts/stm32mp157a-dk1.dts
> @@ -99,9 +99,6 @@
> reset-gpios = <&gpioa 10 GPIO_ACTIVE_LOW>;
> interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
> interrupt-parent = <&gpiog>;
> - pinctrl-names = "default", "sleep";
> - pinctrl-0 = <&ltdc_pins_a>;
> - pinctrl-1 = <&ltdc_pins_sleep_a>;
> status = "okay";
>
> ports {
> @@ -276,6 +273,9 @@
> };
>
> &ltdc {
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&ltdc_pins_a>;
> + pinctrl-1 = <&ltdc_pins_sleep_a>;

Reviewed-by: Philippe Cornu <[email protected]>

Thanks
Philippe :)

> status = "okay";
>
> port {
>

2019-09-02 10:16:01

by Benjamin Gaignard

Subject: Re: [PATCH] ARM: dts: stm32: move ltdc pinctrl on stm32mp157a dk1 board

+ dri-devel mailing list

Le lun. 2 sept. 2019 à 10:45, Philippe CORNU <[email protected]> a écrit :
>
> Hi Yannick,
>
> On 8/2/19 4:08 PM, Yannick Fertré wrote:
> > The ltdc pinctrl must be in the display controller node and
> > not in the peripheral node (hdmi bridge).
> >
> > Signed-off-by: Yannick Fertré <[email protected]>
> > ---
> > arch/arm/boot/dts/stm32mp157a-dk1.dts | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/stm32mp157a-dk1.dts b/arch/arm/boot/dts/stm32mp157a-dk1.dts
> > index f3f0e37..1285cfc 100644
> > --- a/arch/arm/boot/dts/stm32mp157a-dk1.dts
> > +++ b/arch/arm/boot/dts/stm32mp157a-dk1.dts
> > @@ -99,9 +99,6 @@
> > reset-gpios = <&gpioa 10 GPIO_ACTIVE_LOW>;
> > interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
> > interrupt-parent = <&gpiog>;
> > - pinctrl-names = "default", "sleep";
> > - pinctrl-0 = <&ltdc_pins_a>;
> > - pinctrl-1 = <&ltdc_pins_sleep_a>;
> > status = "okay";
> >
> > ports {
> > @@ -276,6 +273,9 @@
> > };
> >
> > &ltdc {
> > + pinctrl-names = "default", "sleep";
> > + pinctrl-0 = <&ltdc_pins_a>;
> > + pinctrl-1 = <&ltdc_pins_sleep_a>;
>
> Reviewed-by: Philippe Cornu <[email protected]>
>
> Thanks
> Philippe :)
>
> > status = "okay";
> >
> > port {
> >
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

2019-10-03 10:09:33

by Alexandre Torgue

Subject: Re: [PATCH] ARM: dts: stm32: move ltdc pinctrl on stm32mp157a dk1 board

Hi Yannick

On 8/2/19 4:08 PM, Yannick Fertré wrote:
> The ltdc pinctrl must be in the display controller node and
> not in the peripheral node (hdmi bridge).
>
> Signed-off-by: Yannick Fertré <[email protected]>
> ---
> arch/arm/boot/dts/stm32mp157a-dk1.dts | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp157a-dk1.dts b/arch/arm/boot/dts/stm32mp157a-dk1.dts
> index f3f0e37..1285cfc 100644
> --- a/arch/arm/boot/dts/stm32mp157a-dk1.dts
> +++ b/arch/arm/boot/dts/stm32mp157a-dk1.dts
> @@ -99,9 +99,6 @@
> reset-gpios = <&gpioa 10 GPIO_ACTIVE_LOW>;
> interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
> interrupt-parent = <&gpiog>;
> - pinctrl-names = "default", "sleep";
> - pinctrl-0 = <&ltdc_pins_a>;
> - pinctrl-1 = <&ltdc_pins_sleep_a>;
> status = "okay";
>
> ports {
> @@ -276,6 +273,9 @@
> };
>
> &ltdc {
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&ltdc_pins_a>;
> + pinctrl-1 = <&ltdc_pins_sleep_a>;
> status = "okay";
>
> port {
>

Applied on stm32-next.

Thanks.
Alex