2012-10-06 07:24:52

by wwang

[permalink] [raw]
Subject: Re: [PATCH v6 0/3] Add modules to support realtek PCIE card reader

于 2012年09月29日 23:29, Borislav Petkov 写道:
> On Sat, Sep 29, 2012 at 09:41:17AM -0400, Chris Ball wrote:
>> On Sat, Sep 29 2012, Borislav Petkov wrote:
>>> So, I think that this driver has seen a bunch of testing and reviewing
>>> and we might start considering upstreaming it. There are a bunch of
>>> laptops integrating those readers and maybe a single three-month-ish -rc
>>> period of testing wouldn't hurt before it appears upstream.
>>>
>>> Now, AFAICT, there is another driver in staging which supports the same
>>> or a subset of the cardreaders this driver does so I don't know what
>>> Realsil want to do with that. Wei?
>>>
>>> And since this driver touches multiple drivers/{mfd,mmc,memstick}
>>> subdirs, maybe akpm would like to merge it? At least I haven't seen any
>>> other maintainers complaining about its design or wanting to take it so
>> I think you've missed the mails -- Alex Dubov has acked the memstick
>> portion, Samuel Ortiz has said he'll push the MFD driver for 3.7,
>> and I've pushed the MMC driver into mmc-next for 3.7. So, I think
>> we should merge it. I don't think we need akpm, since there are no
>> build-time dependencies involved.
> Great, all is taken care of then.
>
> Only the staging driver remains, I believe the CONFIG_RTS_PSTOR one. Wei?
>
> Thanks.
>
Hi all:

Sorry for my late reply. I'm on my vacation these days.

At first I want to explain the relationship between the staging driver
"rts_pstor" with this one here.
Initially, we tried to build a SCSI driver for Realtek PCI-E card
reader, which has the same architecture and code base with our Windows
driver. And I pushed rts_pstor to staging tree last year. But Realtek
PCI-E card reader is not a real SCSI device, which doesn't understand
SCSI command at all. So SCSI subsystem won't accept rts_pstor, and I
can't find a proper subsystem to push it to. That's why I create this
series of drivers, which are more compatible with the whole Linux
architecture.
We are still maintaining the SCSI driver for Realtek card reader, and
will release the latest source code in the Github in the future. But
maybe we won't push it to the staging tree any more.

BR,
Wei WANG


2012-10-20 03:47:00

by Dan Carpenter

[permalink] [raw]
Subject: Re: [PATCH v6 0/3] Add modules to support realtek PCIE card reader

On Sat, Oct 06, 2012 at 03:23:56PM +0800, wwang wrote:
> We are still maintaining the SCSI driver for Realtek card reader,
> and will release the latest source code in the Github in the future.
> But maybe we won't push it to the staging tree any more.

Maybe we should just remove the staging code if it won't be fixed.
That's sort of the point of staging.

regards,
dan carpenter

2012-10-25 18:50:47

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v6 0/3] Add modules to support realtek PCIE card reader

On Sat, Oct 20, 2012 at 06:46:15AM +0300, Dan Carpenter wrote:
> On Sat, Oct 06, 2012 at 03:23:56PM +0800, wwang wrote:
> > We are still maintaining the SCSI driver for Realtek card reader,
> > and will release the latest source code in the Github in the future.
> > But maybe we won't push it to the staging tree any more.
>
> Maybe we should just remove the staging code if it won't be fixed.
> That's sort of the point of staging.

I agree. wwang, want me to delet the staging driver now? I don't want
"dead" code in the tree, especially as you don't want to maintain it
anymore.

thanks,

greg k-h

2012-10-26 01:11:59

by wwang

[permalink] [raw]
Subject: Re: [PATCH v6 0/3] Add modules to support realtek PCIE card reader

?? 2012??10??26?? 02:50, Greg KH д??:
> On Sat, Oct 20, 2012 at 06:46:15AM +0300, Dan Carpenter wrote:
>> On Sat, Oct 06, 2012 at 03:23:56PM +0800, wwang wrote:
>>> We are still maintaining the SCSI driver for Realtek card reader,
>>> and will release the latest source code in the Github in the future.
>>> But maybe we won't push it to the staging tree any more.
>> Maybe we should just remove the staging code if it won't be fixed.
>> That's sort of the point of staging.
> I agree. wwang, want me to delet the staging driver now? I don't want
> "dead" code in the tree, especially as you don't want to maintain it
> anymore.
>
> thanks,
>
> greg k-h
Hi Greg:

OK. You can delete it now, please.
And I will push my new driver to MFD and MMC subsystem.

Best Regards,
wwang

2012-10-26 02:45:19

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v6 0/3] Add modules to support realtek PCIE card reader

On Fri, Oct 26, 2012 at 09:10:45AM +0800, wwang wrote:
> 于 2012年10月26日 02:50, Greg KH 写道:
> > On Sat, Oct 20, 2012 at 06:46:15AM +0300, Dan Carpenter wrote:
> >> On Sat, Oct 06, 2012 at 03:23:56PM +0800, wwang wrote:
> >>> We are still maintaining the SCSI driver for Realtek card reader,
> >>> and will release the latest source code in the Github in the future.
> >>> But maybe we won't push it to the staging tree any more.
> >> Maybe we should just remove the staging code if it won't be fixed.
> >> That's sort of the point of staging.
> > I agree. wwang, want me to delet the staging driver now? I don't want
> > "dead" code in the tree, especially as you don't want to maintain it
> > anymore.
> >
> > thanks,
> >
> > greg k-h
> Hi Greg:
>
> OK. You can delete it now, please.
> And I will push my new driver to MFD and MMC subsystem.

Ok, just to confirm, you want me to delete the
drivers/staging/rts_pstor/* code, right?

thanks,

greg k-h

2012-10-26 02:52:32

by wwang

[permalink] [raw]
Subject: Re: [PATCH v6 0/3] Add modules to support realtek PCIE card reader

于 2012年10月26日 10:45, Greg KH 写道:
> On Fri, Oct 26, 2012 at 09:10:45AM +0800, wwang wrote:
>> 于 2012年10月26日 02:50, Greg KH 写道:
>>> On Sat, Oct 20, 2012 at 06:46:15AM +0300, Dan Carpenter wrote:
>>>> On Sat, Oct 06, 2012 at 03:23:56PM +0800, wwang wrote:
>>>>> We are still maintaining the SCSI driver for Realtek card reader,
>>>>> and will release the latest source code in the Github in the future.
>>>>> But maybe we won't push it to the staging tree any more.
>>>> Maybe we should just remove the staging code if it won't be fixed.
>>>> That's sort of the point of staging.
>>> I agree. wwang, want me to delet the staging driver now? I don't want
>>> "dead" code in the tree, especially as you don't want to maintain it
>>> anymore.
>>>
>>> thanks,
>>>
>>> greg k-h
>> Hi Greg:
>>
>> OK. You can delete it now, please.
>> And I will push my new driver to MFD and MMC subsystem.
> Ok, just to confirm, you want me to delete the
> drivers/staging/rts_pstor/* code, right?
>
> thanks,
>
> greg k-h
Hi Greg:

Yes, you can delete drivers/staging/rts_pstor

BR,
wwang

2012-10-26 16:04:20

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v6 0/3] Add modules to support realtek PCIE card reader

On Fri, Oct 26, 2012 at 10:51:23AM +0800, wwang wrote:
> 于 2012年10月26日 10:45, Greg KH 写道:
> >On Fri, Oct 26, 2012 at 09:10:45AM +0800, wwang wrote:
> >>于 2012年10月26日 02:50, Greg KH 写道:
> >>>On Sat, Oct 20, 2012 at 06:46:15AM +0300, Dan Carpenter wrote:
> >>>>On Sat, Oct 06, 2012 at 03:23:56PM +0800, wwang wrote:
> >>>>>We are still maintaining the SCSI driver for Realtek card reader,
> >>>>>and will release the latest source code in the Github in the future.
> >>>>>But maybe we won't push it to the staging tree any more.
> >>>>Maybe we should just remove the staging code if it won't be fixed.
> >>>>That's sort of the point of staging.
> >>>I agree. wwang, want me to delet the staging driver now? I don't want
> >>>"dead" code in the tree, especially as you don't want to maintain it
> >>>anymore.
> >>>
> >>>thanks,
> >>>
> >>>greg k-h
> >>Hi Greg:
> >>
> >>OK. You can delete it now, please.
> >>And I will push my new driver to MFD and MMC subsystem.
> >Ok, just to confirm, you want me to delete the
> >drivers/staging/rts_pstor/* code, right?
> >
> >thanks,
> >
> >greg k-h
> Hi Greg:
>
> Yes, you can delete drivers/staging/rts_pstor

Thanks, now done.

greg k-h