2012-10-06 08:39:53

by Marco Stornelli

Subject: [PATCH 17/22] ncpfs: drop vmtruncate

Removed vmtruncate.

Signed-off-by: Marco Stornelli <[email protected]>
---
fs/ncpfs/inode.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/fs/ncpfs/inode.c b/fs/ncpfs/inode.c
index d7e9fe7..b6881aa 100644
--- a/fs/ncpfs/inode.c
+++ b/fs/ncpfs/inode.c
@@ -976,9 +976,11 @@ int ncp_notify_change(struct dentry *dentry, struct iattr *attr)
goto out;

if (attr->ia_size != i_size_read(inode)) {
- result = vmtruncate(inode, attr->ia_size);
+ result = inode_newsize_ok(inode, attr->ia_size);
if (result)
goto out;
+
+ truncate_setsize(inode, attr->ia_size);
mark_inode_dirty(inode);
}
}
--
1.7.3.4

2012-10-13 16:23:30

by Christoph Hellwig

Subject: Re: [PATCH 17/22] ncpfs: drop vmtruncate

> if (attr->ia_size != i_size_read(inode)) {
> - result = vmtruncate(inode, attr->ia_size);
> + result = inode_newsize_ok(inode, attr->ia_size);
> if (result)
> goto out;
> +
> + truncate_setsize(inode, attr->ia_size);
> mark_inode_dirty(inode);

inode_newsize_ok already is done as part of inode_change_ok earlier on.