2012-10-12 08:23:18

by Yasuaki Ishimatsu

Subject: [PATCH] mm: cleanup register_node()

register_node() is defined as extern in include/linux/node.h. But the function
is only called from register_one_node() in driver/base/node.c.

So the patch defines register_node() as static.

CC: David Rientjes <[email protected]>
CC: Andrew Morton <[email protected]>
Signed-off-by: Yasuaki Ishimatsu <[email protected]>

---
drivers/base/node.c | 2 +-
include/linux/node.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)

Index: linux-3.6/drivers/base/node.c
===================================================================
--- linux-3.6.orig/drivers/base/node.c 2012-10-12 16:35:51.000000000 +0900
+++ linux-3.6/drivers/base/node.c 2012-10-12 16:52:25.294207322 +0900
@@ -259,7 +259,7 @@ static inline void hugetlb_unregister_no
*
* Initialize and register the node device.
*/
-int register_node(struct node *node, int num, struct node *parent)
+static int register_node(struct node *node, int num, struct node *parent)
{
int error;

Index: linux-3.6/include/linux/node.h
===================================================================
--- linux-3.6.orig/include/linux/node.h 2012-10-01 08:47:46.000000000 +0900
+++ linux-3.6/include/linux/node.h 2012-10-12 16:52:55.215210433 +0900
@@ -30,7 +30,6 @@ struct memory_block;
extern struct node node_devices[];
typedef void (*node_registration_func_t)(struct node *);

-extern int register_node(struct node *, int, struct node *);
extern void unregister_node(struct node *node);
#ifdef CONFIG_NUMA
extern int register_one_node(int nid);

2012-10-13 09:56:06

by David Rientjes

Subject: Re: [PATCH] mm: cleanup register_node()

On Fri, 12 Oct 2012, Yasuaki Ishimatsu wrote:

> register_node() is defined as extern in include/linux/node.h. But the function
> is only called from register_one_node() in driver/base/node.c.
>
> So the patch defines register_node() as static.
>
> CC: David Rientjes <[email protected]>
> CC: Andrew Morton <[email protected]>
> Signed-off-by: Yasuaki Ishimatsu <[email protected]>

Acked-by: David Rientjes <[email protected]>

Thanks!

2012-10-13 23:17:23

by KOSAKI Motohiro

Subject: Re: [PATCH] mm: cleanup register_node()

On Fri, Oct 12, 2012 at 4:22 AM, Yasuaki Ishimatsu
<[email protected]> wrote:
> register_node() is defined as extern in include/linux/node.h. But the function
> is only called from register_one_node() in driver/base/node.c.
>
> So the patch defines register_node() as static.
>
> CC: David Rientjes <[email protected]>
> CC: Andrew Morton <[email protected]>
> Signed-off-by: Yasuaki Ishimatsu <[email protected]>

Acked-by: KOSAKI Motohiro <[email protected]>