2012-10-12 00:04:05

by Sanagi, Koki

Subject: [PATCH] kvm/ftrace: change the diplaying format of vector in trace_msi_set_irq

This patch changes the way to diplay the vector in trace_msi_set_irq from %x to
%u. Currently, it mismatches another output of ftrace such as kvm_msi_set_irq
and kvm_inj_virq which uses %u.

Signed-off-by: Koki Sanagi <[email protected]>
---
include/trace/events/kvm.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/trace/events/kvm.h b/include/trace/events/kvm.h
index 7ef9e75..0a83632 100644
--- a/include/trace/events/kvm.h
+++ b/include/trace/events/kvm.h
@@ -109,7 +109,7 @@ TRACE_EVENT(kvm_msi_set_irq,
__entry->data = data;
),

- TP_printk("dst %u vec %x (%s|%s|%s%s)",
+ TP_printk("dst %u vec %u (%s|%s|%s%s)",
(u8)(__entry->address >> 12), (u8)__entry->data,
__print_symbolic((__entry->data >> 8 & 0x7), kvm_deliver_mode),
(__entry->address & (1<<2)) ? "logical" : "physical",
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?

2012-10-18 14:49:09

by Avi Kivity

Subject: Re: [PATCH] kvm/ftrace: change the diplaying format of vector in trace_msi_set_irq

On 10/12/2012 02:03 AM, Sanagi, Koki wrote:
> This patch changes the way to diplay the vector in trace_msi_set_irq from %x to
> %u. Currently, it mismatches another output of ftrace such as kvm_msi_set_irq
> and kvm_inj_virq which uses %u.
>
> Signed-off-by: Koki Sanagi <[email protected]>
> ---
> include/trace/events/kvm.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/trace/events/kvm.h b/include/trace/events/kvm.h
> index 7ef9e75..0a83632 100644
> --- a/include/trace/events/kvm.h
> +++ b/include/trace/events/kvm.h
> @@ -109,7 +109,7 @@ TRACE_EVENT(kvm_msi_set_irq,
> __entry->data = data;
> ),
>
> - TP_printk("dst %u vec %x (%s|%s|%s%s)",
> + TP_printk("dst %u vec %u (%s|%s|%s%s)",
> (u8)(__entry->address >> 12), (u8)__entry->data,
> __print_symbolic((__entry->data >> 8 & 0x7), kvm_deliver_mode),
> (__entry->address & (1<<2)) ? "logical" : "physical",


Changing them all to %02x is probably better. For example, writes to
APIC_ICR will be shown as hex, with the vector in the low order 8 bits,
so it will be easier to match them if they are all in hex.


--
error compiling committee.c: too many arguments to function