2012-10-27 08:00:51

by Toralf Förster

[permalink] [raw]
Subject: RFC: kconfig option CONFIG_LBDAF should be auto-selected if EXT4 is chosen


otherwise booting an EXT4 image won't work b/c the root fs can't be
mounted read-write - and as a side effect no syslog messages might
point the user to this issue (at least in my setup) ...

:-/

--
MfG/Sincerely
Toralf Förster
pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3


2012-10-27 08:24:20

by Theodore Ts'o

[permalink] [raw]
Subject: Re: RFC: kconfig option CONFIG_LBDAF should be auto-selected if EXT4 is chosen

On Sat, Oct 27, 2012 at 10:00:46AM +0200, Toralf F?rster wrote:
>
> otherwise booting an EXT4 image won't work b/c the root fs can't be
> mounted read-write - and as a side effect no syslog messages might
> point the user to this issue (at least in my setup) ...

This is only a problem on 32-bit architectues. and it's actually
documented in the Kconfig help message, and it's enabled by default.
So someone would have had to have gone out of their way to turn off
CONFIG_LBDAF. This is the first time I've heard of someone getting
surprised by this; do you know how CONFIG_LBDAF got disabled? Did you
just disable it without reading the help message?

What we might be able to do instead is to allow the mount to succeed,
but to simply fail any attempts to open(2) or stat(2) files larger
than 2TB with an EFBIG error.

BTW, technically ext4 does not _require_ CONFIG_LBDAF. It's just that
the default mke2fs.conf enables huge_file, so most ext4 file systems
enable it by default. I could imagine systems (like 32-bit Android
handsets) where it's not intended to ever support storage devices
larger than 2TB, so they might very well wnat CONFIG_EXT4 &&
!CONFIG_LBDAF. That's a valid choice, although I do admit some users
might get surprised by this.

Regards,

- Ted



2012-10-27 08:40:35

by Toralf Förster

[permalink] [raw]
Subject: Re: RFC: kconfig option CONFIG_LBDAF should be auto-selected if EXT4 is chosen

On 10/27/2012 10:24 AM, Theodore Ts'o wrote:
> On Sat, Oct 27, 2012 at 10:00:46AM +0200, Toralf Förster wrote:
>>
>> otherwise booting an EXT4 image won't work b/c the root fs can't be
>> mounted read-write - and as a side effect no syslog messages might
>> point the user to this issue (at least in my setup) ...
>
> This is only a problem on 32-bit architectues. and it's actually
> documented in the Kconfig help message, and it's enabled by default.
> So someone would have had to have gone out of their way to turn off
> CONFIG_LBDAF. This is the first time I've heard of someone getting
> surprised by this; do you know how CONFIG_LBDAF got disabled? Did you
> just disable it without reading the help message?

When I use the attached UML config and run "$>make ARCH=um menuconfig"
to select EXT4, then CONFIG_LBDAF is not selected automatically.

> What we might be able to do instead is to allow the mount to succeed,
> but to simply fail any attempts to open(2) or stat(2) files larger
> than 2TB with an EFBIG error.

That would be a cool idea.

--
MfG/Sincerely
Toralf Förster
pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3


Attachments:
.config (21.42 kB)