2012-10-29 07:32:52

by Zhao Hongjiang

Subject: [PATCH] ext4: get rid of the duplicate code on ext4_fill_super

From: Zhao Hongjiang <[email protected]>

Clean the duplicate code on ext4_fill_super cause the bellow
also have it.

Signed-off-by: Zhao Hongjiang <[email protected]>
---
fs/ext4/super.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 80928f7..d21b985 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -3272,9 +3272,6 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
}
sb->s_fs_info = sbi;
sbi->s_sb = sb;
- sbi->s_mount_opt = 0;
- sbi->s_resuid = make_kuid(&init_user_ns, EXT4_DEF_RESUID);
- sbi->s_resgid = make_kgid(&init_user_ns, EXT4_DEF_RESGID);
sbi->s_inode_readahead_blks = EXT4_DEF_INODE_READAHEAD_BLKS;
sbi->s_sb_block = sb_block;
if (sb->s_bdev->bd_part)
-- 1.7.1

2012-11-08 22:21:07

by Theodore Ts'o

Subject: Re: [PATCH] ext4: get rid of the duplicate code on ext4_fill_super

On Mon, Oct 29, 2012 at 03:32:08PM +0800, Zhao Hongjiang wrote:
> From: Zhao Hongjiang <[email protected]>
>
> Clean the duplicate code on ext4_fill_super cause the bellow
> also have it.
>
> Signed-off-by: Zhao Hongjiang <[email protected]>

Applied, thanks!

I used the commit description:

ext4: get rid of redundant code in ext4_fill_super()

- Ted