2012-10-29 08:38:24

by Axel Lin

Subject: [PATCH] backlight: lm3639_bl: Fix up world writable sysfs file

We don't need the sysfs file to be world writable or group writable.
This file is write-only, change it to S_IWUSR (0200).

Signed-off-by: Axel Lin <[email protected]>
---
drivers/video/backlight/lm3639_bl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/backlight/lm3639_bl.c b/drivers/video/backlight/lm3639_bl.c
index 585949b..6f7a20e 100644
--- a/drivers/video/backlight/lm3639_bl.c
+++ b/drivers/video/backlight/lm3639_bl.c
@@ -214,7 +214,7 @@ out_input:

}

-static DEVICE_ATTR(bled_mode, 0666, NULL, lm3639_bled_mode_store);
+static DEVICE_ATTR(bled_mode, S_IWUSR, NULL, lm3639_bled_mode_store);

/* torch */
static void lm3639_torch_brightness_set(struct led_classdev *cdev,
--
1.7.9.5

2012-10-29 11:02:44

by Daniel Jeong

Subject: Re: [PATCH] backlight: lm3639_bl: Fix up world writable sysfs file

2012년 10월 29일 17:38, Axel Lin 쓴 글:
> We don't need the sysfs file to be world writable or group writable.
> This file is write-only, change it to S_IWUSR (0200).
>
> Signed-off-by: Axel Lin <[email protected]>
> ---
> drivers/video/backlight/lm3639_bl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/lm3639_bl.c b/drivers/video/backlight/lm3639_bl.c
> index 585949b..6f7a20e 100644
> --- a/drivers/video/backlight/lm3639_bl.c
> +++ b/drivers/video/backlight/lm3639_bl.c
> @@ -214,7 +214,7 @@ out_input:
>
> }
>
> -static DEVICE_ATTR(bled_mode, 0666, NULL, lm3639_bled_mode_store);
> +static DEVICE_ATTR(bled_mode, S_IWUSR, NULL, lm3639_bled_mode_store);
>
> /* torch */
> static void lm3639_torch_brightness_set(struct led_classdev *cdev,

It's also nice to us. Thank you Alex.
Acked-by: G.Shark Jeong<[email protected]>