2012-10-30 22:22:09

by Sergei Trofimovich

Subject: [PATCH] exynos: mmc: use correct variable for MODULE_DEVICE_TABLE

From: Sergei Trofimovich <[email protected]>

Found by gcc:

linux-2.6/drivers/mmc/host/dw_mmc-exynos.c: At top level:
linux-2.6/drivers/mmc/host/dw_mmc-exynos.c:226:1: error: '__mod_of_device_table' aliased to undefined symbol 'dw_mci_pltfm_match'

CC: Chris Ball <[email protected]>
CC: Thomas Abraham <[email protected]>
CC: Will Newton <[email protected]>
CC: [email protected]
CC: [email protected]
Signed-off-by: Sergei Trofimovich <[email protected]>
---
drivers/mmc/host/dw_mmc-exynos.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
index 660bbc5..0147ac3a 100644
--- a/drivers/mmc/host/dw_mmc-exynos.c
+++ b/drivers/mmc/host/dw_mmc-exynos.c
@@ -223,7 +223,7 @@ static const struct of_device_id dw_mci_exynos_match[] = {
.data = (void *)&exynos5250_drv_data, },
{},
};
-MODULE_DEVICE_TABLE(of, dw_mci_pltfm_match);
+MODULE_DEVICE_TABLE(of, dw_mci_exynos_match);

int dw_mci_exynos_probe(struct platform_device *pdev)
{
--
1.7.12.4

2012-10-31 04:33:53

by Jaehoon Chung

Subject: Re: [PATCH] exynos: mmc: use correct variable for MODULE_DEVICE_TABLE

Looks good to me.

Acked-by: Jaehoon Chung <[email protected]>

On 10/31/2012 07:21 AM, Sergei Trofimovich wrote:
> From: Sergei Trofimovich <[email protected]>
>
> Found by gcc:
>
> linux-2.6/drivers/mmc/host/dw_mmc-exynos.c: At top level:
> linux-2.6/drivers/mmc/host/dw_mmc-exynos.c:226:1: error: '__mod_of_device_table' aliased to undefined symbol 'dw_mci_pltfm_match'
>
> CC: Chris Ball <[email protected]>
> CC: Thomas Abraham <[email protected]>
> CC: Will Newton <[email protected]>
> CC: [email protected]
> CC: [email protected]
> Signed-off-by: Sergei Trofimovich <[email protected]>
> ---
> drivers/mmc/host/dw_mmc-exynos.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
> index 660bbc5..0147ac3a 100644
> --- a/drivers/mmc/host/dw_mmc-exynos.c
> +++ b/drivers/mmc/host/dw_mmc-exynos.c
> @@ -223,7 +223,7 @@ static const struct of_device_id dw_mci_exynos_match[] = {
> .data = (void *)&exynos5250_drv_data, },
> {},
> };
> -MODULE_DEVICE_TABLE(of, dw_mci_pltfm_match);
> +MODULE_DEVICE_TABLE(of, dw_mci_exynos_match);
>
> int dw_mci_exynos_probe(struct platform_device *pdev)
> {
>

2012-11-01 10:07:40

by Seungwon Jeon

Subject: RE: [PATCH] exynos: mmc: use correct variable for MODULE_DEVICE_TABLE

On Wednesday, October 31, 2012, Sergei Trofimovich <[email protected]> wrote:
> From: Sergei Trofimovich <[email protected]>
>
> Found by gcc:
>
> linux-2.6/drivers/mmc/host/dw_mmc-exynos.c: At top level:
> linux-2.6/drivers/mmc/host/dw_mmc-exynos.c:226:1: error: '__mod_of_device_table' aliased to
> undefined symbol 'dw_mci_pltfm_match'
>
> CC: Chris Ball <[email protected]>
> CC: Thomas Abraham <[email protected]>
> CC: Will Newton <[email protected]>
> CC: [email protected]
> CC: [email protected]
> Signed-off-by: Sergei Trofimovich <[email protected]>
> ---
Acked-by: Seungwon Jeon <[email protected]>

I suggest changing the prefix of subject.
'mmc: dw_mmc-exynos' instead of 'exynos: mmc'

Thanks,
Seungwon Jeon