2012-11-01 23:11:49

by Chris Zankel

[permalink] [raw]
Subject: [PULL REQUEST for 3.7-rc4] xtensa: fix syscall table and vfork, and switch to generic thread/execve

Hi Linus,

Would be great if you could pull the Xtensa tree for some important bug
fixes. With the change to uapi, there was a bug introduced that results
in an empty syscall table (mult-inclusion bug). Switching to the generic
thread/execve allowed us to fix a bug we had in vfork().

Thanks,
-Chris

------

The following changes since commit 6f0c0580b70c89094b3422ba81118c7b959c7556:

Linux 3.7-rc2 (2012-10-20 12:11:32 -0700)

are available in the git repository at:

https://github.com/czankel/xtensa-linux.git for_next

for you to fetch changes up to dc241f2c1761bfdec85915f4bbf7e750663f3442:

xtensa: switch to generic sys_execve() (2012-10-25 15:00:44 -0700)

----------------------------------------------------------------
Xtensa patchset for 3.7-rc4

----------------------------------------------------------------
Chris Zankel (3):
xtensa: allow multi-inclusion for uapi/unistd.h
xtensa: use physical addresses for bus addresses
xtensa: reset windowbase/windowstart when cloning the VM

Max Filippov (3):
xtensa: switch to generic kernel_thread()
xtensa: switch to generic kernel_execve()
xtensa: switch to generic sys_execve()

arch/xtensa/Kconfig | 2 +
arch/xtensa/include/asm/io.h | 4 ++
arch/xtensa/include/asm/processor.h | 4 +-
arch/xtensa/include/asm/syscall.h | 2 +-
arch/xtensa/include/asm/unistd.h | 15 ++--
arch/xtensa/include/uapi/asm/unistd.h | 16 ++---
arch/xtensa/kernel/entry.S | 57 ++++-----------
arch/xtensa/kernel/process.c | 128
++++++++++++++++++---------------
arch/xtensa/kernel/syscall.c | 7 +-
arch/xtensa/kernel/xtensa_ksyms.c | 1 -
10 files changed, 104 insertions(+), 132 deletions(-)


2012-11-01 23:24:36

by Linus Torvalds

[permalink] [raw]
Subject: Re: [PULL REQUEST for 3.7-rc4] xtensa: fix syscall table and vfork, and switch to generic thread/execve

On Thu, Nov 1, 2012 at 4:11 PM, Chris Zankel <[email protected]> wrote:
>
> https://github.com/czankel/xtensa-linux.git for_next

We've been here before, haven't we? There's so much wrong with this
that it's not funny.

I don't want https addresses. Yes, I suspect github uses the smart
streaming git mode, but you can't tell by the address, and it's
annoying. Github supports the native git protocol, just show that in
the address, and don't make me have to edit it for stupid reasons. So
the repository address should be

git://github.com/czankel/xtensa-linux.git for_next

.. which brings us to the other problem. I don't do unsigned pulls
from public hosting places. Anybody can put up a github repo, and
people do.

So unless the hosting itself is limited to people I can trust some
other way (ie notably kernel.org, but there are other "controlled
hosting" places too), I really *really* want to see tags with gpg
signatures. Which the above is not.

And I know you can do them, because you've done them in the past. So
please don't continue to do the above.

Linus

2012-11-02 00:17:23

by Chris Zankel

[permalink] [raw]
Subject: [PULL REQUEST for 3.7-rc4 - second attempt] xtensa: fix syscall table and vfork, and switch to generic thread/execve

Hi Linus,

Sorry for the mishap with my previous attempt. I noted the change to use
the git protocol, so it won't happen again (I think I actually used the
wrong one also the past two times). Regarding the invalid tag, I hadn't
pushed the tag up before creating the message, so git-request-pull seems
to have defaulted to the previous tag (or branch name?), and no warning.
I'll verify the tag next time.


Original message:

Would be great if you could pull the Xtensa tree for some important bug
fixes. With the change to uapi, there was a bug introduced that results
in an empty syscall table (mult-inclusion bug). Switching to the generic
thread/execve allowed us to fix a bug we had in vfork().

Thanks,
-Chris

The following changes since commit 6f0c0580b70c89094b3422ba81118c7b959c7556:

Linux 3.7-rc2 (2012-10-20 12:11:32 -0700)

are available in the git repository at:

git://github.com/czankel/xtensa-linux.git tags/xtensa-next-20121101

for you to fetch changes up to dc241f2c1761bfdec85915f4bbf7e750663f3442:

xtensa: switch to generic sys_execve() (2012-10-25 15:00:44 -0700)

----------------------------------------------------------------
Xtensa patchset for 3.7-rc4

----------------------------------------------------------------
Chris Zankel (3):
xtensa: allow multi-inclusion for uapi/unistd.h
xtensa: use physical addresses for bus addresses
xtensa: reset windowbase/windowstart when cloning the VM

Max Filippov (3):
xtensa: switch to generic kernel_thread()
xtensa: switch to generic kernel_execve()
xtensa: switch to generic sys_execve()

arch/xtensa/Kconfig | 2 +
arch/xtensa/include/asm/io.h | 4 ++
arch/xtensa/include/asm/processor.h | 4 +-
arch/xtensa/include/asm/syscall.h | 2 +-
arch/xtensa/include/asm/unistd.h | 15 ++--
arch/xtensa/include/uapi/asm/unistd.h | 16 ++---
arch/xtensa/kernel/entry.S | 57 ++++-----------
arch/xtensa/kernel/process.c | 128 ++++++++++++++++++---------------
arch/xtensa/kernel/syscall.c | 7 +-
arch/xtensa/kernel/xtensa_ksyms.c | 1 -
10 files changed, 104 insertions(+), 132 deletions(-)