2012-11-08 02:45:31

by Axel Lin

Subject: [PATCH 1/2] gpio: tegra: Staticize non-exported symbols

Both tegra_gpio_request() and tegra_gpio_free() are not referenced outside of
this file, make them static.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/gpio/gpio-tegra.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
index c7c175a..d5c01f0 100644
--- a/drivers/gpio/gpio-tegra.c
+++ b/drivers/gpio/gpio-tegra.c
@@ -117,12 +117,12 @@ static void tegra_gpio_disable(int gpio)
}
EXPORT_SYMBOL_GPL(tegra_gpio_disable);

-int tegra_gpio_request(struct gpio_chip *chip, unsigned offset)
+static int tegra_gpio_request(struct gpio_chip *chip, unsigned offset)
{
return pinctrl_request_gpio(offset);
}

-void tegra_gpio_free(struct gpio_chip *chip, unsigned offset)
+static void tegra_gpio_free(struct gpio_chip *chip, unsigned offset)
{
pinctrl_free_gpio(offset);
tegra_gpio_disable(offset);
--
1.7.9.5

2012-11-08 02:47:09

by Axel Lin

Subject: [PATCH 2/2] gpio: tegra: Drop exporting static functions

Both tegra_gpio_enable() and tegra_gpio_disable() are static functions, it does
not make sense to export them.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/gpio/gpio-tegra.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
index d5c01f0..f6cf98f 100644
--- a/drivers/gpio/gpio-tegra.c
+++ b/drivers/gpio/gpio-tegra.c
@@ -109,13 +109,11 @@ static void tegra_gpio_enable(int gpio)
{
tegra_gpio_mask_write(GPIO_MSK_CNF(gpio), gpio, 1);
}
-EXPORT_SYMBOL_GPL(tegra_gpio_enable);

static void tegra_gpio_disable(int gpio)
{
tegra_gpio_mask_write(GPIO_MSK_CNF(gpio), gpio, 0);
}
-EXPORT_SYMBOL_GPL(tegra_gpio_disable);

static int tegra_gpio_request(struct gpio_chip *chip, unsigned offset)
{
--
1.7.9.5

2012-11-08 05:28:05

by Stephen Warren

Subject: Re: [PATCH 1/2] gpio: tegra: Staticize non-exported symbols

On 11/07/2012 07:45 PM, Axel Lin wrote:
> Both tegra_gpio_request() and tegra_gpio_free() are not referenced outside of
> this file, make them static.

Both patches,
Acked-by: Stephen Warren <[email protected]>

2012-11-08 21:34:38

by Linus Walleij

Subject: Re: [PATCH 1/2] gpio: tegra: Staticize non-exported symbols

On Thu, Nov 8, 2012 at 3:45 AM, Axel Lin <[email protected]> wrote:

> Both tegra_gpio_request() and tegra_gpio_free() are not referenced outside of
> this file, make them static.
>
> Signed-off-by: Axel Lin <[email protected]>

Applied with Stephen's ACK.

Yours,
Linus Walleij

2012-11-08 21:36:15

by Linus Walleij

Subject: Re: [PATCH 2/2] gpio: tegra: Drop exporting static functions

On Thu, Nov 8, 2012 at 3:47 AM, Axel Lin <[email protected]> wrote:

> Both tegra_gpio_enable() and tegra_gpio_disable() are static functions, it does
> not make sense to export them.
>
> Signed-off-by: Axel Lin <[email protected]>

Applied with Stephen's ACK.

Yours,
Linus Walleij