Commit 1d05334d2899 ("livepatch: Remove .klp.arch") removed
arch/x86/kernel/livepatch.c, but missed to adjust the LIVE PATCHING entry
in MAINTAINERS.
Since then, ./scripts/get_maintainer.pl --self-test=patterns complains:
warning: no file matches F: arch/x86/kernel/livepatch.c
So, drop that obsolete file entry in MAINTAINERS.
Signed-off-by: Lukas Bulwahn <[email protected]>
---
Jiri, please take this minor non-urgent patch for livepatching/for-next.
Peter, please ack.
applies cleanly on next-20200508
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 92657a132417..642f55c4b556 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9909,7 +9909,6 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching.g
F: Documentation/ABI/testing/sysfs-kernel-livepatch
F: Documentation/livepatch/
F: arch/x86/include/asm/livepatch.h
-F: arch/x86/kernel/livepatch.c
F: include/linux/livepatch.h
F: kernel/livepatch/
F: samples/livepatch/
--
2.17.1
On 5/9/20 1:02 PM, Lukas Bulwahn wrote:
> Commit 1d05334d2899 ("livepatch: Remove .klp.arch") removed
> arch/x86/kernel/livepatch.c, but missed to adjust the LIVE PATCHING entry
> in MAINTAINERS.
>
> Since then, ./scripts/get_maintainer.pl --self-test=patterns complains:
>
> warning: no file matches F: arch/x86/kernel/livepatch.c
>
> So, drop that obsolete file entry in MAINTAINERS.
Patch looks good to me, you probably want to add following architecture
specific livepatching header files to the list:
arch/s390/include/asm/livepatch.h
arch/powerpc/include/asm/livepatch.h
>
> Signed-off-by: Lukas Bulwahn <[email protected]>
> ---
> Jiri, please take this minor non-urgent patch for livepatching/for-next.
> Peter, please ack.
>
> applies cleanly on next-20200508
>
> MAINTAINERS | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 92657a132417..642f55c4b556 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -9909,7 +9909,6 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching.g
> F: Documentation/ABI/testing/sysfs-kernel-livepatch
> F: Documentation/livepatch/
> F: arch/x86/include/asm/livepatch.h
> -F: arch/x86/kernel/livepatch.c
> F: include/linux/livepatch.h
> F: kernel/livepatch/
> F: samples/livepatch/
>
--
Kamalesh
On Sat, 9 May 2020, Lukas Bulwahn wrote:
> Commit 1d05334d2899 ("livepatch: Remove .klp.arch") removed
> arch/x86/kernel/livepatch.c, but missed to adjust the LIVE PATCHING entry
> in MAINTAINERS.
>
> Since then, ./scripts/get_maintainer.pl --self-test=patterns complains:
>
> warning: no file matches F: arch/x86/kernel/livepatch.c
>
> So, drop that obsolete file entry in MAINTAINERS.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>
I've added
Fixes: 1d05334d2899 ("livepatch: Remove .klp.arch")
and applied, thanks.
--
Jiri Kosina
SUSE Labs
On Sat, 9 May 2020, Kamalesh Babulal wrote:
> > Commit 1d05334d2899 ("livepatch: Remove .klp.arch") removed
> > arch/x86/kernel/livepatch.c, but missed to adjust the LIVE PATCHING entry
> > in MAINTAINERS.
> >
> > Since then, ./scripts/get_maintainer.pl --self-test=patterns complains:
> >
> > warning: no file matches F: arch/x86/kernel/livepatch.c
> >
> > So, drop that obsolete file entry in MAINTAINERS.
>
> Patch looks good to me, you probably want to add following architecture
> specific livepatching header files to the list:
>
> arch/s390/include/asm/livepatch.h
> arch/powerpc/include/asm/livepatch.h
Good point, thanks for spotting it Kamalesh. I've queued the patch below
on top.
From: Jiri Kosina <[email protected]>
Subject: [PATCH] livepatch: add arch-specific headers to MAINTAINERS
Add arch-specific livepatch.h for s390 and powerpc to MAINTAINERS
F: patterns.
Reported-by: Kamalesh Babulal <[email protected]>
Signed-off-by: Jiri Kosina <[email protected]>
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 7e0827670425..8e14444eb98d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9854,6 +9854,8 @@ S: Maintained
T: git git://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching.git
F: Documentation/ABI/testing/sysfs-kernel-livepatch
F: Documentation/livepatch/
+F: arch/powerpc/include/asm/livepatch.h
+F: arch/s390/include/asm/livepatch.h
F: arch/x86/include/asm/livepatch.h
F: include/linux/livepatch.h
F: kernel/livepatch/
--
Jiri Kosina
SUSE Labs
On 5/15/20 3:15 AM, Jiri Kosina wrote:
> On Sat, 9 May 2020, Kamalesh Babulal wrote:
>
>>> Commit 1d05334d2899 ("livepatch: Remove .klp.arch") removed
>>> arch/x86/kernel/livepatch.c, but missed to adjust the LIVE PATCHING entry
>>> in MAINTAINERS.
>>>
>>> Since then, ./scripts/get_maintainer.pl --self-test=patterns complains:
>>>
>>> warning: no file matches F: arch/x86/kernel/livepatch.c
>>>
>>> So, drop that obsolete file entry in MAINTAINERS.
>>
>> Patch looks good to me, you probably want to add following architecture
>> specific livepatching header files to the list:
>>
>> arch/s390/include/asm/livepatch.h
>> arch/powerpc/include/asm/livepatch.h
>
> Good point, thanks for spotting it Kamalesh. I've queued the patch below
> on top.
>
>
Thanks, Jiri. I realized later, that the lib/livepatch directory also needs
to be included in the list of files maintained under livepatch. Earlier, this
week I had sent a patch to the mailing list that includes both arch
headers and lib/livepatch to the list of files, the link to the patch is:
https://lore.kernel.org/live-patching/[email protected]/
--
Kamalesh
On Fri, 15 May 2020, Kamalesh Babulal wrote:
> Thanks, Jiri. I realized later, that the lib/livepatch directory also
> needs to be included in the list of files maintained under livepatch.
> Earlier, this week I had sent a patch to the mailing list that includes
> both arch headers and lib/livepatch to the list of files, the link to
> the patch is:
>
> https://lore.kernel.org/live-patching/[email protected]/
Ah, I wasn't CCed, so it fell in between cracks, sorry. Could you please
resend the lib/livepatch part separately? I'll apply it on top.
Thanks,
--
Jiri Kosina
SUSE Labs