2012-11-13 01:53:39

by Shan Wei

Subject: [PATCH v4 9/9] net: batman-adv: use per_cpu_add helper

From: Shan Wei <[email protected]>

this_cpu_add is an atomic operation.
and be more faster than per_cpu_ptr operation.

Signed-off-by: Shan Wei <[email protected]>
Reviewed-by: Christoph Lameter <[email protected]>
---
v4: no changes vs v3.
---
net/batman-adv/main.h | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h
index 897ba6a..3aef5b2 100644
--- a/net/batman-adv/main.h
+++ b/net/batman-adv/main.h
@@ -263,9 +263,7 @@ static inline bool batadv_has_timed_out(unsigned long timestamp,
static inline void batadv_add_counter(struct batadv_priv *bat_priv, size_t idx,
size_t count)
{
- int cpu = get_cpu();
- per_cpu_ptr(bat_priv->bat_counters, cpu)[idx] += count;
- put_cpu();
+ this_cpu_add(bat_priv->bat_counters[idx], count);
}

#define batadv_inc_counter(b, i) batadv_add_counter(b, i, 1)
--
1.7.1

2012-11-13 09:55:23

by Marek Lindner

Subject: Re: [B.A.T.M.A.N.] [PATCH v4 9/9] net: batman-adv: use per_cpu_add helper

On Tuesday, November 13, 2012 09:53:26 Shan Wei wrote:
> From: Shan Wei <[email protected]>
>
> this_cpu_add is an atomic operation.
> and be more faster than per_cpu_ptr operation.
>
> Signed-off-by: Shan Wei <[email protected]>
> Reviewed-by: Christoph Lameter <[email protected]>
> ---
> v4: no changes vs v3.
> ---
> net/batman-adv/main.h | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)

Applied in our tree (revision f8b19e1). We will pass along this patch through
our standard workflow. No need to resend this patch in the future.

Thanks,
Marek

2012-11-13 10:25:47

by Shan Wei

Subject: Re: [B.A.T.M.A.N.] [PATCH v4 9/9] net: batman-adv: use per_cpu_add helper

Marek Lindner said, at 2012/11/13 17:55:
>> net/batman-adv/main.h | 4 +---
>> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> Applied in our tree (revision f8b19e1). We will pass along this patch through
> our standard workflow. No need to resend this patch in the future.

OK thanks~

>
> Thanks,
> Marek
>