2012-10-20 10:09:40

by Marco Stornelli

Subject: [PATCH] hostfs: fix a not needed double check

With the commit 3be2be0a32c18b0fd6d623cda63174a332ca0de1 we removed vmtruncate,
but actaully there is no need to call inode_newsize_ok() because the checks are
already done in inode_change_ok() at the begin of the function.

Signed-off-by: Marco Stornelli <[email protected]>
---
fs/hostfs/hostfs_kern.c | 9 +--------
1 files changed, 1 insertions(+), 8 deletions(-)

diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c
index 457addc..c9d5254 100644
--- a/fs/hostfs/hostfs_kern.c
+++ b/fs/hostfs/hostfs_kern.c
@@ -845,15 +845,8 @@ int hostfs_setattr(struct dentry *dentry, struct iattr *attr)
return err;

if ((attr->ia_valid & ATTR_SIZE) &&
- attr->ia_size != i_size_read(inode)) {
- int error;
-
- error = inode_newsize_ok(inode, attr->ia_size);
- if (error)
- return error;
-
+ attr->ia_size != i_size_read(inode))
truncate_setsize(inode, attr->ia_size);
- }

setattr_copy(inode, attr);
mark_inode_dirty(inode);
--
1.7.3.4

2012-11-18 09:06:27

by Marco Stornelli

Subject: Re: [PATCH] hostfs: fix a not needed double check

Il 20/10/2012 12:02, Marco Stornelli ha scritto:
> With the commit 3be2be0a32c18b0fd6d623cda63174a332ca0de1 we removed vmtruncate,
> but actaully there is no need to call inode_newsize_ok() because the checks are
> already done in inode_change_ok() at the begin of the function.
>
> Signed-off-by: Marco Stornelli <[email protected]>
> ---
> fs/hostfs/hostfs_kern.c | 9 +--------
> 1 files changed, 1 insertions(+), 8 deletions(-)
>
> diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c
> index 457addc..c9d5254 100644
> --- a/fs/hostfs/hostfs_kern.c
> +++ b/fs/hostfs/hostfs_kern.c
> @@ -845,15 +845,8 @@ int hostfs_setattr(struct dentry *dentry, struct iattr *attr)
> return err;
>
> if ((attr->ia_valid & ATTR_SIZE) &&
> - attr->ia_size != i_size_read(inode)) {
> - int error;
> -
> - error = inode_newsize_ok(inode, attr->ia_size);
> - if (error)
> - return error;
> -
> + attr->ia_size != i_size_read(inode))
> truncate_setsize(inode, attr->ia_size);
> - }
>
> setattr_copy(inode, attr);
> mark_inode_dirty(inode);
>

Any feedback for this patch?

Marco

2012-11-24 09:09:21

by Marco Stornelli

Subject: Re: [PATCH] hostfs: fix a not needed double check

Il 18/11/2012 09:59, Marco Stornelli ha scritto:
> Il 20/10/2012 12:02, Marco Stornelli ha scritto:
>> With the commit 3be2be0a32c18b0fd6d623cda63174a332ca0de1 we removed
>> vmtruncate,
>> but actaully there is no need to call inode_newsize_ok() because the
>> checks are
>> already done in inode_change_ok() at the begin of the function.
>>
>> Signed-off-by: Marco Stornelli <[email protected]>

I didn't receive any feedback from Weinberger, could you consider this
patch for next -rc?

Thanks.

Marco

2012-11-24 09:12:32

by Richard Weinberger

Subject: Re: [PATCH] hostfs: fix a not needed double check

Am Sat, 24 Nov 2012 10:02:32 +0100
schrieb Marco Stornelli <[email protected]>:

> Il 18/11/2012 09:59, Marco Stornelli ha scritto:
> > Il 20/10/2012 12:02, Marco Stornelli ha scritto:
> >> With the commit 3be2be0a32c18b0fd6d623cda63174a332ca0de1 we removed
> >> vmtruncate,
> >> but actaully there is no need to call inode_newsize_ok() because
> >> the checks are
> >> already done in inode_change_ok() at the begin of the function.
> >>
> >> Signed-off-by: Marco Stornelli <[email protected]>
>
> I didn't receive any feedback from Weinberger, could you consider
> this patch for next -rc?

Whoops. Sorry. -ENOMAL.

I can carry this patch through uml.git

Thanks,
//richard

2012-11-24 09:15:38

by Marco Stornelli

Subject: Re: [PATCH] hostfs: fix a not needed double check

Il 24/11/2012 10:12, Richard Weinberger ha scritto:
> Am Sat, 24 Nov 2012 10:02:32 +0100
> schrieb Marco Stornelli <[email protected]>:
>
>> Il 18/11/2012 09:59, Marco Stornelli ha scritto:
>>> Il 20/10/2012 12:02, Marco Stornelli ha scritto:
>>>> With the commit 3be2be0a32c18b0fd6d623cda63174a332ca0de1 we removed
>>>> vmtruncate,
>>>> but actaully there is no need to call inode_newsize_ok() because
>>>> the checks are
>>>> already done in inode_change_ok() at the begin of the function.
>>>>
>>>> Signed-off-by: Marco Stornelli <[email protected]>
>>
>> I didn't receive any feedback from Weinberger, could you consider
>> this patch for next -rc?
>
> Whoops. Sorry. -ENOMAL.
>
> I can carry this patch through uml.git
>
> Thanks,
> //richard
>

No problem, thanks :)

Marco