On Fri, Sep 26, 2014 at 7:07 PM, Chang Rebecca Swee Fun
<[email protected]> wrote:
> Hi,
>
> This is a revised version for gpio-sch.
>
> Change log for V2:
> Patch 1:
> - Move sch_gpio_get() and sch_gpio_set() to avoid forward declaration.
> - Changed sch_gpio_enable()/sch_gpio_disable() to sch_gpio_register_set()/
> sch_gpio_register_clear().
>
> Patch 3:
> - Changed all sch_gpio_enable()/sch_gpio_disable() to sch_gpio_register_set()/
> sch_gpio_register_clear().
>
> Version 1:
> This patch series is about enabling legacy GPIO support for Quark X1000.
> The patches were developed on top of Mika Westerberg's commit on
> consolidating core and resume banks. Please refer to the link below for
> more information about his commit.
> https://lkml.org/lkml/2014/8/17/13
Sorry for the late review. I tried to apply the patch you mentioned
above before your series, and even Mika's patch won't apply on Linus'
devel branch or today's -next. This make it difficult to make a good
review. Could you rebase and resend this series once all its
dependencies have been merge by Linus W. ?
> -----Original Message-----
> From: Alexandre Courbot [mailto:[email protected]]
> Sent: 09 October, 2014 2:29 PM
> To: Chang, Rebecca Swee Fun
> Cc: Linus Walleij; Westerberg, Mika; GPIO Subsystem Mailing List; Linux Kernel
> Mailing List
> Subject: Re: [PATCHv2 0/3] Enable Quark X1000 support in gpio-sch
>
> On Fri, Sep 26, 2014 at 7:07 PM, Chang Rebecca Swee Fun
> <[email protected]> wrote:
> > Hi,
> >
> > This is a revised version for gpio-sch.
> >
> > Change log for V2:
> > Patch 1:
> > - Move sch_gpio_get() and sch_gpio_set() to avoid forward declaration.
> > - Changed sch_gpio_enable()/sch_gpio_disable() to sch_gpio_register_set()/
> > sch_gpio_register_clear().
> >
> > Patch 3:
> > - Changed all sch_gpio_enable()/sch_gpio_disable() to
> sch_gpio_register_set()/
> > sch_gpio_register_clear().
> >
> > Version 1:
> > This patch series is about enabling legacy GPIO support for Quark X1000.
> > The patches were developed on top of Mika Westerberg's commit on
> > consolidating core and resume banks. Please refer to the link below
> > for more information about his commit.
> > https://lkml.org/lkml/2014/8/17/13
>
> Sorry for the late review. I tried to apply the patch you mentioned above before
> your series, and even Mika's patch won't apply on Linus'
> devel branch or today's -next. This make it difficult to make a good review.
> Could you rebase and resend this series once all its dependencies have been
> merge by Linus W. ?
Hi, I've noticed that Mika had sent a V2series on his work. Referring to his submission in: https://lkml.org/lkml/2014/9/16/213, this patch was able to patch on today's kernel tree. The patches on my series are able to patch in too. Do I need to resend since there is no changes on my side?
Rebecca
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay? ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?
On Mon, Oct 13, 2014 at 12:41 PM, Chang, Rebecca Swee Fun
<[email protected]> wrote:
>
>
>> -----Original Message-----
>> From: Alexandre Courbot [mailto:[email protected]]
>> Sent: 09 October, 2014 2:29 PM
>> To: Chang, Rebecca Swee Fun
>> Cc: Linus Walleij; Westerberg, Mika; GPIO Subsystem Mailing List; Linux Kernel
>> Mailing List
>> Subject: Re: [PATCHv2 0/3] Enable Quark X1000 support in gpio-sch
>>
>> On Fri, Sep 26, 2014 at 7:07 PM, Chang Rebecca Swee Fun
>> <[email protected]> wrote:
>> > Hi,
>> >
>> > This is a revised version for gpio-sch.
>> >
>> > Change log for V2:
>> > Patch 1:
>> > - Move sch_gpio_get() and sch_gpio_set() to avoid forward declaration.
>> > - Changed sch_gpio_enable()/sch_gpio_disable() to sch_gpio_register_set()/
>> > sch_gpio_register_clear().
>> >
>> > Patch 3:
>> > - Changed all sch_gpio_enable()/sch_gpio_disable() to
>> sch_gpio_register_set()/
>> > sch_gpio_register_clear().
>> >
>> > Version 1:
>> > This patch series is about enabling legacy GPIO support for Quark X1000.
>> > The patches were developed on top of Mika Westerberg's commit on
>> > consolidating core and resume banks. Please refer to the link below
>> > for more information about his commit.
>> > https://lkml.org/lkml/2014/8/17/13
>>
>> Sorry for the late review. I tried to apply the patch you mentioned above before
>> your series, and even Mika's patch won't apply on Linus'
>> devel branch or today's -next. This make it difficult to make a good review.
>> Could you rebase and resend this series once all its dependencies have been
>> merge by Linus W. ?
>
> Hi, I've noticed that Mika had sent a V2series on his work. Referring to his submission in: https://lkml.org/lkml/2014/9/16/213, this patch was able to patch on today's kernel tree. The patches on my series are able to patch in too. Do I need to resend since there is no changes on my side?
I got your v3 applied on top of Linus' devel tree and Mika's patch
without any issue. Thanks.