2012-11-22 20:31:27

by Joe Perches

Subject: [TRIVIAL PATCH] bdi_register: Add __printf verification, fix arg mismatch

__printf is useful to verify format and arguments.

Signed-off-by: Joe Perches <[email protected]>
---
fs/ceph/super.c | 2 +-
include/linux/backing-dev.h | 1 +
2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/fs/ceph/super.c b/fs/ceph/super.c
index 2eb43f2..e7dbb5c 100644
--- a/fs/ceph/super.c
+++ b/fs/ceph/super.c
@@ -849,7 +849,7 @@ static int ceph_register_bdi(struct super_block *sb,
fsc->backing_dev_info.ra_pages =
default_backing_dev_info.ra_pages;

- err = bdi_register(&fsc->backing_dev_info, NULL, "ceph-%d",
+ err = bdi_register(&fsc->backing_dev_info, NULL, "ceph-%ld",
atomic_long_inc_return(&bdi_seq));
if (!err)
sb->s_bdi = &fsc->backing_dev_info;
diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
index 2a9a9ab..12731a1 100644
--- a/include/linux/backing-dev.h
+++ b/include/linux/backing-dev.h
@@ -114,6 +114,7 @@ struct backing_dev_info {
int bdi_init(struct backing_dev_info *bdi);
void bdi_destroy(struct backing_dev_info *bdi);

+__printf(3, 4)
int bdi_register(struct backing_dev_info *bdi, struct device *parent,
const char *fmt, ...);
int bdi_register_dev(struct backing_dev_info *bdi, dev_t dev);

2012-11-27 03:05:34

by Alex Elder

Subject: Re: [TRIVIAL PATCH] bdi_register: Add __printf verification, fix arg mismatch

On 11/22/2012 01:49 PM, Joe Perches wrote:
> __printf is useful to verify format and arguments.
>
> Signed-off-by: Joe Perches <[email protected]>

Looks good. I can take this into the ceph tree. Thanks.

Reviewed-by: Alex Elder <[email protected]>

> ---
> fs/ceph/super.c | 2 +-
> include/linux/backing-dev.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ceph/super.c b/fs/ceph/super.c
> index 2eb43f2..e7dbb5c 100644
> --- a/fs/ceph/super.c
> +++ b/fs/ceph/super.c
> @@ -849,7 +849,7 @@ static int ceph_register_bdi(struct super_block *sb,
> fsc->backing_dev_info.ra_pages =
> default_backing_dev_info.ra_pages;
>
> - err = bdi_register(&fsc->backing_dev_info, NULL, "ceph-%d",
> + err = bdi_register(&fsc->backing_dev_info, NULL, "ceph-%ld",
> atomic_long_inc_return(&bdi_seq));
> if (!err)
> sb->s_bdi = &fsc->backing_dev_info;
> diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
> index 2a9a9ab..12731a1 100644
> --- a/include/linux/backing-dev.h
> +++ b/include/linux/backing-dev.h
> @@ -114,6 +114,7 @@ struct backing_dev_info {
> int bdi_init(struct backing_dev_info *bdi);
> void bdi_destroy(struct backing_dev_info *bdi);
>
> +__printf(3, 4)
> int bdi_register(struct backing_dev_info *bdi, struct device *parent,
> const char *fmt, ...);
> int bdi_register_dev(struct backing_dev_info *bdi, dev_t dev);
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>