2019-03-29 01:47:54

by Axel Lin

Subject: [PATCH] regulator: vctrl: Remove unneeded continue statement

Signed-off-by: Axel Lin <[email protected]>
---
drivers/regulator/vctrl-regulator.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/regulator/vctrl-regulator.c b/drivers/regulator/vctrl-regulator.c
index 78de002037c7..259864520a06 100644
--- a/drivers/regulator/vctrl-regulator.c
+++ b/drivers/regulator/vctrl-regulator.c
@@ -334,10 +334,8 @@ static int vctrl_init_vtable(struct platform_device *pdev)
ctrl_uV = regulator_list_voltage(ctrl_reg, i);

if (ctrl_uV < vrange_ctrl->min_uV ||
- ctrl_uV > vrange_ctrl->max_uV) {
+ ctrl_uV > vrange_ctrl->max_uV)
rdesc->n_voltages--;
- continue;
- }
}

if (rdesc->n_voltages == 0) {
--
2.17.1

2019-03-29 10:53:14

by Mukesh Ojha

Subject: Re: [PATCH] regulator: vctrl: Remove unneeded continue statement

On 3/29/2019 7:16 AM, Axel Lin wrote:
> Signed-off-by: Axel Lin <[email protected]>


Yeah indeed! but where is commit text atleast a one-liner.

Otherwise looks good to me.
Reviewed-by: Mukesh Ojha <[email protected]>

Cheers,
-Mukesh


> ---
> drivers/regulator/vctrl-regulator.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/regulator/vctrl-regulator.c b/drivers/regulator/vctrl-regulator.c
> index 78de002037c7..259864520a06 100644
> --- a/drivers/regulator/vctrl-regulator.c
> +++ b/drivers/regulator/vctrl-regulator.c
> @@ -334,10 +334,8 @@ static int vctrl_init_vtable(struct platform_device *pdev)
> ctrl_uV = regulator_list_voltage(ctrl_reg, i);
>
> if (ctrl_uV < vrange_ctrl->min_uV ||
> - ctrl_uV > vrange_ctrl->max_uV) {
> + ctrl_uV > vrange_ctrl->max_uV)
> rdesc->n_voltages--;
> - continue;
> - }
> }
>
> if (rdesc->n_voltages == 0) {

2019-03-29 18:35:56

by Matthias Kaehlcke

Subject: Re: [PATCH] regulator: vctrl: Remove unneeded continue statement

Hi Axel,

On Fri, Mar 29, 2019 at 09:46:31AM +0800, Axel Lin wrote:

As Mukesh already mentioned, there should be a short description.

> Signed-off-by: Axel Lin <[email protected]>
> ---
> drivers/regulator/vctrl-regulator.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/regulator/vctrl-regulator.c b/drivers/regulator/vctrl-regulator.c
> index 78de002037c7..259864520a06 100644
> --- a/drivers/regulator/vctrl-regulator.c
> +++ b/drivers/regulator/vctrl-regulator.c
> @@ -334,10 +334,8 @@ static int vctrl_init_vtable(struct platform_device *pdev)
> ctrl_uV = regulator_list_voltage(ctrl_reg, i);
>
> if (ctrl_uV < vrange_ctrl->min_uV ||
> - ctrl_uV > vrange_ctrl->max_uV) {
> + ctrl_uV > vrange_ctrl->max_uV)
> rdesc->n_voltages--;
> - continue;
> - }

indeed, the 'continue' is pointless here. I guess at some stage of
development something else was done in the loop and this is a
leftover.

Reviewed-by: Matthias Kaehlcke <[email protected]>