2022-09-02 04:08:17

by Tiezhu Yang

[permalink] [raw]
Subject: [PATCH] entry: Remove has_signal comment of arch_do_signal_or_restart() prototype

The argument has_signal of arch_do_signal_or_restart() has been removed
in commit 8ba62d37949e ("task_work: Call tracehook_notify_signal from
get_signal on all architectures"), let us remove the related comment.

Signed-off-by: Tiezhu Yang <[email protected]>
---
include/linux/entry-common.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/include/linux/entry-common.h b/include/linux/entry-common.h
index 84a466b..d95ab85 100644
--- a/include/linux/entry-common.h
+++ b/include/linux/entry-common.h
@@ -253,7 +253,6 @@ static __always_inline void arch_exit_to_user_mode(void) { }
/**
* arch_do_signal_or_restart - Architecture specific signal delivery function
* @regs: Pointer to currents pt_regs
- * @has_signal: actual signal to handle
*
* Invoked from exit_to_user_mode_loop().
*/
--
2.1.0


2022-09-02 23:28:16

by Kees Cook

[permalink] [raw]
Subject: Re: [PATCH] entry: Remove has_signal comment of arch_do_signal_or_restart() prototype

On Fri, Sep 02, 2022 at 11:41:46AM +0800, Tiezhu Yang wrote:
> The argument has_signal of arch_do_signal_or_restart() has been removed
> in commit 8ba62d37949e ("task_work: Call tracehook_notify_signal from
> get_signal on all architectures"), let us remove the related comment.
>
> Signed-off-by: Tiezhu Yang <[email protected]>

Fixes: 8ba62d37949e ("task_work: Call tracehook_notify_signal from get_signal on all architectures")
Reviewed-by: Kees Cook <[email protected]>

--
Kees Cook

2022-09-29 10:15:30

by Tiezhu Yang

[permalink] [raw]
Subject: Re: [PATCH] entry: Remove has_signal comment of arch_do_signal_or_restart() prototype



On 09/03/2022 07:10 AM, Kees Cook wrote:
> On Fri, Sep 02, 2022 at 11:41:46AM +0800, Tiezhu Yang wrote:
>> The argument has_signal of arch_do_signal_or_restart() has been removed
>> in commit 8ba62d37949e ("task_work: Call tracehook_notify_signal from
>> get_signal on all architectures"), let us remove the related comment.
>>
>> Signed-off-by: Tiezhu Yang <[email protected]>
>
> Fixes: 8ba62d37949e ("task_work: Call tracehook_notify_signal from get_signal on all architectures")
> Reviewed-by: Kees Cook <[email protected]>
>

Hi all,

Do you know which tree this patch will go through?

Thanks,
Tiezhu

2022-10-08 03:52:49

by Tiezhu Yang

[permalink] [raw]
Subject: Re: [PATCH] entry: Remove has_signal comment of arch_do_signal_or_restart() prototype



On 09/29/2022 05:58 PM, Tiezhu Yang wrote:
>
>
> On 09/03/2022 07:10 AM, Kees Cook wrote:
>> On Fri, Sep 02, 2022 at 11:41:46AM +0800, Tiezhu Yang wrote:
>>> The argument has_signal of arch_do_signal_or_restart() has been removed
>>> in commit 8ba62d37949e ("task_work: Call tracehook_notify_signal from
>>> get_signal on all architectures"), let us remove the related comment.
>>>
>>> Signed-off-by: Tiezhu Yang <[email protected]>
>>
>> Fixes: 8ba62d37949e ("task_work: Call tracehook_notify_signal from
>> get_signal on all architectures")
>> Reviewed-by: Kees Cook <[email protected]>
>>
>
> Hi all,
>
> Do you know which tree this patch will go through?
>
> Thanks,
> Tiezhu

Hi Andrew,

Could you please pick it up via your tree in this merge window?

https://lore.kernel.org/lkml/[email protected]/

Thanks,
Tiezhu