The accept_untracked_na sysctl changed from a boolean to an integer
when a new knob '2' was added. This patch provides a safeguard to avoid
accepting values that are not defined in the sysctl. When setting a
value greater than 2, the user will get an 'invalid argument' warning.
Signed-off-by: Jaehee Park <[email protected]>
Suggested-by: Nicolas Dichtel <[email protected]>
Suggested-by: Roopa Prabhu <[email protected]>
---
v2
- got rid of unnecessary void cast in extra1 and extra2
net/ipv6/addrconf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 6ed807b6c647..b624e3d8c5f0 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -7042,9 +7042,9 @@ static const struct ctl_table addrconf_sysctl[] = {
.data = &ipv6_devconf.accept_untracked_na,
.maxlen = sizeof(int),
.mode = 0644,
- .proc_handler = proc_dointvec,
- .extra1 = (void *)SYSCTL_ZERO,
- .extra2 = (void *)SYSCTL_ONE,
+ .proc_handler = proc_dointvec_minmax,
+ .extra1 = SYSCTL_ZERO,
+ .extra2 = SYSCTL_TWO,
},
{
/* sentinel */
--
2.30.2
Le 20/07/2022 à 20:36, Jaehee Park a écrit :
> The accept_untracked_na sysctl changed from a boolean to an integer
> when a new knob '2' was added. This patch provides a safeguard to avoid
> accepting values that are not defined in the sysctl. When setting a
> value greater than 2, the user will get an 'invalid argument' warning.
>
> Signed-off-by: Jaehee Park <[email protected]>
> Suggested-by: Nicolas Dichtel <[email protected]>
> Suggested-by: Roopa Prabhu <[email protected]>
Reviewed-by: Nicolas Dichtel <[email protected]>
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:
On Wed, 20 Jul 2022 14:36:32 -0400 you wrote:
> The accept_untracked_na sysctl changed from a boolean to an integer
> when a new knob '2' was added. This patch provides a safeguard to avoid
> accepting values that are not defined in the sysctl. When setting a
> value greater than 2, the user will get an 'invalid argument' warning.
>
> Signed-off-by: Jaehee Park <[email protected]>
> Suggested-by: Nicolas Dichtel <[email protected]>
> Suggested-by: Roopa Prabhu <[email protected]>
>
> [...]
Here is the summary with links:
- [v2,net-next] net: ipv6: avoid accepting values greater than 2 for accept_untracked_na
https://git.kernel.org/netdev/net-next/c/b66eb3a6e427
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html