2013-03-02 07:31:08

by Mark Brown

Subject: [PATCH] mfd: twl4030-audio: Fix argument type for twl4030_audio_disable_resource()

Looks like the conversion to enum was missed for the definition of this
function, the declaration has been updated.

Signed-off-by: Mark Brown <[email protected]>
---
drivers/mfd/twl4030-audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/twl4030-audio.c b/drivers/mfd/twl4030-audio.c
index e16edca..d2ab222 100644
--- a/drivers/mfd/twl4030-audio.c
+++ b/drivers/mfd/twl4030-audio.c
@@ -118,7 +118,7 @@ EXPORT_SYMBOL_GPL(twl4030_audio_enable_resource);
* Disable the resource.
* The function returns with error or the content of the register
*/
-int twl4030_audio_disable_resource(unsigned id)
+int twl4030_audio_disable_resource(enum twl4030_audio_res id)
{
struct twl4030_audio *audio = platform_get_drvdata(twl4030_audio_dev);
int val;
--
1.7.10.4

2013-03-02 14:52:25

by Peter Ujfalusi

Subject: Re: [PATCH] mfd: twl4030-audio: Fix argument type for twl4030_audio_disable_resource()

On 03/02/2013 08:30 AM, Mark Brown wrote:
> Looks like the conversion to enum was missed for the definition of this
> function, the declaration has been updated.

Acked-by: Peter Ujfalusi <[email protected]>

>
> Signed-off-by: Mark Brown <[email protected]>
> ---
> drivers/mfd/twl4030-audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/twl4030-audio.c b/drivers/mfd/twl4030-audio.c
> index e16edca..d2ab222 100644
> --- a/drivers/mfd/twl4030-audio.c
> +++ b/drivers/mfd/twl4030-audio.c
> @@ -118,7 +118,7 @@ EXPORT_SYMBOL_GPL(twl4030_audio_enable_resource);
> * Disable the resource.
> * The function returns with error or the content of the register
> */
> -int twl4030_audio_disable_resource(unsigned id)
> +int twl4030_audio_disable_resource(enum twl4030_audio_res id)
> {
> struct twl4030_audio *audio = platform_get_drvdata(twl4030_audio_dev);
> int val;
>


--
P?ter

2013-03-13 08:38:51

by Samuel Ortiz

Subject: Re: [PATCH] mfd: twl4030-audio: Fix argument type for twl4030_audio_disable_resource()

On Sat, Mar 02, 2013 at 03:30:35PM +0800, Mark Brown wrote:
> Looks like the conversion to enum was missed for the definition of this
> function, the declaration has been updated.
>
> Signed-off-by: Mark Brown <[email protected]>
> ---
> drivers/mfd/twl4030-audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to my mfd-fixes tree, thanks.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/