2013-03-04 08:56:57

by Jingoo Han

Subject: [PATCH] backlight: ep93xx_bl: remove incorrect __exit annotation

When platform_driver_probe() is not used, bind/unbind via sysfs is
enabled. Thus, __init/__exit annotations should be removed from
probe()/remove().

Signed-off-by: Jingoo Han <[email protected]>
---
drivers/video/backlight/ep93xx_bl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/backlight/ep93xx_bl.c b/drivers/video/backlight/ep93xx_bl.c
index ef3e21e..fd073b2 100644
--- a/drivers/video/backlight/ep93xx_bl.c
+++ b/drivers/video/backlight/ep93xx_bl.c
@@ -60,7 +60,7 @@ static const struct backlight_ops ep93xxbl_ops = {
.get_brightness = ep93xxbl_get_brightness,
};

-static int __init ep93xxbl_probe(struct platform_device *dev)
+static int ep93xxbl_probe(struct platform_device *dev)
{
struct ep93xxbl *ep93xxbl;
struct backlight_device *bl;
--
1.7.2.5

2013-03-04 08:59:35

by Jingoo Han

Subject: Re: [PATCH] backlight: ep93xx_bl: remove incorrect __exit annotation

On Monday, March 04, 2013 5:57 PM, Jingoo Han wrote:
> Subject: [PATCH] backlight: ep93xx_bl: remove incorrect __exit annotation

Sorry, subject is wrong.
__exit should be __init.

I will send the v2 patch, soon.

>
> When platform_driver_probe() is not used, bind/unbind via sysfs is
> enabled. Thus, __init/__exit annotations should be removed from
> probe()/remove().
>
> Signed-off-by: Jingoo Han <[email protected]>
> ---
> drivers/video/backlight/ep93xx_bl.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/backlight/ep93xx_bl.c b/drivers/video/backlight/ep93xx_bl.c
> index ef3e21e..fd073b2 100644
> --- a/drivers/video/backlight/ep93xx_bl.c
> +++ b/drivers/video/backlight/ep93xx_bl.c
> @@ -60,7 +60,7 @@ static const struct backlight_ops ep93xxbl_ops = {
> .get_brightness = ep93xxbl_get_brightness,
> };
>
> -static int __init ep93xxbl_probe(struct platform_device *dev)
> +static int ep93xxbl_probe(struct platform_device *dev)
> {
> struct ep93xxbl *ep93xxbl;
> struct backlight_device *bl;
> --
> 1.7.2.5

2013-03-04 09:02:24

by Jingoo Han

Subject: [PATCH V2] backlight: ep93xx_bl: remove incorrect __init annotation

When platform_driver_probe() is not used, bind/unbind via sysfs is
enabled. Thus, __init/__exit annotations should be removed from
probe()/remove().

Signed-off-by: Jingoo Han <[email protected]>
---
Changes since v1:
- Fix typo of the subject: __exit --> __init

drivers/video/backlight/ep93xx_bl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/backlight/ep93xx_bl.c b/drivers/video/backlight/ep93xx_bl.c
index ef3e21e..fd073b2 100644
--- a/drivers/video/backlight/ep93xx_bl.c
+++ b/drivers/video/backlight/ep93xx_bl.c
@@ -60,7 +60,7 @@ static const struct backlight_ops ep93xxbl_ops = {
.get_brightness = ep93xxbl_get_brightness,
};

-static int __init ep93xxbl_probe(struct platform_device *dev)
+static int ep93xxbl_probe(struct platform_device *dev)
{
struct ep93xxbl *ep93xxbl;
struct backlight_device *bl;
--
1.7.2.5

2013-03-05 22:42:01

by Ryan Mallon

Subject: Re: [PATCH V2] backlight: ep93xx_bl: remove incorrect __init annotation

On 04/03/13 20:02, Jingoo Han wrote:
> When platform_driver_probe() is not used, bind/unbind via sysfs is
> enabled. Thus, __init/__exit annotations should be removed from
> probe()/remove().
>
> Signed-off-by: Jingoo Han <[email protected]>

Acked-by: Ryan Mallon <[email protected]>

> ---
> Changes since v1:
> - Fix typo of the subject: __exit --> __init
>
> drivers/video/backlight/ep93xx_bl.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/backlight/ep93xx_bl.c b/drivers/video/backlight/ep93xx_bl.c
> index ef3e21e..fd073b2 100644
> --- a/drivers/video/backlight/ep93xx_bl.c
> +++ b/drivers/video/backlight/ep93xx_bl.c
> @@ -60,7 +60,7 @@ static const struct backlight_ops ep93xxbl_ops = {
> .get_brightness = ep93xxbl_get_brightness,
> };
>
> -static int __init ep93xxbl_probe(struct platform_device *dev)
> +static int ep93xxbl_probe(struct platform_device *dev)
> {
> struct ep93xxbl *ep93xxbl;
> struct backlight_device *bl;
>