2013-03-05 17:30:53

by Paul Bolle

Subject: [PATCH] m68k: drop "select EMAC_INC"

Somehow this select statement managed to squeeze itself between commit
0e152d80507b75c00aac60f2ffc586360687cd52 ("m68k: reorganize Kconfig
options to improve mmu/non-mmu selections") and commit
95e82747d6e2abc513bfae416e6009968985d05b ("m68k: drop unused Kconfig
symbols"). Whatever happened, there is no Kconfig symbol named EMAC_INC.
The select statement for that symbol is a nop. Drop it.

Signed-off-by: Paul Bolle <[email protected]>
---
Untested, but it's hard to see what can got wrong here.

arch/m68k/Kconfig.machine | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/m68k/Kconfig.machine b/arch/m68k/Kconfig.machine
index 7cdf6b0..7240584 100644
--- a/arch/m68k/Kconfig.machine
+++ b/arch/m68k/Kconfig.machine
@@ -310,7 +310,6 @@ config COBRA5282
config SOM5282EM
bool "EMAC.Inc SOM5282EM board support"
depends on M528x
- select EMAC_INC
help
Support for the EMAC.Inc SOM5282EM module.

--
1.7.11.7

2013-03-06 06:10:21

by Greg Ungerer

Subject: Re: [PATCH] m68k: drop "select EMAC_INC"

Hi Paul,

On 06/03/13 03:30, Paul Bolle wrote:
> Somehow this select statement managed to squeeze itself between commit
> 0e152d80507b75c00aac60f2ffc586360687cd52 ("m68k: reorganize Kconfig
> options to improve mmu/non-mmu selections") and commit
> 95e82747d6e2abc513bfae416e6009968985d05b ("m68k: drop unused Kconfig
> symbols"). Whatever happened, there is no Kconfig symbol named EMAC_INC.
> The select statement for that symbol is a nop. Drop it.
>
> Signed-off-by: Paul Bolle <[email protected]>

Thanks, I'll add that to the m68knommu git tree, since it is a non-mmu
target.

Regards
Greg


> Untested, but it's hard to see what can got wrong here.
>
> arch/m68k/Kconfig.machine | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/m68k/Kconfig.machine b/arch/m68k/Kconfig.machine
> index 7cdf6b0..7240584 100644
> --- a/arch/m68k/Kconfig.machine
> +++ b/arch/m68k/Kconfig.machine
> @@ -310,7 +310,6 @@ config COBRA5282
> config SOM5282EM
> bool "EMAC.Inc SOM5282EM board support"
> depends on M528x
> - select EMAC_INC
> help
> Support for the EMAC.Inc SOM5282EM module.
>
>