2013-03-06 02:36:06

by Anil Kumar

[permalink] [raw]
Subject: Re: [PATCH V4] ARM: dts: add minimal DT support for DevKit8000.

Hi Tony,

>> From: linux-arm-kernel [mailto:linux-arm-kernel-
>> [email protected]] On Behalf Of Anil Kumar
>> Sent: Wednesday, February 27, 2013 8:03 AM
>> To: [email protected]; [email protected];
>> [email protected]; [email protected]
>> Cc: [email protected]; Cousson, Benoit; Tony Lindgren; Grant
>> Likely; Anil Kumar; [email protected]
>> Subject: Re: FW: [PATCH V4] ARM: dts: add minimal DT support for
>> DevKit8000.
>>
>> Hi,
>> >
>> > DevKit8000 is a beagle board clone from Timll, sold by
>> > armkits.com. The DevKit8000 has RS232 serial port, LCD, DVI-D,
>> > S-Video, Ethernet, SD/MMC, keyboard, camera, SPI, I2C, USB and
>> > JTAG interface.
>> >
>> > This patch adds the basic DT support for devkit8000. At this time,
>> Information
>> > of twl4030 (PMIC), MMC1, I2C1 and leds are added.
>> >
>> > Signed-off-by: Anil Kumar <[email protected]>
>> > Tested-by: Thomas Weber <[email protected]>
>>
>> Gentle Ping. As there are no review comments on this patch,
>> Could you please pull this patch ?

Gentle Ping.

This patch also got Reviewed-by: Manish Badarkhe <[email protected]>
and as patch "ARM: dts: omap3-devkit8000: Enable audio support" has already got
"Acked-by: Peter Ujfalusi <[email protected]>" but it is on the
top of this patch.
So, Could you please pull this patch in one of your omap branch? or
you want me to
do rebase this patch on top of v3.9-rc1 ?

Thanks,
Anil

>>
>> > ---
>> > -This patch is based on top of kernel 3.8-rc5.
>> >
>> > -Tested on Devkit8000.
>> >
>> > For V4:
>> > -Tiny nitpick.
>> >
>> > For V3:
>> > - Remove pin mux as done at device boot time by default.
>> >
>> > For V2:
>> > - Change model name as "TimLL OMAP3 Devkit8000"
>> > - Change compatible as "timll,omap3-devkit8000"
>> > - Doing i2c1 pinmux default with pinctrl-single driver instead of
>> i2c1
>> > driver probe time.
>> >
>> > :100644 100644 5ebb44f... 22ebc76... M arch/arm/boot/dts/Makefile
>> > :000000 100644 0000000... 2e1463a... A arch/arm/boot/dts/omap3-
>> devkit8000.dts
>> > :100644 100644 53cb380b.. ccecb76... M arch/arm/mach-omap2/board-
>> generic.c
>> > arch/arm/boot/dts/Makefile | 1 +
>> > arch/arm/boot/dts/omap3-devkit8000.dts | 102
>> ++++++++++++++++++++++++++++++++
>> > arch/arm/mach-omap2/board-generic.c | 1 +
>> > 3 files changed, 104 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> > index 5ebb44f..22ebc76 100644
>> > --- a/arch/arm/boot/dts/Makefile
>> > +++ b/arch/arm/boot/dts/Makefile
>> > @@ -102,6 +102,7 @@ dtb-$(CONFIG_ARCH_MXS) += imx23-evk.dtb \
>> > imx28-tx28.dtb
>> > dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
>> > omap3-beagle.dtb \
>> > + omap3-devkit8000.dtb \
>> > omap3-beagle-xm.dtb \
>> > omap3-evm.dtb \
>> > omap3-tobi.dtb \
>> > diff --git a/arch/arm/boot/dts/omap3-devkit8000.dts
>> b/arch/arm/boot/dts/omap3-devkit8000.dts
>> > new file mode 100644
>> > index 0000000..2e1463a
>> > --- /dev/null
>> > +++ b/arch/arm/boot/dts/omap3-devkit8000.dts
>> > @@ -0,0 +1,102 @@
>> > +/*
>> > + * Author: Anil Kumar <[email protected]>
>> > + *
>> > + * This program is free software; you can redistribute it and/or
>> modify
>> > + * it under the terms of the GNU General Public License version 2 as
>> > + * published by the Free Software Foundation.
>> > + */
>> > +/dts-v1/;
>> > +
>> > +/include/ "omap3.dtsi"
>> > +/ {
>> > + model = "TimLL OMAP3 Devkit8000";
>> > + compatible = "timll,omap3-devkit8000", "ti,omap3";
>> > +
>> > + memory {
>> > + device_type = "memory";
>> > + reg = <0x80000000 0x10000000>; /* 256 MB */
>> > + };
>> > +
>> > + leds {
>> > + compatible = "gpio-leds";
>> > +
>> > + heartbeat {
>> > + label = "devkit8000::led1";
>> > + gpios = <&gpio6 26 0>; /* 186 -> LED1 */
>> > + default-state = "on";
>> > + linux,default-trigger = "heartbeat";
>> > + };
>> > +
>> > + mmc {
>> > + label = "devkit8000::led2";
>> > + gpios = <&gpio6 3 0>; /* 163 -> LED2 */
>> > + default-state = "on";
>> > + linux,default-trigger = "none";
>> > + };
>> > +
>> > + usr {
>> > + label = "devkit8000::led3";
>> > + gpios = <&gpio6 4 0>; /* 164 -> LED3 */
>> > + default-state = "on";
>> > + linux,default-trigger = "usr";
>> > + };
>> > + };
>> > +};
>> > +
>> > +&i2c1 {
>> > + clock-frequency = <2600000>;
>> > +
>> > + twl: twl@48 {
>> > + reg = <0x48>;
>> > + interrupts = <7>; /* SYS_NIRQ cascaded to intc
>> */
>> > + interrupt-parent = <&intc>;
>> > + };
>> > +};
>> > +
>> > +&i2c2 {
>> > + status = "disabled";
>> > +};
>> > +
>> > +&i2c3 {
>> > + status = "disabled";
>> > +};
>> > +
>> > +/include/ "twl4030.dtsi"
>> > +
>> > +&mmc1 {
>> > + vmmc-supply = <&vmmc1>;
>> > + vmmc_aux-supply = <&vsim>;
>> > + bus-width = <8>;
>> > +};
>> > +
>> > +&mmc2 {
>> > + status = "disabled";
>> > +};
>> > +
>> > +&mmc3 {
>> > + status = "disabled";
>> > +};
>> > +
>> > +&wdt2 {
>> > + status = "disabled";
>> > +};
>> > +
>> > +&mcbsp1 {
>> > + status = "disabled";
>> > +};
>> > +
>> > +&mcbsp2 {
>> > + status = "disabled";
>> > +};
>> > +
>> > +&mcbsp3 {
>> > + status = "disabled";
>> > +};
>> > +
>> > +&mcbsp4 {
>> > + status = "disabled";
>> > +};
>> > +
>> > +&mcbsp5 {
>> > + status = "disabled";
>> > +};
>> > diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-
>> omap2/board-generic.c
>> > index 53cb380..ccecb76 100644
>> > --- a/arch/arm/mach-omap2/board-generic.c
>> > +++ b/arch/arm/mach-omap2/board-generic.c
>> > @@ -110,6 +110,7 @@ MACHINE_END
>> >
>> > static const char *omap3_gp_boards_compat[] __initdata = {
>> > "ti,omap3-beagle",
>> > + "timll,omap3-devkit8000",
>> > NULL,
>> > };
>> >
>> > --
>> > 1.7.0.4
>> >
>> >
>> > _______________________________________________
>> > linux-arm-kernel mailing list
>> > [email protected]
>> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> [email protected]
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


2013-03-06 17:53:19

by Tony Lindgren

[permalink] [raw]
Subject: Re: [PATCH V4] ARM: dts: add minimal DT support for DevKit8000.

* Anil Kumar <[email protected]> [130305 18:40]:
> Hi Tony,
>
> >> From: linux-arm-kernel [mailto:linux-arm-kernel-
> >> [email protected]] On Behalf Of Anil Kumar
> >> Sent: Wednesday, February 27, 2013 8:03 AM
> >> To: [email protected]; [email protected];
> >> [email protected]; [email protected]
> >> Cc: [email protected]; Cousson, Benoit; Tony Lindgren; Grant
> >> Likely; Anil Kumar; [email protected]
> >> Subject: Re: FW: [PATCH V4] ARM: dts: add minimal DT support for
> >> DevKit8000.
> >>
> >> Hi,
> >> >
> >> > DevKit8000 is a beagle board clone from Timll, sold by
> >> > armkits.com. The DevKit8000 has RS232 serial port, LCD, DVI-D,
> >> > S-Video, Ethernet, SD/MMC, keyboard, camera, SPI, I2C, USB and
> >> > JTAG interface.
> >> >
> >> > This patch adds the basic DT support for devkit8000. At this time,
> >> Information
> >> > of twl4030 (PMIC), MMC1, I2C1 and leds are added.
> >> >
> >> > Signed-off-by: Anil Kumar <[email protected]>
> >> > Tested-by: Thomas Weber <[email protected]>
> >>
> >> Gentle Ping. As there are no review comments on this patch,
> >> Could you please pull this patch ?
>
> Gentle Ping.
>
> This patch also got Reviewed-by: Manish Badarkhe <[email protected]>
> and as patch "ARM: dts: omap3-devkit8000: Enable audio support" has already got
> "Acked-by: Peter Ujfalusi <[email protected]>" but it is on the
> top of this patch.
> So, Could you please pull this patch in one of your omap branch? or
> you want me to
> do rebase this patch on top of v3.9-rc1 ?

Let's wait for Benoit to queue it as he has a bunch of .dts changes already
applied. Too bad we missed v3.9 merge window for those, but hopefully
we can get them queued early for v3.10.

Regards,

Tony

2013-03-07 06:51:57

by Benoit Cousson

[permalink] [raw]
Subject: Re: [PATCH V4] ARM: dts: add minimal DT support for DevKit8000.

Hi,

On 03/06/2013 06:53 PM, Tony Lindgren wrote:
> * Anil Kumar <[email protected]> [130305 18:40]:
>> Hi Tony,
>>
>>>> From: linux-arm-kernel [mailto:linux-arm-kernel-
>>>> [email protected]] On Behalf Of Anil Kumar
>>>> Sent: Wednesday, February 27, 2013 8:03 AM
>>>> To: [email protected]; [email protected];
>>>> [email protected]; [email protected]
>>>> Cc: [email protected]; Cousson, Benoit; Tony Lindgren; Grant
>>>> Likely; Anil Kumar; [email protected]
>>>> Subject: Re: FW: [PATCH V4] ARM: dts: add minimal DT support for
>>>> DevKit8000.
>>>>
>>>> Hi,
>>>>>
>>>>> DevKit8000 is a beagle board clone from Timll, sold by
>>>>> armkits.com. The DevKit8000 has RS232 serial port, LCD, DVI-D,
>>>>> S-Video, Ethernet, SD/MMC, keyboard, camera, SPI, I2C, USB and
>>>>> JTAG interface.
>>>>>
>>>>> This patch adds the basic DT support for devkit8000. At this time,
>>>> Information
>>>>> of twl4030 (PMIC), MMC1, I2C1 and leds are added.
>>>>>
>>>>> Signed-off-by: Anil Kumar <[email protected]>
>>>>> Tested-by: Thomas Weber <[email protected]>
>>>>
>>>> Gentle Ping. As there are no review comments on this patch,
>>>> Could you please pull this patch ?
>>
>> Gentle Ping.
>>
>> This patch also got Reviewed-by: Manish Badarkhe <[email protected]>
>> and as patch "ARM: dts: omap3-devkit8000: Enable audio support" has already got
>> "Acked-by: Peter Ujfalusi <[email protected]>" but it is on the
>> top of this patch.
>> So, Could you please pull this patch in one of your omap branch? or
>> you want me to
>> do rebase this patch on top of v3.9-rc1 ?
>
> Let's wait for Benoit to queue it as he has a bunch of .dts changes already
> applied. Too bad we missed v3.9 merge window for those, but hopefully
> we can get them queued early for v3.10.

Yep, sorry for having missed 3.9, I was a little bit sick at the wrong
moment :-(

I'm starting queuing the pending patches, and should have enough to push
to you just after Linaro Connect.

Regards,
Benoit

2013-03-07 17:18:23

by Tony Lindgren

[permalink] [raw]
Subject: Re: [PATCH V4] ARM: dts: add minimal DT support for DevKit8000.

* Benoit Cousson <[email protected]> [130306 22:55]:
>
> Yep, sorry for having missed 3.9, I was a little bit sick at the wrong
> moment :-(

Well that just proves the .dts files can be merged totally independent
of the rest of the patches ;)

> I'm starting queuing the pending patches, and should have enough to push
> to you just after Linaro Connect.

OK sounds good.

Regards,

Tony

2013-03-17 05:23:40

by Anil Kumar

[permalink] [raw]
Subject: Re: [PATCH V4] ARM: dts: add minimal DT support for DevKit8000.

Hi Benoit,

On Thu, Mar 7, 2013 at 12:21 PM, Benoit Cousson <[email protected]> wrote:
> Hi,
>
> On 03/06/2013 06:53 PM, Tony Lindgren wrote:
>> * Anil Kumar <[email protected]> [130305 18:40]:
>>> Hi Tony,
>>>
>>>>> From: linux-arm-kernel [mailto:linux-arm-kernel-
>>>>> [email protected]] On Behalf Of Anil Kumar
>>>>> Sent: Wednesday, February 27, 2013 8:03 AM
>>>>> To: [email protected]; [email protected];
>>>>> [email protected]; [email protected]
>>>>> Cc: [email protected]; Cousson, Benoit; Tony Lindgren; Grant
>>>>> Likely; Anil Kumar; [email protected]
>>>>> Subject: Re: FW: [PATCH V4] ARM: dts: add minimal DT support for
>>>>> DevKit8000.
>>>>>
>>>>> Hi,
>>>>>>
>>>>>> DevKit8000 is a beagle board clone from Timll, sold by
>>>>>> armkits.com. The DevKit8000 has RS232 serial port, LCD, DVI-D,
>>>>>> S-Video, Ethernet, SD/MMC, keyboard, camera, SPI, I2C, USB and
>>>>>> JTAG interface.
>>>>>>
>>>>>> This patch adds the basic DT support for devkit8000. At this time,
>>>>> Information
>>>>>> of twl4030 (PMIC), MMC1, I2C1 and leds are added.
>>>>>>
>>>>>> Signed-off-by: Anil Kumar <[email protected]>
>>>>>> Tested-by: Thomas Weber <[email protected]>
>>>>>
>>>>> Gentle Ping. As there are no review comments on this patch,
>>>>> Could you please pull this patch ?
>>>
>>> Gentle Ping.
>>>
>>> This patch also got Reviewed-by: Manish Badarkhe <[email protected]>
>>> and as patch "ARM: dts: omap3-devkit8000: Enable audio support" has already got
>>> "Acked-by: Peter Ujfalusi <[email protected]>" but it is on the
>>> top of this patch.
>>> So, Could you please pull this patch in one of your omap branch? or
>>> you want me to
>>> do rebase this patch on top of v3.9-rc1 ?
>>
>> Let's wait for Benoit to queue it as he has a bunch of .dts changes already
>> applied. Too bad we missed v3.9 merge window for those, but hopefully
>> we can get them queued early for v3.10.
>
> Yep, sorry for having missed 3.9, I was a little bit sick at the wrong
> moment :-(
>
> I'm starting queuing the pending patches, and should have enough to push
> to you just after Linaro Connect.

I think you missed below patch which is needed for gpmc nand to work fine.

Jon Hunter:-
ARM: OMAP2+: Fix-up gpmc merge error

I have re based my changes on top of your repository to make pull
easier for you.
I hope you will pull these changes for 3.10.

The following changes since Commit a7f7881de9c0b58de3b3aea8f01a8aef906d4ade

are available in the git repository at:

git://gitorious.org/devkit8000-for_3-10/devkit8000-for_3-10.git
branch for_3.10/dts

for you to fetch changes up to Commit 975abc8b2e7ec4ff7324d726c9775958945ccc5e

Anil Kumar:
ARM: dts: add minimal DT support for DevKit8000
ARM: dts: omap3-devkit8000: Enable audio support
ARM: dts: omap3-devkit8000: add nand dt node

Thanks,
Anil

2013-03-18 15:22:23

by Benoit Cousson

[permalink] [raw]
Subject: Re: [PATCH V4] ARM: dts: add minimal DT support for DevKit8000.

Hi Anil,

On 03/17/2013 06:23 AM, Anil Kumar wrote:
> Hi Benoit,
>
> On Thu, Mar 7, 2013 at 12:21 PM, Benoit Cousson <[email protected]> wrote:
>> Hi,
>>
>> On 03/06/2013 06:53 PM, Tony Lindgren wrote:
>>> * Anil Kumar <[email protected]> [130305 18:40]:
>>>> Hi Tony,
>>>>
>>>>>> From: linux-arm-kernel [mailto:linux-arm-kernel-
>>>>>> [email protected]] On Behalf Of Anil Kumar
>>>>>> Sent: Wednesday, February 27, 2013 8:03 AM
>>>>>> To: [email protected]; [email protected];
>>>>>> [email protected]; [email protected]
>>>>>> Cc: [email protected]; Cousson, Benoit; Tony Lindgren; Grant
>>>>>> Likely; Anil Kumar; [email protected]
>>>>>> Subject: Re: FW: [PATCH V4] ARM: dts: add minimal DT support for
>>>>>> DevKit8000.
>>>>>>
>>>>>> Hi,
>>>>>>>
>>>>>>> DevKit8000 is a beagle board clone from Timll, sold by
>>>>>>> armkits.com. The DevKit8000 has RS232 serial port, LCD, DVI-D,
>>>>>>> S-Video, Ethernet, SD/MMC, keyboard, camera, SPI, I2C, USB and
>>>>>>> JTAG interface.
>>>>>>>
>>>>>>> This patch adds the basic DT support for devkit8000. At this time,
>>>>>> Information
>>>>>>> of twl4030 (PMIC), MMC1, I2C1 and leds are added.
>>>>>>>
>>>>>>> Signed-off-by: Anil Kumar <[email protected]>
>>>>>>> Tested-by: Thomas Weber <[email protected]>
>>>>>>
>>>>>> Gentle Ping. As there are no review comments on this patch,
>>>>>> Could you please pull this patch ?
>>>>
>>>> Gentle Ping.
>>>>
>>>> This patch also got Reviewed-by: Manish Badarkhe <[email protected]>
>>>> and as patch "ARM: dts: omap3-devkit8000: Enable audio support" has already got
>>>> "Acked-by: Peter Ujfalusi <[email protected]>" but it is on the
>>>> top of this patch.
>>>> So, Could you please pull this patch in one of your omap branch? or
>>>> you want me to
>>>> do rebase this patch on top of v3.9-rc1 ?
>>>
>>> Let's wait for Benoit to queue it as he has a bunch of .dts changesfor_3.10/dts already
>>> applied. Too bad we missed v3.9 merge window for those, but hopefully
>>> we can get them queued early for v3.10.
>>
>> Yep, sorry for having missed 3.9, I was a little bit sick at the wrong
>> moment :-(
>>
>> I'm starting queuing the pending patches, and should have enough to push
>> to you just after Linaro Connect.
>
> I think you missed below patch which is needed for gpmc nand to work fine.
>
> Jon Hunter:-
> ARM: OMAP2+: Fix-up gpmc merge error
>
> I have re based my changes on top of your repository to make pull
> easier for you.
> I hope you will pull these changes for 3.10.
>
> The following changes since Commit a7f7881de9c0b58de3b3aea8f01a8aef906d4ade
>
> are available in the git repository at:
>
> git://gitorious.org/devkit8000-for_3-10/devkit8000-for_3-10.git
> branch for_3.10/dts
>
> for you to fetch changes up to Commit 975abc8b2e7ec4ff7324d726c9775958945ccc5e

Thanks, I pulled the patches and rebased that on top of -rc3 to get the
missing fix from Jon.

I cleaned as well some changelog / subject and pushed then in my
for_3.10/dts branch.

Regards,
Benoit