Hi all,
After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:
drivers/gpio/gpio-palmas.c: In function 'palmas_gpio_probe':
drivers/gpio/gpio-palmas.c:173:2: error: implicit declaration of function 'is_palmas_charger' [-Werror=implicit-function-declaration]
drivers/gpio/gpio-palmas.c:173:30: error: 'struct palmas' has no member named 'product_id'
Caused by commit 82d4d6637fdf ("gpio/palmas: add in GPIO support for
palmas charger"). I wonder if this was ever build tested. :-(
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell [email protected]
On Wed, Mar 6, 2013 at 8:44 AM, Stephen Rothwell <[email protected]> wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/gpio/gpio-palmas.c: In function 'palmas_gpio_probe':
> drivers/gpio/gpio-palmas.c:173:2: error: implicit declaration of function 'is_palmas_charger' [-Werror=implicit-function-declaration]
> drivers/gpio/gpio-palmas.c:173:30: error: 'struct palmas' has no member named 'product_id'
>
> Caused by commit 82d4d6637fdf ("gpio/palmas: add in GPIO support for
> palmas charger"). I wonder if this was ever build tested. :-(
Probably not. Looks like this driver doesn't get enabled without the
associated option in MFD. I didn't go searching for it, so my build
tests didn't catch it. I'll drop the patch from my tree. Sorry for the
pain.
g.
Hi Grant,
On Wed, 6 Mar 2013 09:10:42 +0800 Grant Likely <[email protected]> wrote:
>
> On Wed, Mar 6, 2013 at 8:44 AM, Stephen Rothwell <[email protected]> wrote:
> >
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > drivers/gpio/gpio-palmas.c: In function 'palmas_gpio_probe':
> > drivers/gpio/gpio-palmas.c:173:2: error: implicit declaration of function 'is_palmas_charger' [-Werror=implicit-function-declaration]
> > drivers/gpio/gpio-palmas.c:173:30: error: 'struct palmas' has no member named 'product_id'
> >
> > Caused by commit 82d4d6637fdf ("gpio/palmas: add in GPIO support for
> > palmas charger"). I wonder if this was ever build tested. :-(
>
> Probably not. Looks like this driver doesn't get enabled without the
> associated option in MFD. I didn't go searching for it, so my build
> tests didn't catch it. I'll drop the patch from my tree. Sorry for the
> pain.
I am still having to revert this commit .... :-(
--
Cheers,
Stephen Rothwell [email protected]
On 20/03/13 15:25, Stephen Rothwell wrote:
> Hi Grant,
>
> On Wed, 6 Mar 2013 09:10:42 +0800 Grant Likely <[email protected]> wrote:
>>
>> On Wed, Mar 6, 2013 at 8:44 AM, Stephen Rothwell <[email protected]> wrote:
>>>
>>> After merging the final tree, today's linux-next build (powerpc
>>> allyesconfig) failed like this:
>>>
>>> drivers/gpio/gpio-palmas.c: In function 'palmas_gpio_probe':
>>> drivers/gpio/gpio-palmas.c:173:2: error: implicit declaration of function 'is_palmas_charger' [-Werror=implicit-function-declaration]
>>> drivers/gpio/gpio-palmas.c:173:30: error: 'struct palmas' has no member named 'product_id'
>>>
>>> Caused by commit 82d4d6637fdf ("gpio/palmas: add in GPIO support for
>>> palmas charger"). I wonder if this was ever build tested. :-(
>>
>> Probably not. Looks like this driver doesn't get enabled without the
>> associated option in MFD. I didn't go searching for it, so my build
>> tests didn't catch it. I'll drop the patch from my tree. Sorry for the
>> pain.
>
> I am still having to revert this commit .... :-(
>
Sorry Stephen - There's a new patch series, that should resolve this,
undergoing review at the moment so that patch should be reverted...
for now.
Regards,
Ian
On Wed, Mar 20, 2013 at 3:25 PM, Stephen Rothwell <[email protected]> wrote:
> Hi Grant,
>
> On Wed, 6 Mar 2013 09:10:42 +0800 Grant Likely <[email protected]> wrote:
>>
>> On Wed, Mar 6, 2013 at 8:44 AM, Stephen Rothwell <[email protected]> wrote:
>> > Caused by commit 82d4d6637fdf ("gpio/palmas: add in GPIO support for
>> > palmas charger"). I wonder if this was ever build tested. :-(
>>
>> Probably not. Looks like this driver doesn't get enabled without the
>> associated option in MFD. I didn't go searching for it, so my build
>> tests didn't catch it. I'll drop the patch from my tree. Sorry for the
>> pain.
>
> I am still having to revert this commit .... :-(
Ugh, sorry. I reverted the patch while travelling, but never pushed
out the fixed tree. Try it now.
g.
> --
> Cheers,
> Stephen Rothwell [email protected]
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
Hi Grant,
On Wed, 20 Mar 2013 15:57:01 +0000 Grant Likely <[email protected]> wrote:
>
> On Wed, Mar 20, 2013 at 3:25 PM, Stephen Rothwell <[email protected]> wrote:
> >
> > On Wed, 6 Mar 2013 09:10:42 +0800 Grant Likely <[email protected]> wrote:
> >>
> >> On Wed, Mar 6, 2013 at 8:44 AM, Stephen Rothwell <[email protected]> wrote:
> >> > Caused by commit 82d4d6637fdf ("gpio/palmas: add in GPIO support for
> >> > palmas charger"). I wonder if this was ever build tested. :-(
> >>
> >> Probably not. Looks like this driver doesn't get enabled without the
> >> associated option in MFD. I didn't go searching for it, so my build
> >> tests didn't catch it. I'll drop the patch from my tree. Sorry for the
> >> pain.
> >
> > I am still having to revert this commit .... :-(
>
> Ugh, sorry. I reverted the patch while travelling, but never pushed
> out the fixed tree. Try it now.
Thanks.
--
Cheers,
Stephen Rothwell [email protected]