2013-03-21 07:18:28

by Zhi Yong Wu

Subject: [PATCH] btrfs-progs: fix one bracket issue in mkfs.btrfs manpage

From: Zhi Yong Wu <[email protected]>

In "[ \fB\-f\fP\fI ]", the "\fI" will result in the front half "["of
"[ -f ]" doesn't the back half "]"; When you issue the command
"man mkfs.btrfs", you will see the difference.

Signed-off-by: Zhi Yong Wu <[email protected]>
---
man/mkfs.btrfs.8.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man/mkfs.btrfs.8.in b/man/mkfs.btrfs.8.in
index cdccd6a..a3f1503 100644
--- a/man/mkfs.btrfs.8.in
+++ b/man/mkfs.btrfs.8.in
@@ -6,7 +6,7 @@ mkfs.btrfs \- create a btrfs filesystem
[ \fB\-A\fP\fI alloc-start\fP ]
[ \fB\-b\fP\fI byte-count\fP ]
[ \fB\-d\fP\fI data-profile\fP ]
-[ \fB\-f\fP\fI ]
+[ \fB\-f\fP ]
[ \fB\-l\fP\fI leafsize\fP ]
[ \fB\-L\fP\fI label\fP ]
[ \fB\-m\fP\fI metadata profile\fP ]
--
1.7.11.7

2013-03-21 09:08:27

by Eric Sandeen

Subject: Re: [PATCH] btrfs-progs: fix one bracket issue in mkfs.btrfs manpage

On 3/21/13 2:17 AM, [email protected] wrote:
> From: Zhi Yong Wu <[email protected]>
>
> In "[ \fB\-f\fP\fI ]", the "\fI" will result in the front half "["of
> "[ -f ]" doesn't the back half "]"; When you issue the command
> "man mkfs.btrfs", you will see the difference.
>
> Signed-off-by: Zhi Yong Wu <[email protected]>

Whoops, yes. Thanks for spotting that.

Reviewed-by: Eric Sandeen <[email protected]>

> ---
> man/mkfs.btrfs.8.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man/mkfs.btrfs.8.in b/man/mkfs.btrfs.8.in
> index cdccd6a..a3f1503 100644
> --- a/man/mkfs.btrfs.8.in
> +++ b/man/mkfs.btrfs.8.in
> @@ -6,7 +6,7 @@ mkfs.btrfs \- create a btrfs filesystem
> [ \fB\-A\fP\fI alloc-start\fP ]
> [ \fB\-b\fP\fI byte-count\fP ]
> [ \fB\-d\fP\fI data-profile\fP ]
> -[ \fB\-f\fP\fI ]
> +[ \fB\-f\fP ]
> [ \fB\-l\fP\fI leafsize\fP ]
> [ \fB\-L\fP\fI label\fP ]
> [ \fB\-m\fP\fI metadata profile\fP ]
>