2013-03-22 02:03:14

by zhangwei(Jovi)

Subject: [PATCH] init/Kconfig: make EXPERT as config instead of menuconfig

There don't have any EXPERT menu guard, and no config item is
included in EXPERT menu, so change it as a config, not menu.

This will make user more clear when they use 'make menuconfig'
or 'make nconfig'.

Signed-off-by: zhangwei(Jovi) <[email protected]>
Cc: Randy Dunlap <[email protected]>
Cc: Michal Marek <[email protected]>
---
init/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/init/Kconfig b/init/Kconfig
index 5341d72..0495453 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1177,7 +1177,7 @@ config SYSCTL
config ANON_INODES
bool

-menuconfig EXPERT
+config EXPERT
bool "Configure standard kernel features (expert users)"
# Unhide debug options, to make the on-by-default options visible
select DEBUG_KERNEL
--
1.7.9.7

2013-03-26 00:20:04

by Randy Dunlap

Subject: Re: [PATCH] init/Kconfig: make EXPERT as config instead of menuconfig

On 03/21/13 19:02, zhangwei(Jovi) wrote:
> There don't have any EXPERT menu guard, and no config item is
> included in EXPERT menu, so change it as a config, not menu.
>
> This will make user more clear when they use 'make menuconfig'
> or 'make nconfig'.
>
> Signed-off-by: zhangwei(Jovi) <[email protected]>
> Cc: Randy Dunlap <[email protected]>
> Cc: Michal Marek <[email protected]>

Makes sense to me.

Acked-by: Randy Dunlap <[email protected]>


Thanks.

> ---
> init/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/init/Kconfig b/init/Kconfig
> index 5341d72..0495453 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -1177,7 +1177,7 @@ config SYSCTL
> config ANON_INODES
> bool
>
> -menuconfig EXPERT
> +config EXPERT
> bool "Configure standard kernel features (expert users)"
> # Unhide debug options, to make the on-by-default options visible
> select DEBUG_KERNEL
>


--
~Randy