2018-08-02 08:04:05

by Daniel Borkmann

[permalink] [raw]
Subject: Re: [RFC bpf-next 3/3] docs: Split filter.txt into separate documents.

On 08/02/2018 08:28 AM, Tobin C. Harding wrote:
> In preparation for conversion of Documentation/networking/filter.txt it was
> noticed that the document contains a lot of information. The document may be
> more accessible if it was split up. Some parts pertain to everyone, let's put
> these bits in core-api/. The more hard core bits about eBPF internals could be
> put with the other BPF docs in Documentation/bpf/. There is a small bit of
> information on testing and miscellaneous matters that are useful for everyone
> (everyone does testing, right) so lets keep that info at the bottom of both new
> documents. (This includes the original authors.)
>
> Split Documentation/networking/filter.txt into Documentation/bpf/eBPF.rst and
> Documentation/core-api/bpf.rst
>
> Cc: Jay Schulist <[email protected]>
> Cc: Daniel Borkmann <[email protected]>
> Cc; Alexei Starovoitov <[email protected]>
> Signed-off-by: Tobin C. Harding <[email protected]>
> ---
> Documentation/networking/filter.txt | 1480 ---------------------------
> 1 file changed, 1480 deletions(-)
> delete mode 100644 Documentation/networking/filter.txt

Missing git add given the new files are not present here?

Overall I agree it would be good if we move all the content over into
Documentation/bpf/ eventually, but would be useful to see a full diff.


2018-08-02 11:05:01

by Tobin C. Harding

[permalink] [raw]
Subject: Re: [RFC bpf-next 3/3] docs: Split filter.txt into separate documents.

On Thu, Aug 02, 2018 at 10:02:50AM +0200, Daniel Borkmann wrote:
> On 08/02/2018 08:28 AM, Tobin C. Harding wrote:
> > In preparation for conversion of Documentation/networking/filter.txt it was
> > noticed that the document contains a lot of information. The document may be
> > more accessible if it was split up. Some parts pertain to everyone, let's put
> > these bits in core-api/. The more hard core bits about eBPF internals could be
> > put with the other BPF docs in Documentation/bpf/. There is a small bit of
> > information on testing and miscellaneous matters that are useful for everyone
> > (everyone does testing, right) so lets keep that info at the bottom of both new
> > documents. (This includes the original authors.)
> >
> > Split Documentation/networking/filter.txt into Documentation/bpf/eBPF.rst and
> > Documentation/core-api/bpf.rst
> >
> > Cc: Jay Schulist <[email protected]>
> > Cc: Daniel Borkmann <[email protected]>
> > Cc; Alexei Starovoitov <[email protected]>
> > Signed-off-by: Tobin C. Harding <[email protected]>
> > ---
> > Documentation/networking/filter.txt | 1480 ---------------------------
> > 1 file changed, 1480 deletions(-)
> > delete mode 100644 Documentation/networking/filter.txt
>
> Missing git add given the new files are not present here?

Fail! Not reading the whole patch before sending it - Bad Tobin,no
biscuit.

> Overall I agree it would be good if we move all the content over into
> Documentation/bpf/ eventually, but would be useful to see a full diff.

Thanks for your very patient and polite response. I'll send it in the
morning to save embarrassing myself with any other late night errors.

Tobin