The current lpc32xx_defconfig breaks like this, caused by recent phy
restructuring:
LD init/built-in.o
drivers/built-in.o: In function `usb_hcd_nxp_probe':
drivers/usb/host/ohci-nxp.c:224: undefined reference to `isp1301_get_client'
drivers/built-in.o: In function `lpc32xx_udc_probe':
drivers/usb/gadget/lpc32xx_udc.c:3104: undefined reference to
`isp1301_get_client' distcc[27867] ERROR: compile (null) on localhost failed
make: *** [vmlinux] Error 1
This patch fixes this by selecting USB_OTG_UTILS in Kconfig which
causes the phy driver to be built again.
Signed-off-by: Roland Stigge <[email protected]>
--
Applies to v3.9-rc4
---
drivers/usb/gadget/Kconfig | 1 +
drivers/usb/phy/Kconfig | 1 +
2 files changed, 2 insertions(+)
--- linux-2.6.orig/drivers/usb/gadget/Kconfig
+++ linux-2.6/drivers/usb/gadget/Kconfig
@@ -145,6 +145,7 @@ config USB_LPC32XX
tristate "LPC32XX USB Peripheral Controller"
depends on ARCH_LPC32XX
select USB_ISP1301
+ select USB_OTG_UTILS
help
This option selects the USB device controller in the LPC32xx SoC.
--- linux-2.6.orig/drivers/usb/phy/Kconfig
+++ linux-2.6/drivers/usb/phy/Kconfig
@@ -38,6 +38,7 @@ config USB_ISP1301
tristate "NXP ISP1301 USB transceiver support"
depends on USB || USB_GADGET
depends on I2C
+ select USB_OTG_UTILS
help
Say Y here to add support for the NXP ISP1301 USB transceiver driver.
This chip is typically used as USB transceiver for USB host, gadget
Hi,
On Tue, Mar 26, 2013 at 06:36:01PM +0100, Roland Stigge wrote:
> The current lpc32xx_defconfig breaks like this, caused by recent phy
> restructuring:
which commit actually caused this ? I need to know to make sure if this
should be sent to stable or not.
--
balbi
Hi,
On Tue, Mar 26, 2013 at 08:18:36PM +0100, Roland Stigge wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: RIPEMD160
>
> On 03/26/2013 07:03 PM, Felipe Balbi wrote:
> > On Tue, Mar 26, 2013 at 06:36:01PM +0100, Roland Stigge wrote:
> >> The current lpc32xx_defconfig breaks like this, caused by recent
> >> phy restructuring:
> >
> > which commit actually caused this ? I need to know to make sure if
> > this should be sent to stable or not.
>
> The issue definitely surfaced after v3.8, so no need for patching
> stable, I guess.
are you sure ? I don't see any commits under drivers/usb/gadget/Kconfig
which could've caused what you described. Can you blame a commit ?
--
balbi
-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160
On 03/26/2013 07:03 PM, Felipe Balbi wrote:
> On Tue, Mar 26, 2013 at 06:36:01PM +0100, Roland Stigge wrote:
>> The current lpc32xx_defconfig breaks like this, caused by recent
>> phy restructuring:
>
> which commit actually caused this ? I need to know to make sure if
> this should be sent to stable or not.
The issue definitely surfaced after v3.8, so no need for patching
stable, I guess.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iD8DBQFRUfSMcaH/YBv43g8RA70DAKCigz7Qy4f01S9P5dNLH6jxlERF6gCg3H3q
qMlT8LpXfybr588cZFJUjcc=
=45cd
-----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160
On 03/26/2013 08:24 PM, Felipe Balbi wrote:
> commit ?
1c2088812f095df77f4b3224b65db79d7111a300
Seems to be based on the assumption that only OTG needs a PHY.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iD8DBQFRUgQ/caH/YBv43g8RA7RwAKC5HfJmtZonZnwGs6h+hW6Nqi1++wCg25xt
0lckwMSSDwJ4PNiDKqqtRpY=
=Zpq1
-----END PGP SIGNATURE-----
On Tue, Mar 26, 2013 at 09:25:35PM +0100, Roland Stigge wrote:
> On 03/26/2013 08:24 PM, Felipe Balbi wrote:
> > commit ?
>
> 1c2088812f095df77f4b3224b65db79d7111a300
Showed up in 3.9-rc3.
Felipe, I can take this directly if you don't have any other USB patches
for me at the moment.
greg k-h
On Tue, Mar 26, 2013 at 01:37:41PM -0700, Greg KH wrote:
> On Tue, Mar 26, 2013 at 09:25:35PM +0100, Roland Stigge wrote:
> > On 03/26/2013 08:24 PM, Felipe Balbi wrote:
> > > commit ?
> >
> > 1c2088812f095df77f4b3224b65db79d7111a300
>
> Showed up in 3.9-rc3.
>
> Felipe, I can take this directly if you don't have any other USB patches
> for me at the moment.
please go ahead Greg:
Acked-by: Felipe Balbi <[email protected]>
--
balbi