2013-03-27 07:14:33

by Chen Gang

Subject: [Suggestion] drivers/block/aoe: using uninitialized variable.

Hello Ed L. Cashin

when compiling with EXTRA_CFLAGS=-W

get the warning:
drivers/block/aoe/aoecmd.c:931:20: warning: ?bv? is used uninitialized in this function [-Wuninitialized]

bv is really not initialized.
(and it seems only set "buf->bv_resid = 0" is not enough).

thanks.

gchen.

919 static void
920 bufinit(struct buf *buf, struct request *rq, struct bio *bio)
921 {
922 struct bio_vec *bv;
923
924 memset(buf, 0, sizeof(*buf));
925 buf->rq = rq;
926 buf->bio = bio;
927 buf->resid = bio->bi_size;
928 buf->sector = bio->bi_sector;
929 bio_pageinc(bio);
930 buf->bv = bio_iovec(bio);
931 buf->bv_resid = bv->bv_len;
932 WARN_ON(buf->bv_resid == 0);
933 }

2013-03-27 14:05:04

by Ed L. Cashin

Subject: Re: [Suggestion] drivers/block/aoe: using uninitialized variable.

Thanks. Jens Axboe said about it to Dan Carpenter that ...

> It was fixed up yesterday, it was a merge error in the for-next branch.

On Mar 27, 2013, at 3:14 AM, Chen Gang wrote:

> Hello Ed L. Cashin
>
> when compiling with EXTRA_CFLAGS=-W
>
> get the warning:
> drivers/block/aoe/aoecmd.c:931:20: warning: ?bv? is used uninitialized in this function [-Wuninitialized]
>
> bv is really not initialized.
> (and it seems only set "buf->bv_resid = 0" is not enough).
>
> thanks.
>
> gchen.
>
> 919 static void
> 920 bufinit(struct buf *buf, struct request *rq, struct bio *bio)
> 921 {
> 922 struct bio_vec *bv;
> 923
> 924 memset(buf, 0, sizeof(*buf));
> 925 buf->rq = rq;
> 926 buf->bio = bio;
> 927 buf->resid = bio->bi_size;
> 928 buf->sector = bio->bi_sector;
> 929 bio_pageinc(bio);
> 930 buf->bv = bio_iovec(bio);
> 931 buf->bv_resid = bv->bv_len;
> 932 WARN_ON(buf->bv_resid == 0);
> 933 }
>
>

--
Ed Cashin
[email protected]

2013-03-28 01:51:42

by Chen Gang F T

Subject: Re: [Suggestion] drivers/block/aoe: using uninitialized variable.

On 2013年03月27日 22:04, Ed Cashin wrote:
> Thanks. Jens Axboe said about it to Dan Carpenter that ...
>
>> > It was fixed up yesterday, it was a merge error in the for-next branch.


thanks.

:-)

--
Chen Gang

Flying Transformer