2013-04-04 01:00:53

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warning after merge of the wireless-next tree

Hi John,

After merging the wireless-next tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done

I have no idea what caused that.
--
Cheers,
Stephen Rothwell [email protected]


Attachments:
(No filename) (1.37 kB)
(No filename) (836.00 B)
Download all attachments

2013-04-04 01:04:08

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the wireless-next tree

Hi John,

On Thu, 4 Apr 2013 12:00:43 +1100 Stephen Rothwell <[email protected]> wrote:
>
> After merging the wireless-next tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>
> I have no idea what caused that.

Though I suspect commit 8b138d4898a0 ("rtlwifi: rtl8188ee: Enable build
of new driver") - I wonder if the gap between the "-I" and
"drivers/net/wireless/rtlwifi" added to ccflags-y is the cause?

I am using gcc 4.6.3 if that matters.
--
Cheers,
Stephen Rothwell [email protected]


Attachments:
(No filename) (1.71 kB)
(No filename) (836.00 B)
Download all attachments

2013-04-04 01:17:08

by Larry Finger

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the wireless-next tree

On 04/03/2013 08:04 PM, Stephen Rothwell wrote:
> Hi John,
>
> On Thu, 4 Apr 2013 12:00:43 +1100 Stephen Rothwell <[email protected]> wrote:
>>
>> After merging the wireless-next tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>>
>> I have no idea what caused that.
>
> Though I suspect commit 8b138d4898a0 ("rtlwifi: rtl8188ee: Enable build
> of new driver") - I wonder if the gap between the "-I" and
> "drivers/net/wireless/rtlwifi" added to ccflags-y is the cause?
>
> I am using gcc 4.6.3 if that matters.

I use 4.7.2.

I'll send a patch with the space removed to see if that helps.

Larry

2013-04-04 02:36:21

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the wireless-next tree

Hi Larry,

On Wed, 03 Apr 2013 20:17:01 -0500 Larry Finger <[email protected]> wrote:
>
> On 04/03/2013 08:04 PM, Stephen Rothwell wrote:
> >
> > On Thu, 4 Apr 2013 12:00:43 +1100 Stephen Rothwell <[email protected]> wrote:
> >>
> >> After merging the wireless-next tree, today's linux-next build (x86_64
> >> allmodconfig) produced this warning:
> >>
> >> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> >> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> >> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> >> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> >> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> >> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> >> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> >> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> >> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> >> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> >> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> >>
> >> I have no idea what caused that.
> >
> > Though I suspect commit 8b138d4898a0 ("rtlwifi: rtl8188ee: Enable build
> > of new driver") - I wonder if the gap between the "-I" and
> > "drivers/net/wireless/rtlwifi" added to ccflags-y is the cause?
> >
> > I am using gcc 4.6.3 if that matters.
>
> I use 4.7.2.
>
> I'll send a patch with the space removed to see if that helps.

I just tested without the space and it fixes the problem for my Debian
4.7.2 compiler. Removing the space also fixes the problem with finding
include files (after I removed the "../" bits again).

--
Cheers,
Stephen Rothwell [email protected]


Attachments:
(No filename) (2.20 kB)
(No filename) (836.00 B)
Download all attachments

2013-04-04 02:58:10

by Larry Finger

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the wireless-next tree

On 04/03/2013 09:36 PM, Stephen Rothwell wrote:
> Hi Larry,
>
> On Wed, 03 Apr 2013 20:17:01 -0500 Larry Finger <[email protected]> wrote:
>>
>> On 04/03/2013 08:04 PM, Stephen Rothwell wrote:
>>>
>>> On Thu, 4 Apr 2013 12:00:43 +1100 Stephen Rothwell <[email protected]> wrote:
>>>>
>>>> After merging the wireless-next tree, today's linux-next build (x86_64
>>>> allmodconfig) produced this warning:
>>>>
>>>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>>>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>>>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>>>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>>>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>>>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>>>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>>>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>>>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>>>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>>>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>>>>
>>>> I have no idea what caused that.
>>>
>>> Though I suspect commit 8b138d4898a0 ("rtlwifi: rtl8188ee: Enable build
>>> of new driver") - I wonder if the gap between the "-I" and
>>> "drivers/net/wireless/rtlwifi" added to ccflags-y is the cause?
>>>
>>> I am using gcc 4.6.3 if that matters.
>>
>> I use 4.7.2.
>>
>> I'll send a patch with the space removed to see if that helps.
>
> I just tested without the space and it fixes the problem for my Debian
> 4.7.2 compiler. Removing the space also fixes the problem with finding
> include files (after I removed the "../" bits again).

Stephan,

Ah, that was the real error. Thanks for testing.

John: Please take my patch of this evening entitles "[PATCH] rtlwifi: rtl8188ee:
Fix linker warnings" and drop the one by Chen, Chien-Chia entitled "[PATCH]
rtlwifi: rtl8188ee: Fix wrong header path". If we put the ../ into the header
paths, I'll just have to take them out later. We might as well leave them out.

Larry