2013-04-10 09:18:13

by Chen Gang

[permalink] [raw]
Subject: [PATCH] kernel: acct: kfree, also set related variable to NULL after kfree


after kfree acct, also set ns->bacct to NULL.

Signed-off-by: Chen Gang <[email protected]>
---
kernel/acct.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/acct.c b/kernel/acct.c
index 85389fe..91a23eb 100644
--- a/kernel/acct.c
+++ b/kernel/acct.c
@@ -332,6 +332,7 @@ void acct_exit_ns(struct pid_namespace *ns)
spin_lock(&acct_lock);
if (acct->file != NULL)
acct_file_reopen(acct, NULL, NULL);
+ ns->bacct = NULL;
spin_unlock(&acct_lock);

kfree(acct);
--
1.7.7.6


2013-04-12 14:28:55

by Serge E. Hallyn

[permalink] [raw]
Subject: Re: [PATCH] kernel: acct: kfree, also set related variable to NULL after kfree

Quoting Chen Gang ([email protected]):
>
> after kfree acct, also set ns->bacct to NULL.
>
> Signed-off-by: Chen Gang <[email protected]>

Acked-by: Serge Hallyn <[email protected]>

> ---
> kernel/acct.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/acct.c b/kernel/acct.c
> index 85389fe..91a23eb 100644
> --- a/kernel/acct.c
> +++ b/kernel/acct.c
> @@ -332,6 +332,7 @@ void acct_exit_ns(struct pid_namespace *ns)
> spin_lock(&acct_lock);
> if (acct->file != NULL)
> acct_file_reopen(acct, NULL, NULL);
> + ns->bacct = NULL;
> spin_unlock(&acct_lock);
>
> kfree(acct);
> --
> 1.7.7.6
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

2013-04-14 06:00:25

by Chen Gang F T

[permalink] [raw]
Subject: Re: [PATCH] kernel: acct: kfree, also set related variable to NULL after kfree

On 2013年04月12日 22:29, Serge E. Hallyn wrote:
> Quoting Chen Gang ([email protected]):
>> >
>> > after kfree acct, also set ns->bacct to NULL.
>> >
>> > Signed-off-by: Chen Gang <[email protected]>
> Acked-by: Serge Hallyn <[email protected]>
>

thanks.

--
Chen Gang

Flying Transformer