On Fri, Apr 12, 2013 at 4:24 PM, Sedat Dilek <[email protected]> wrote:
> On Fri, Apr 12, 2013 at 10:23 AM, Viresh Kumar <[email protected]> wrote:
>> On 10 April 2013 11:44, Sedat Dilek <[email protected]> wrote:
>>> I found this "[RFC PATCH] kbuild: Build linux-tools package with 'make
>>> deb-pkg'" from February 2012.
>>> Can't say what happened to it...
>>
>> Sedat,
>>
>> Sorry for being late. I am down with Fever and throat infection since few days.
>> Still struggling with it..
>>
>> There are few things i tried. Firstly the tag: next-20130326 is bad as there are
>> some bad commits in cpufreq core in it.
>>
>> I then tried latest linux-next/master on my Thinkpad (model name : Intel(R)
>> Core(TM) i7-2640M CPU @ 2.80GHz) and couldn't boot it up. My ubuntu
>> just hanged.
>>
>> Then i tried Rafael's linux-next branch
>>
>> 079576f Merge branch 'pm-cpufreq-next' into linux-next
>>
>> And couldn't find any issues with it. I am easily able to remove/add cpus at
>> runtime..
>>
>> Can you give this branch a try?
>>
>
> OK, you seem to be well again, nice to hear.
>
> I was doing the whole week spring-cleaning in the apartment of my parents.
> Now, I have some minutes for a compilation run.
>
> I guess "cpufreq: Call __cpufreq_governor() with correct policy->cpus
> mask" could be the correct fix, but will try the GIT branch you have
> mentioned.
>
> - Sedat -
>
> [1] http://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-next&id=e4969ebac83fdea78d89c779331396728a4e6199
>

Both BROKEN here, specific pm-next commitid and pulling
pm.git#linux-next into next-20130411 (see attached files).

Is "cpufreq: convert cpufreq_driver to using RCU" the root cause of this all?

- Sedat -

[1] http://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-next&id=5800043b2488a1c4c6e859af860644d37419d58b

>> --
>> viresh

Attachments:

dmesg_3.9.0-rc6-1-pmnext079576f-small_BROKEN.txt (57.26 kB)
config-3.9.0-rc6-1-pmnext079576f-small (107.22 kB)
config-3.9.0-rc6-next20130411-3-iniza-small (109.63 kB)
dmesg_3.9.0-rc6-next20130411-3-iniza-small_BROKEN.txt (57.63 kB)
Download all attachments

2013-04-12 16:27:30

by Sedat Dilek

[permalink] [raw]

Subject: Re: linux-next: Tree for Apr 9 [cpufreq: NULL pointer deref]

On Fri, Apr 12, 2013 at 5:45 PM, Sedat Dilek <[email protected]> wrote:
> On Fri, Apr 12, 2013 at 4:24 PM, Sedat Dilek <[email protected]> wrote:
>> On Fri, Apr 12, 2013 at 10:23 AM, Viresh Kumar <[email protected]> wrote:
>>> On 10 April 2013 11:44, Sedat Dilek <[email protected]> wrote:
>>>> I found this "[RFC PATCH] kbuild: Build linux-tools package with 'make
>>>> deb-pkg'" from February 2012.
>>>> Can't say what happened to it...
>>>
>>> Sedat,
>>>
>>> Sorry for being late. I am down with Fever and throat infection since few days.
>>> Still struggling with it..
>>>
>>> There are few things i tried. Firstly the tag: next-20130326 is bad as there are
>>> some bad commits in cpufreq core in it.
>>>
>>> I then tried latest linux-next/master on my Thinkpad (model name : Intel(R)
>>> Core(TM) i7-2640M CPU @ 2.80GHz) and couldn't boot it up. My ubuntu
>>> just hanged.
>>>
>>> Then i tried Rafael's linux-next branch
>>>
>>> 079576f Merge branch 'pm-cpufreq-next' into linux-next
>>>
>>> And couldn't find any issues with it. I am easily able to remove/add cpus at
>>> runtime..
>>>
>>> Can you give this branch a try?
>>>
>>
>> OK, you seem to be well again, nice to hear.
>>
>> I was doing the whole week spring-cleaning in the apartment of my parents.
>> Now, I have some minutes for a compilation run.
>>
>> I guess "cpufreq: Call __cpufreq_governor() with correct policy->cpus
>> mask" could be the correct fix, but will try the GIT branch you have
>> mentioned.
>>
>> - Sedat -
>>
>> [1] http://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-next&id=e4969ebac83fdea78d89c779331396728a4e6199
>>
>
> Both BROKEN here, specific pm-next commitid and pulling
> pm.git#linux-next into next-20130411 (see attached files).
>
> Is "cpufreq: convert cpufreq_driver to using RCU" the root cause of this all?
>

[ CC Nathan ]

NO, wrong assumption.

2013-04-12 18:04 Sedat Dilek o [revert-cpufreq-rcu] Revert
"cpufreq: convert cpufreq_driver to using RCU"
2013-04-12 18:04 Sedat Dilek o Revert "cpufreq: Call
__cpufreq_governor() with correct policy->cpus mask"
2013-04-11 23:24 Rafael J. Wysocki M─┐ [pm-next-079576f] Merge branch
'pm-cpufreq-next' into linux-next

- Sedat -

> - Sedat -
>
> [1] http://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-next&id=5800043b2488a1c4c6e859af860644d37419d58b
>
>>> --
>>> viresh

Attachments:

dmesg_3.9.0-rc6-1-revertcpufreqrcu-small_BROKEN.txt (57.50 kB)

2013-04-12 21:08:45

On 15 April 2013 21:37, Dirk Brandewie <[email protected]> wrote:
> If the intel_pstate driver is being used __cpufreq_governor() should NOT be
> called intel_pstate does not implement the target() callback.
>
> Nathan's commit 5800043b2 changed the fence around the call to
> __cpufreq_governor() in __cpufreq_remove_dev() here is the relevant hunk.

No it isn't.

> + if (has_target)
> __cpufreq_governor(data, CPUFREQ_GOV_STOP);

As it has taken care of this limitation.

BUT some of my earlier patches haven't. :(
Here is the fix (Sedat please try this and give your tested-by, use the attached
patch as gmail might break what i am copying in mail)..

Sorry for being late in fixing this issue, i am still down with Tonsil infection
and fever.. Today only i got some power to fix it after seeing Dirk's mail.

Your tested-by may help me to recover quickly :)

@Rafael: I will probably be down for one more week and so not doing any
reviews for now... I do check important mails sent directly to me though.

------------x----------------------x------------------

From: Viresh Kumar <[email protected]>
Date: Mon, 15 Apr 2013 22:43:57 +0530
Subject: [PATCH] cpufreq: Don't call __cpufreq_governor() for drivers without
target()

Some cpufreq drivers implement their own governor and so don't need us to call
generic governors interface via __cpufreq_governor(). Few recent commits haven't
obeyed this law well and we saw some regressions.

This patch tries to fix this issue.

Signed-off-by: Viresh Kumar <[email protected]>
---
drivers/cpufreq/cpufreq.c | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 3564947..a6f6595 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -858,13 +858,18 @@ static int cpufreq_add_policy_cpu(unsigned int
cpu, unsigned int sibling,
struct device *dev)
{
struct cpufreq_policy *policy;
- int ret = 0;
+ int ret = 0, has_target = 0;
unsigned long flags;

policy = cpufreq_cpu_get(sibling);
WARN_ON(!policy);

- __cpufreq_governor(policy, CPUFREQ_GOV_STOP);
+ rcu_read_lock();
+ has_target = !!rcu_dereference(cpufreq_driver)->target;
+ rcu_read_unlock();
+
+ if (has_target)
+ __cpufreq_governor(policy, CPUFREQ_GOV_STOP);

lock_policy_rwsem_write(sibling);

@@ -877,8 +882,10 @@ static int cpufreq_add_policy_cpu(unsigned int
cpu, unsigned int sibling,

unlock_policy_rwsem_write(sibling);

- __cpufreq_governor(policy, CPUFREQ_GOV_START);
- __cpufreq_governor(policy, CPUFREQ_GOV_LIMITS);
+ if (has_target) {
+ __cpufreq_governor(policy, CPUFREQ_GOV_START);
+ __cpufreq_governor(policy, CPUFREQ_GOV_LIMITS);
+ }

ret = sysfs_create_link(&dev->kobj, &policy->kobj, "cpufreq");
if (ret) {
@@ -1146,7 +1153,8 @@ static int __cpufreq_remove_dev(struct device
*dev, struct subsys_interface *sif

/* If cpu is last user of policy, free policy */
if (cpus == 1) {
- __cpufreq_governor(data, CPUFREQ_GOV_POLICY_EXIT);
+ if (has_target)
+ __cpufreq_governor(data, CPUFREQ_GOV_POLICY_EXIT);

lock_policy_rwsem_read(cpu);
kobj = &data->kobj;

Attachments:

0001-cpufreq-Don-t-call-__cpufreq_governor-for-drivers-wi.patch (2.23 kB)

2013-04-15 17:27:10

by Nathan Zimmer

[permalink] [raw]

Subject: Re: linux-next: Tree for Apr 9 [cpufreq: NULL pointer deref]

On 04/15/2013 11:07 AM, Dirk Brandewie wrote:
> On 04/13/2013 02:55 AM, Sedat Dilek wrote:
>> On Sat, Apr 13, 2013 at 12:51 AM, Rafael J. Wysocki <[email protected]> wrote:
>>> On Friday, April 12, 2013 11:08:37 PM Sedat Dilek wrote:
>>>> On Fri, Apr 12, 2013 at 6:27 PM, Sedat Dilek
>>>> <[email protected]> wrote:
>>>>> On Fri, Apr 12, 2013 at 5:45 PM, Sedat Dilek
>>>>> <[email protected]> wrote:
>>>>>> On Fri, Apr 12, 2013 at 4:24 PM, Sedat Dilek
>>>>>> <[email protected]> wrote:
>>>>>>> On Fri, Apr 12, 2013 at 10:23 AM, Viresh Kumar
>>>>>>> <[email protected]> wrote:
>>>>>>>> On 10 April 2013 11:44, Sedat Dilek <[email protected]> wrote:
>>>>>>>>> I found this "[RFC PATCH] kbuild: Build linux-tools package
>>>>>>>>> with 'make
>>>>>>>>> deb-pkg'" from February 2012.
>>>>>>>>> Can't say what happened to it...
>>>>>>>>
>>>>>>>> Sedat,
>>>>>>>>
>>>>>>>> Sorry for being late. I am down with Fever and throat infection
>>>>>>>> since few days.
>>>>>>>> Still struggling with it..
>>>>>>>>
>>>>>>>> There are few things i tried. Firstly the tag: next-20130326 is
>>>>>>>> bad as there are
>>>>>>>> some bad commits in cpufreq core in it.
>>>>>>>>
>>>>>>>> I then tried latest linux-next/master on my Thinkpad (model
>>>>>>>> name : Intel(R)
>>>>>>>> Core(TM) i7-2640M CPU @ 2.80GHz) and couldn't boot it up. My
>>>>>>>> ubuntu
>>>>>>>> just hanged.
>>>>>>>>
>>>>>>>> Then i tried Rafael's linux-next branch
>>>>>>>>
>>>>>>>> 079576f Merge branch 'pm-cpufreq-next' into linux-next
>>>>>>>>
>>>>>>>> And couldn't find any issues with it. I am easily able to
>>>>>>>> remove/add cpus at
>>>>>>>> runtime..
>>>>>>>>
>>>>>>>> Can you give this branch a try?
>>>>>>>>
>>>>>>>
>>>>>>> OK, you seem to be well again, nice to hear.
>>>>>>>
>>>>>>> I was doing the whole week spring-cleaning in the apartment of
>>>>>>> my parents.
>>>>>>> Now, I have some minutes for a compilation run.
>>>>>>>
>>>>>>> I guess "cpufreq: Call __cpufreq_governor() with correct
>>>>>>> policy->cpus
>>>>>>> mask" could be the correct fix, but will try the GIT branch you
>>>>>>> have
>>>>>>> mentioned.
>>>>>>>
>>>>>>> - Sedat -
>>>>>>>
>>>>>>> [1]
>>>>>>> http://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-next&id=e4969ebac83fdea78d89c779331396728a4e6199
>>>>>>>
>>>>>>
>>>>>> Both BROKEN here, specific pm-next commitid and pulling
>>>>>> pm.git#linux-next into next-20130411 (see attached files).
>>>>>>
>>>>>> Is "cpufreq: convert cpufreq_driver to using RCU" the root cause
>>>>>> of this all?
>>>>>>
>>>>>
>>>>> [ CC Nathan ]
>>>>>
>>>>> NO, wrong assumption.
>>>>>
>>>>> 2013-04-12 18:04 Sedat Dilek o [revert-cpufreq-rcu] Revert
>>>>> "cpufreq: convert cpufreq_driver to using RCU"
>>>>> 2013-04-12 18:04 Sedat Dilek o Revert "cpufreq: Call
>>>>> __cpufreq_governor() with correct policy->cpus mask"
>>>>> 2013-04-11 23:24 Rafael J. Wysocki M─┐ [pm-next-079576f] Merge
>>>>> branch
>>>>> 'pm-cpufreq-next' into linux-next
>>>>>
>>>>> - Sedat -
>>>>>
>>>>>
>>>>>> - Sedat -
>>>>>>
>>>>>> [1]
>>>>>> http://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-next&id=5800043b2488a1c4c6e859af860644d37419d58b
>>>>>>
>>>>>>>> --
>>>>>>>> viresh
>>>>
>>>> [ TO Dirk (Author of Intel pstate driver) ]
>>>>
>>>> With CONFIG_X86_INTEL_PSTATE=n (unset) I do not see the call-trace!
>>>>
>>>> My kernel-config and dmesg are attached.
>>>
>>> You're seeing a trouble with a new driver, then, so that's not a
>>> regression.
>>>
>
> This IS a regression.
>
> If the intel_pstate driver is being used __cpufreq_governor() should
> NOT be
> called intel_pstate does not implement the target() callback.
>
> Nathan's commit 5800043b2 changed the fence around the call to
> __cpufreq_governor() in __cpufreq_remove_dev() here is the relevant hunk.
>
> @@ -1007,9 +1068,12 @@ static int __cpufreq_remove_dev(struct device
> *dev, struct subsys_interface *sif
> unsigned int cpu = dev->id, ret, cpus;
> unsigned long flags;
> struct cpufreq_policy *data;
> + struct cpufreq_driver *driver;
> struct kobject *kobj;
> struct completion *cmp;
> struct device *cpu_dev;
> + bool has_target;
> + int (*exit)(struct cpufreq_policy *policy);
>
> pr_debug("%s: unregistering CPU %u\n", __func__, cpu);
>
> @@ -1025,14 +1089,19 @@ static int __cpufreq_remove_dev(struct device
> *dev, struct subsys_interface *sif
> return -EINVAL;
> }
>
> - if (cpufreq_driver->target)
> + rcu_read_lock();
> + driver = rcu_dereference(cpufreq_driver);
> + has_target = driver->target ? true : false;
> + exit = driver->exit;
> + if (has_target)
> __cpufreq_governor(data, CPUFREQ_GOV_STOP);
>
> #ifdef CONFIG_HOTPLUG_CPU
> - if (!cpufreq_driver->setpolicy)
> + if (!driver->setpolicy)
> strncpy(per_cpu(cpufreq_cpu_governor, cpu),
> data->governor->name, CPUFREQ_NAME_LEN);
> #endif
> + rcu_read_unlock();
>
> WARN_ON(lock_policy_rwsem_write(cpu));
> cpus = cpumask_weight(data->cpus);
>

I am not clear at what is at issue. Are you saying __cpufreq_governor
can change the value of cpufreq_driver->target? I hadn't thought that
was allowed but if it is the code would need to be fixed.

Nate

2013-04-15 17:42:15

by Dirk Brandewie

[permalink] [raw]

Subject: Re: linux-next: Tree for Apr 9 [cpufreq: NULL pointer deref]

On 04/15/2013 10:27 AM, Nathan Zimmer wrote:
> On 04/15/2013 11:07 AM, Dirk Brandewie wrote:
>> On 04/13/2013 02:55 AM, Sedat Dilek wrote:
>>> On Sat, Apr 13, 2013 at 12:51 AM, Rafael J. Wysocki <[email protected]> wrote:
>>>> On Friday, April 12, 2013 11:08:37 PM Sedat Dilek wrote:
>>>>> On Fri, Apr 12, 2013 at 6:27 PM, Sedat Dilek <[email protected]> wrote:
>>>>>> On Fri, Apr 12, 2013 at 5:45 PM, Sedat Dilek <[email protected]> wrote:
>>>>>>> On Fri, Apr 12, 2013 at 4:24 PM, Sedat Dilek <[email protected]> wrote:
>>>>>>>> On Fri, Apr 12, 2013 at 10:23 AM, Viresh Kumar <[email protected]>
>>>>>>>> wrote:
>>>>>>>>> On 10 April 2013 11:44, Sedat Dilek <[email protected]> wrote:
>>>>>>>>>> I found this "[RFC PATCH] kbuild: Build linux-tools package with 'make
>>>>>>>>>> deb-pkg'" from February 2012.
>>>>>>>>>> Can't say what happened to it...
>>>>>>>>>
>>>>>>>>> Sedat,
>>>>>>>>>
>>>>>>>>> Sorry for being late. I am down with Fever and throat infection since
>>>>>>>>> few days.
>>>>>>>>> Still struggling with it..
>>>>>>>>>
>>>>>>>>> There are few things i tried. Firstly the tag: next-20130326 is bad as
>>>>>>>>> there are
>>>>>>>>> some bad commits in cpufreq core in it.
>>>>>>>>>
>>>>>>>>> I then tried latest linux-next/master on my Thinkpad (model name
>>>>>>>>> : Intel(R)
>>>>>>>>> Core(TM) i7-2640M CPU @ 2.80GHz) and couldn't boot it up. My ubuntu
>>>>>>>>> just hanged.
>>>>>>>>>
>>>>>>>>> Then i tried Rafael's linux-next branch
>>>>>>>>>
>>>>>>>>> 079576f Merge branch 'pm-cpufreq-next' into linux-next
>>>>>>>>>
>>>>>>>>> And couldn't find any issues with it. I am easily able to remove/add
>>>>>>>>> cpus at
>>>>>>>>> runtime..
>>>>>>>>>
>>>>>>>>> Can you give this branch a try?
>>>>>>>>>
>>>>>>>>
>>>>>>>> OK, you seem to be well again, nice to hear.
>>>>>>>>
>>>>>>>> I was doing the whole week spring-cleaning in the apartment of my parents.
>>>>>>>> Now, I have some minutes for a compilation run.
>>>>>>>>
>>>>>>>> I guess "cpufreq: Call __cpufreq_governor() with correct policy->cpus
>>>>>>>> mask" could be the correct fix, but will try the GIT branch you have
>>>>>>>> mentioned.
>>>>>>>>
>>>>>>>> - Sedat -
>>>>>>>>
>>>>>>>> [1]
>>>>>>>> http://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-next&id=e4969ebac83fdea78d89c779331396728a4e6199
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>> Both BROKEN here, specific pm-next commitid and pulling
>>>>>>> pm.git#linux-next into next-20130411 (see attached files).
>>>>>>>
>>>>>>> Is "cpufreq: convert cpufreq_driver to using RCU" the root cause of this
>>>>>>> all?
>>>>>>>
>>>>>>
>>>>>> [ CC Nathan ]
>>>>>>
>>>>>> NO, wrong assumption.
>>>>>>
>>>>>> 2013-04-12 18:04 Sedat Dilek o [revert-cpufreq-rcu] Revert
>>>>>> "cpufreq: convert cpufreq_driver to using RCU"
>>>>>> 2013-04-12 18:04 Sedat Dilek o Revert "cpufreq: Call
>>>>>> __cpufreq_governor() with correct policy->cpus mask"
>>>>>> 2013-04-11 23:24 Rafael J. Wysocki M─┐ [pm-next-079576f] Merge branch
>>>>>> 'pm-cpufreq-next' into linux-next
>>>>>>
>>>>>> - Sedat -
>>>>>>
>>>>>>
>>>>>>> - Sedat -
>>>>>>>
>>>>>>> [1]
>>>>>>> http://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-next&id=5800043b2488a1c4c6e859af860644d37419d58b
>>>>>>>
>>>>>>>
>>>>>>>>> --
>>>>>>>>> viresh
>>>>>
>>>>> [ TO Dirk (Author of Intel pstate driver) ]
>>>>>
>>>>> With CONFIG_X86_INTEL_PSTATE=n (unset) I do not see the call-trace!
>>>>>
>>>>> My kernel-config and dmesg are attached.
>>>>
>>>> You're seeing a trouble with a new driver, then, so that's not a regression.
>>>>
>>
>> This IS a regression.
>>
>> If the intel_pstate driver is being used __cpufreq_governor() should NOT be
>> called intel_pstate does not implement the target() callback.
>>
>> Nathan's commit 5800043b2 changed the fence around the call to
>> __cpufreq_governor() in __cpufreq_remove_dev() here is the relevant hunk.
>>
>> @@ -1007,9 +1068,12 @@ static int __cpufreq_remove_dev(struct device *dev,
>> struct subsys_interface *sif
>> unsigned int cpu = dev->id, ret, cpus;
>> unsigned long flags;
>> struct cpufreq_policy *data;
>> + struct cpufreq_driver *driver;
>> struct kobject *kobj;
>> struct completion *cmp;
>> struct device *cpu_dev;
>> + bool has_target;
>> + int (*exit)(struct cpufreq_policy *policy);
>>
>> pr_debug("%s: unregistering CPU %u\n", __func__, cpu);
>>
>> @@ -1025,14 +1089,19 @@ static int __cpufreq_remove_dev(struct device *dev,
>> struct subsys_interface *sif
>> return -EINVAL;
>> }
>>
>> - if (cpufreq_driver->target)
>> + rcu_read_lock();
>> + driver = rcu_dereference(cpufreq_driver);
>> + has_target = driver->target ? true : false;
>> + exit = driver->exit;
>> + if (has_target)
>> __cpufreq_governor(data, CPUFREQ_GOV_STOP);
>>
>> #ifdef CONFIG_HOTPLUG_CPU
>> - if (!cpufreq_driver->setpolicy)
>> + if (!driver->setpolicy)
>> strncpy(per_cpu(cpufreq_cpu_governor, cpu),
>> data->governor->name, CPUFREQ_NAME_LEN);
>> #endif
>> + rcu_read_unlock();
>>
>> WARN_ON(lock_policy_rwsem_write(cpu));
>> cpus = cpumask_weight(data->cpus);
>>
>
> I am not clear at what is at issue. Are you saying __cpufreq_governor can
> change the value of cpufreq_driver->target? I hadn't thought that was allowed
> but if it is the code would need to be fixed.
>

Sorry I think pointing to your patch may have red herring see viresh's mail.

The issue is that __cpufreq_governor() is being called when intel_pstate is the
scaling driver intel_pstate does not implement ->target(). From the stack
trace it looked like this was happening in __cpufreq_remove_dev() so I "assumed"
it was the first instance of the target fence that was failing.

I am rebuilding using the next tree with viresh's patch I will let you know what
I find sorry for the noise.

--Dirk
> Nate

2013-04-15 17:51:57

On Monday, April 22, 2013 08:44:30 AM Viresh Kumar wrote:
> On 22 April 2013 05:00, Rafael J. Wysocki <[email protected]> wrote:
> > Applied to linux-pm.git/linux-next, although please check the result, because
> > the patchwork version of the patch wasn't quite applicable and I fixed it up
> > manually.
>
> Yes it looks fine and that's why i have attached the patch with my
> email earlier.

Yes, I forgot about the attachment and saw it again only after I had applied
the patch.

Thanks,
Rafael

--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.