2022-09-17 19:12:56

by Kang Minchul

Subject: [PATCH 2/2] staging: rtl8723bs: Insert blank line after declarations

This patch fixes checkpatch warning as follows:

WARNING: Missing a blank line after declarations

Signed-off-by: Kang Minchul <[email protected]>
---
drivers/staging/rtl8723bs/core/rtw_recv.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
index ad6fb6c3d1f0..dade4d07662b 100644
--- a/drivers/staging/rtl8723bs/core/rtw_recv.c
+++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
@@ -245,6 +245,7 @@ u32 rtw_free_uc_swdec_pending_queue(struct adapter *adapter)
{
u32 cnt = 0;
union recv_frame *pending_frame;
+
while ((pending_frame = rtw_alloc_recvframe(&adapter->recvpriv.uc_swdec_pending_queue))) {
rtw_free_recvframe(pending_frame, &adapter->recvpriv.free_recv_queue);
cnt++;
@@ -397,6 +398,7 @@ static union recv_frame *decryptor(struct adapter *padapter, union recv_frame *p

if (prxattrib->encrypt > 0) {
u8 *iv = precv_frame->u.hdr.rx_data+prxattrib->hdrlen;
+
prxattrib->key_index = (((iv[3])>>6)&0x3);

if (prxattrib->key_index > WEP_KEYS) {
@@ -882,6 +884,7 @@ static signed int sta2ap_data_frame(struct adapter *adapter, union recv_frame *p
}
} else {
u8 *myhwaddr = myid(&adapter->eeprompriv);
+
if (memcmp(pattrib->ra, myhwaddr, ETH_ALEN)) {
ret = RTW_RX_HANDLED;
goto exit;
@@ -1125,6 +1128,7 @@ static union recv_frame *recvframe_chk_defrag(struct adapter *padapter, union re
psta = rtw_get_stainfo(pstapriv, psta_addr);
if (!psta) {
u8 type = GetFrameType(pfhdr->rx_data);
+
if (type != WIFI_DATA_TYPE) {
psta = rtw_get_bcmc_stainfo(padapter);
pdefrag_q = &psta->sta_recvpriv.defrag_q;
@@ -1207,6 +1211,7 @@ static signed int validate_recv_mgnt_frame(struct adapter *padapter, union recv_
{
/* for rx pkt statistics */
struct sta_info *psta = rtw_get_stainfo(&padapter->stapriv, GetAddr2Ptr(precv_frame->u.hdr.rx_data));
+
if (psta) {
psta->sta_stats.rx_mgnt_pkts++;
if (GetFrameSubType(precv_frame->u.hdr.rx_data) == WIFI_BEACON)
@@ -1480,6 +1485,7 @@ static signed int validate_recv_frame(struct adapter *adapter, union recv_frame
retval = validate_recv_data_frame(adapter, precv_frame);
if (retval == _FAIL) {
struct recv_priv *precvpriv = &adapter->recvpriv;
+
precvpriv->rx_drop++;
} else if (retval == _SUCCESS) {
#ifdef DBG_RX_DUMP_EAP
--
2.34.1

2022-09-17 21:10:19

by Hans de Goede

Subject: Re: [PATCH 2/2] staging: rtl8723bs: Insert blank line after declarations

Hi,

On 9/17/22 20:16, Kang Minchul wrote:
> This patch fixes checkpatch warning as follows:
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Kang Minchul <[email protected]>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <[email protected]>

Regards,

Hans


> ---
> drivers/staging/rtl8723bs/core/rtw_recv.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index ad6fb6c3d1f0..dade4d07662b 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -245,6 +245,7 @@ u32 rtw_free_uc_swdec_pending_queue(struct adapter *adapter)
> {
> u32 cnt = 0;
> union recv_frame *pending_frame;
> +
> while ((pending_frame = rtw_alloc_recvframe(&adapter->recvpriv.uc_swdec_pending_queue))) {
> rtw_free_recvframe(pending_frame, &adapter->recvpriv.free_recv_queue);
> cnt++;
> @@ -397,6 +398,7 @@ static union recv_frame *decryptor(struct adapter *padapter, union recv_frame *p
>
> if (prxattrib->encrypt > 0) {
> u8 *iv = precv_frame->u.hdr.rx_data+prxattrib->hdrlen;
> +
> prxattrib->key_index = (((iv[3])>>6)&0x3);
>
> if (prxattrib->key_index > WEP_KEYS) {
> @@ -882,6 +884,7 @@ static signed int sta2ap_data_frame(struct adapter *adapter, union recv_frame *p
> }
> } else {
> u8 *myhwaddr = myid(&adapter->eeprompriv);
> +
> if (memcmp(pattrib->ra, myhwaddr, ETH_ALEN)) {
> ret = RTW_RX_HANDLED;
> goto exit;
> @@ -1125,6 +1128,7 @@ static union recv_frame *recvframe_chk_defrag(struct adapter *padapter, union re
> psta = rtw_get_stainfo(pstapriv, psta_addr);
> if (!psta) {
> u8 type = GetFrameType(pfhdr->rx_data);
> +
> if (type != WIFI_DATA_TYPE) {
> psta = rtw_get_bcmc_stainfo(padapter);
> pdefrag_q = &psta->sta_recvpriv.defrag_q;
> @@ -1207,6 +1211,7 @@ static signed int validate_recv_mgnt_frame(struct adapter *padapter, union recv_
> {
> /* for rx pkt statistics */
> struct sta_info *psta = rtw_get_stainfo(&padapter->stapriv, GetAddr2Ptr(precv_frame->u.hdr.rx_data));
> +
> if (psta) {
> psta->sta_stats.rx_mgnt_pkts++;
> if (GetFrameSubType(precv_frame->u.hdr.rx_data) == WIFI_BEACON)
> @@ -1480,6 +1485,7 @@ static signed int validate_recv_frame(struct adapter *adapter, union recv_frame
> retval = validate_recv_data_frame(adapter, precv_frame);
> if (retval == _FAIL) {
> struct recv_priv *precvpriv = &adapter->recvpriv;
> +
> precvpriv->rx_drop++;
> } else if (retval == _SUCCESS) {
> #ifdef DBG_RX_DUMP_EAP