2023-03-15 01:41:51

by Li zeming

Subject: [PATCH] io_uring: rsrc: Optimize return value variable 'ret'

The function returns here and returns ret directly. It may look better.

Signed-off-by: Li zeming <[email protected]>
---
io_uring/rsrc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/io_uring/rsrc.c b/io_uring/rsrc.c
index 056f40946ff6..55dc2c505f8a 100644
--- a/io_uring/rsrc.c
+++ b/io_uring/rsrc.c
@@ -415,11 +415,11 @@ __cold static int io_rsrc_data_alloc(struct io_ring_ctx *ctx,

data = kzalloc(sizeof(*data), GFP_KERNEL);
if (!data)
- return -ENOMEM;
+ return ret;
data->tags = (u64 **)io_alloc_page_table(nr * sizeof(data->tags[0][0]));
if (!data->tags) {
kfree(data);
- return -ENOMEM;
+ return ret;
}

data->nr = nr;
--
2.18.2

2023-03-15 01:56:47

by Jens Axboe

Subject: Re: [PATCH] io_uring: rsrc: Optimize return value variable 'ret'

On 3/16/23 12:13 PM, Li zeming wrote:
> The function returns here and returns ret directly. It may look better.

I think it'd be better to just initialize 'ret' to 0 instead.

--
Jens Axboe