2019-03-27 12:06:06

by Katsuhiro Suzuki

[permalink] [raw]
Subject: [PATCH] arm64: dts: rockchip: fix IO domain voltage setting of APIO5

This patch fixes IO domain voltage setting that is related to
audio_gpio3d4a_ms (bit 1) of GRF_IO_VSEL.

This is because RockPro64 schematics P.16 says that regulator
supplies 3.0V power to APIO5_VDD. So audio_gpio3d4a_ms bit should
be clear (means 3.0V). Power domain map is saying different thing
(supplies 1.8V) but I believe P.16 is actual connectings.

Signed-off-by: Katsuhiro Suzuki <[email protected]>
Suggested-by: Robin Murphy <[email protected]>
---
arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
index 791fb0ee9722..20ec7d1c25d7 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
@@ -508,7 +508,7 @@
status = "okay";

bt656-supply = <&vcc1v8_dvp>;
- audio-supply = <&vcca1v8_codec>;
+ audio-supply = <&vcc_3v0>;
sdmmc-supply = <&vcc_sdio>;
gpio1830-supply = <&vcc_3v0>;
};
--
2.20.1



2019-04-15 09:49:50

by Katsuhiro Suzuki

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: rockchip: fix IO domain voltage setting of APIO5

ping...

On 2019/03/27 21:03, Katsuhiro Suzuki wrote:
> This patch fixes IO domain voltage setting that is related to
> audio_gpio3d4a_ms (bit 1) of GRF_IO_VSEL.
>
> This is because RockPro64 schematics P.16 says that regulator
> supplies 3.0V power to APIO5_VDD. So audio_gpio3d4a_ms bit should
> be clear (means 3.0V). Power domain map is saying different thing
> (supplies 1.8V) but I believe P.16 is actual connectings.
>
> Signed-off-by: Katsuhiro Suzuki <[email protected]>
> Suggested-by: Robin Murphy <[email protected]>
> ---
> arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
> index 791fb0ee9722..20ec7d1c25d7 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
> @@ -508,7 +508,7 @@
> status = "okay";
>
> bt656-supply = <&vcc1v8_dvp>;
> - audio-supply = <&vcca1v8_codec>;
> + audio-supply = <&vcc_3v0>;
> sdmmc-supply = <&vcc_sdio>;
> gpio1830-supply = <&vcc_3v0>;
> };
>

2019-04-23 10:32:47

by Heiko Stuebner

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: rockchip: fix IO domain voltage setting of APIO5

Am Mittwoch, 27. M?rz 2019, 13:03:17 CEST schrieb Katsuhiro Suzuki:
> This patch fixes IO domain voltage setting that is related to
> audio_gpio3d4a_ms (bit 1) of GRF_IO_VSEL.
>
> This is because RockPro64 schematics P.16 says that regulator
> supplies 3.0V power to APIO5_VDD. So audio_gpio3d4a_ms bit should
> be clear (means 3.0V). Power domain map is saying different thing
> (supplies 1.8V) but I believe P.16 is actual connectings.
>
> Signed-off-by: Katsuhiro Suzuki <[email protected]>
> Suggested-by: Robin Murphy <[email protected]>

applied for 5.2

Thanks
Heiko