Hi All,
There is a kernel memory leak observed when the proc file /proc/fs/fscache/stats is read.
The reason is that in fscache_stats_open, single_open is called and respective release function is not called during release.
Hence fix with correct release function - single_release. The patch is as below
diff -uprN -X linux-3.9-rc8-vanilla/Documentation/dontdiff linux-3.9-rc8-vanilla/fs/fscache/stats.c linux-3.9-rc8.mod/fs/fscache/stats.c
--- linux-3.9-rc8-vanilla/fs/fscache/stats.c 2013-04-22 03:08:45.000000000 +0530
+++ linux-3.9-rc8.mod/fs/fscache/stats.c 2013-04-24 23:03:31.531296160 +0530
@@ -287,5 +287,5 @@ const struct file_operations fscache_sta
.open = fscache_stats_open,
.read = seq_read,
.llseek = seq_lseek,
- .release = seq_release,
+ .release = single_release,
};
Regards,
Anurup M
On 2013/4/25 18:05, Anurup m wrote:
> Hi All,
>
> There is a kernel memory leak observed when the proc file /proc/fs/fscache/stats is read.
> The reason is that in fscache_stats_open, single_open is called and respective release function is not called during release.
> Hence fix with correct release function - single_release. The patch is as below
>
The fix is obviously corect, but the patch is mangled so you should configure your
email client properly. Read Documention/email-clients.txt.
And when you've done that, remember Cc maintainers when you resend this patch, i.e.
David Howells <[email protected]> and Andrew Morton <[email protected]>
in this case.
> diff -uprN -X linux-3.9-rc8-vanilla/Documentation/dontdiff linux-3.9-rc8-vanilla/fs/fscache/stats.c linux-3.9-rc8.mod/fs/fscache/stats.c
> --- linux-3.9-rc8-vanilla/fs/fscache/stats.c 2013-04-22 03:08:45.000000000 +0530
> +++ linux-3.9-rc8.mod/fs/fscache/stats.c 2013-04-24 23:03:31.531296160 +0530
> @@ -287,5 +287,5 @@ const struct file_operations fscache_sta
> .open = fscache_stats_open,
> .read = seq_read,
> .llseek = seq_lseek,
> - .release = seq_release,
> + .release = single_release,
Look the tab was replaced with spaces.
Hi All,
Resending the patch as Plain text, with no mangled tabs.
The patch is as below
diff -uprN -X linux-3.9-rc8-vanilla/Documentation/dontdiff linux-3.9-rc8-vanilla/fs/fscache/stats.c linux-3.9-rc8.mod/fs/fscache/stats.c
--- linux-3.9-rc8-vanilla/fs/fscache/stats.c 2013-04-22 03:08:45.000000000 +0530
+++ linux-3.9-rc8.mod/fs/fscache/stats.c 2013-04-24 23:03:31.531296160 +0530
@@ -287,5 +287,5 @@ const struct file_operations fscache_sta
.open = fscache_stats_open,
.read = seq_read,
.llseek = seq_lseek,
- .release = seq_release,
+ .release = single_release,
};
Regards,
Anurup M
-----Original Message-----
From: Lizefan
Sent: 2013年4月25日 17:01
To: Anurup m
Cc: '[email protected]'; shyju pv; Sanil kumar; Nataraj m
Subject: Re: [ PATCH ] Memory leak fix for bug 57101.
On 2013/4/25 18:05, Anurup m wrote:
> Hi All,
>
> There is a kernel memory leak observed when the proc file /proc/fs/fscache/stats is read.
> The reason is that in fscache_stats_open, single_open is called and respective release function is not called during release.
> Hence fix with correct release function - single_release. The patch is as below
>
The fix is obviously corect, but the patch is mangled so you should configure your
email client properly. Read Documention/email-clients.txt.
And when you've done that, remember Cc maintainers when you resend this patch, i.e.
David Howells <[email protected]> and Andrew Morton <[email protected]>
in this case.
> diff -uprN -X linux-3.9-rc8-vanilla/Documentation/dontdiff linux-3.9-rc8-vanilla/fs/fscache/stats.c linux-3.9-rc8.mod/fs/fscache/stats.c
> --- linux-3.9-rc8-vanilla/fs/fscache/stats.c 2013-04-22 03:08:45.000000000 +0530
> +++ linux-3.9-rc8.mod/fs/fscache/stats.c 2013-04-24 23:03:31.531296160 +0530
> @@ -287,5 +287,5 @@ const struct file_operations fscache_sta
> .open = fscache_stats_open,
> .read = seq_read,
> .llseek = seq_lseek,
> - .release = seq_release,
> + .release = single_release,
Look the tab was replaced with spaces.
On Thu, 25 Apr 2013 13:49:12 +0000 Anurup m <[email protected]> wrote:
> Resending the patch as Plain text, with no mangled tabs.
Please send us a Signed-off-by: for this, as described in
Documentation/SubmittingPatches, thanks.
Hi,
Please find the Signed-off-by for my patch.
Signed-off-by: Anurup m <[email protected]>
Regards,
Anurup M
-----Original Message-----
From: Andrew Morton [mailto:[email protected]]
Sent: 2013年4月26日 1:59
To: Anurup m
Cc: '[email protected]'; 'David Howells'; Lizefan; shyju pv; Sanil kumar; Nataraj m
Subject: Re: [ PATCH ] Memory leak fix for bug 57101.
On Thu, 25 Apr 2013 13:49:12 +0000 Anurup m <[email protected]> wrote:
> Resending the patch as Plain text, with no mangled tabs.
Please send us a Signed-off-by: for this, as described in
Documentation/SubmittingPatches, thanks.