2024-02-10 05:39:53

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH] fbdev/sh7760fb: allow modular build

There is no reason to prohibit sh7760fb from being built as a
loadable module as suggested by Geert, so change the config symbol
from bool to tristate to allow that and change the FB dependency as
needed.

Fixes: f75f71b2c418 ("fbdev/sh7760fb: Depend on FB=y")
Suggested-by: Geert Uytterhoeven <[email protected]>
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Thomas Zimmermann <[email protected]>
Cc: Javier Martinez Canillas <[email protected]>
Cc: John Paul Adrian Glaubitz <[email protected]>
Cc: Sam Ravnborg <[email protected]>
Cc: Helge Deller <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
drivers/video/fbdev/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff -- a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -1645,8 +1645,8 @@ config FB_COBALT
select FB_IOMEM_HELPERS

config FB_SH7760
- bool "SH7760/SH7763/SH7720/SH7721 LCDC support"
- depends on FB=y && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \
+ tristate "SH7760/SH7763/SH7720/SH7721 LCDC support"
+ depends on FB && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \
|| CPU_SUBTYPE_SH7720 || CPU_SUBTYPE_SH7721)
select FB_IOMEM_HELPERS
help


2024-02-10 08:25:41

by Javier Martinez Canillas

[permalink] [raw]
Subject: Re: [PATCH] fbdev/sh7760fb: allow modular build

Randy Dunlap <[email protected]> writes:

> There is no reason to prohibit sh7760fb from being built as a
> loadable module as suggested by Geert, so change the config symbol
> from bool to tristate to allow that and change the FB dependency as
> needed.
>
> Fixes: f75f71b2c418 ("fbdev/sh7760fb: Depend on FB=y")
> Suggested-by: Geert Uytterhoeven <[email protected]>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Thomas Zimmermann <[email protected]>
> Cc: Javier Martinez Canillas <[email protected]>
> Cc: John Paul Adrian Glaubitz <[email protected]>
> Cc: Sam Ravnborg <[email protected]>
> Cc: Helge Deller <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> ---
> drivers/video/fbdev/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>

Acked-by: Javier Martinez Canillas <[email protected]>

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat


Subject: Re: [PATCH] fbdev/sh7760fb: allow modular build

On Fri, 2024-02-09 at 21:39 -0800, Randy Dunlap wrote:
> There is no reason to prohibit sh7760fb from being built as a
> loadable module as suggested by Geert, so change the config symbol
> from bool to tristate to allow that and change the FB dependency as
> needed.
>
> Fixes: f75f71b2c418 ("fbdev/sh7760fb: Depend on FB=y")
> Suggested-by: Geert Uytterhoeven <[email protected]>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Thomas Zimmermann <[email protected]>
> Cc: Javier Martinez Canillas <[email protected]>
> Cc: John Paul Adrian Glaubitz <[email protected]>
> Cc: Sam Ravnborg <[email protected]>
> Cc: Helge Deller <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> ---
> drivers/video/fbdev/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff -- a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -1645,8 +1645,8 @@ config FB_COBALT
> select FB_IOMEM_HELPERS
>
> config FB_SH7760
> - bool "SH7760/SH7763/SH7720/SH7721 LCDC support"
> - depends on FB=y && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \
> + tristate "SH7760/SH7763/SH7720/SH7721 LCDC support"
> + depends on FB && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \
> || CPU_SUBTYPE_SH7720 || CPU_SUBTYPE_SH7721)
> select FB_IOMEM_HELPERS
> help

Acked-by: John Paul Adrian Glaubitz <[email protected]>

Adrian

--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913

2024-04-10 04:54:43

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH] fbdev/sh7760fb: allow modular build

Hi,

Will someone be merging this patch?

thanks.

On 2/10/24 1:31 AM, John Paul Adrian Glaubitz wrote:
> On Fri, 2024-02-09 at 21:39 -0800, Randy Dunlap wrote:
>> There is no reason to prohibit sh7760fb from being built as a
>> loadable module as suggested by Geert, so change the config symbol
>> from bool to tristate to allow that and change the FB dependency as
>> needed.
>>
>> Fixes: f75f71b2c418 ("fbdev/sh7760fb: Depend on FB=y")
>> Suggested-by: Geert Uytterhoeven <[email protected]>
>> Signed-off-by: Randy Dunlap <[email protected]>
>> Cc: Thomas Zimmermann <[email protected]>
>> Cc: Javier Martinez Canillas <[email protected]>
>> Cc: John Paul Adrian Glaubitz <[email protected]>
>> Cc: Sam Ravnborg <[email protected]>
>> Cc: Helge Deller <[email protected]>
>> Cc: [email protected]
>> Cc: [email protected]
>> ---
>> drivers/video/fbdev/Kconfig | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff -- a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
>> --- a/drivers/video/fbdev/Kconfig
>> +++ b/drivers/video/fbdev/Kconfig
>> @@ -1645,8 +1645,8 @@ config FB_COBALT
>> select FB_IOMEM_HELPERS
>>
>> config FB_SH7760
>> - bool "SH7760/SH7763/SH7720/SH7721 LCDC support"
>> - depends on FB=y && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \
>> + tristate "SH7760/SH7763/SH7720/SH7721 LCDC support"
>> + depends on FB && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \
>> || CPU_SUBTYPE_SH7720 || CPU_SUBTYPE_SH7721)
>> select FB_IOMEM_HELPERS
>> help
>
> Acked-by: John Paul Adrian Glaubitz <[email protected]>
>
> Adrian
>

--
#Randy

2024-04-10 13:18:41

by Helge Deller

[permalink] [raw]
Subject: Re: [PATCH] fbdev/sh7760fb: allow modular build

On 4/10/24 06:54, Randy Dunlap wrote:
> Hi,
>
> Will someone be merging this patch?

I've just added it to the fbdev git tree.

Thanks!
Helge


>
> thanks.
>
> On 2/10/24 1:31 AM, John Paul Adrian Glaubitz wrote:
>> On Fri, 2024-02-09 at 21:39 -0800, Randy Dunlap wrote:
>>> There is no reason to prohibit sh7760fb from being built as a
>>> loadable module as suggested by Geert, so change the config symbol
>>> from bool to tristate to allow that and change the FB dependency as
>>> needed.
>>>
>>> Fixes: f75f71b2c418 ("fbdev/sh7760fb: Depend on FB=y")
>>> Suggested-by: Geert Uytterhoeven <[email protected]>
>>> Signed-off-by: Randy Dunlap <[email protected]>
>>> Cc: Thomas Zimmermann <[email protected]>
>>> Cc: Javier Martinez Canillas <[email protected]>
>>> Cc: John Paul Adrian Glaubitz <[email protected]>
>>> Cc: Sam Ravnborg <[email protected]>
>>> Cc: Helge Deller <[email protected]>
>>> Cc: [email protected]
>>> Cc: [email protected]
>>> ---
>>> drivers/video/fbdev/Kconfig | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff -- a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
>>> --- a/drivers/video/fbdev/Kconfig
>>> +++ b/drivers/video/fbdev/Kconfig
>>> @@ -1645,8 +1645,8 @@ config FB_COBALT
>>> select FB_IOMEM_HELPERS
>>>
>>> config FB_SH7760
>>> - bool "SH7760/SH7763/SH7720/SH7721 LCDC support"
>>> - depends on FB=y && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \
>>> + tristate "SH7760/SH7763/SH7720/SH7721 LCDC support"
>>> + depends on FB && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \
>>> || CPU_SUBTYPE_SH7720 || CPU_SUBTYPE_SH7721)
>>> select FB_IOMEM_HELPERS
>>> help
>>
>> Acked-by: John Paul Adrian Glaubitz <[email protected]>
>>
>> Adrian
>>
>


Subject: Re: [PATCH] fbdev/sh7760fb: allow modular build

Hi Randy,

On Tue, 2024-04-09 at 21:54 -0700, Randy Dunlap wrote:
> Will someone be merging this patch?

Shall I pick it up through my tree?

Adrian

--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913

Subject: Re: [PATCH] fbdev/sh7760fb: allow modular build

On Wed, 2024-04-10 at 15:17 +0200, Helge Deller wrote:
> On 4/10/24 06:54, Randy Dunlap wrote:
> > Hi,
> >
> > Will someone be merging this patch?
>
> I've just added it to the fbdev git tree.

Ah, good. Then I can drop it from my queue again.

Adrian

--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913