2013-05-14 09:34:49

by Paul Bolle

Subject: [PATCH] ARM: mach-bcm: drop "select GPIO_BCM"

A select statement for the Kconfig symbol GPIO_BCM was added in v3.8.
But there's no symbol with that name. It's a nop so we can drop it.

Signed-off-by: Paul Bolle <[email protected]>
---
0) Untested.

1) Patch assumes that https://lkml.org/lkml/2013/3/6/182 ("ARM:
mach-bcm: drop "select GENERIC_TIME""), which got a Reviewed-by tag from
Christian, was applied first.

arch/arm/mach-bcm/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
index 764273e..322620d 100644
--- a/arch/arm/mach-bcm/Kconfig
+++ b/arch/arm/mach-bcm/Kconfig
@@ -8,7 +8,6 @@ config ARCH_BCM
select CPU_V7
select CLKSRC_OF
select GENERIC_CLOCKEVENTS
- select GPIO_BCM
select SPARSE_IRQ
select TICK_ONESHOT
help
--
1.7.11.7

2013-05-14 14:54:03

by Christian Daudt

Subject: Re: [PATCH] ARM: mach-bcm: drop "select GPIO_BCM"

On 13-05-14 02:34 AM, Paul Bolle wrote:
> A select statement for the Kconfig symbol GPIO_BCM was added in v3.8.
> But there's no symbol with that name. It's a nop so we can drop it.
>
> Signed-off-by: Paul Bolle <[email protected]>
> ---
> 0) Untested.
>
> 1) Patch assumes that https://lkml.org/lkml/2013/3/6/182 ("ARM:
> mach-bcm: drop "select GENERIC_TIME""), which got a Reviewed-by tag from
> Christian, was applied first.
>
> arch/arm/mach-bcm/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
> index 764273e..322620d 100644
> --- a/arch/arm/mach-bcm/Kconfig
> +++ b/arch/arm/mach-bcm/Kconfig
> @@ -8,7 +8,6 @@ config ARCH_BCM
> select CPU_V7
> select CLKSRC_OF
> select GENERIC_CLOCKEVENTS
> - select GPIO_BCM
> select SPARSE_IRQ
> select TICK_ONESHOT
> help
Hi Paul,
We are planning on submitting the driver for this option for review
over the next couple of weeks, to get it in the 3.11 cycle. So this
patch won't be necessary.

Thanks,
csd

2013-05-14 14:58:44

by Paul Bolle

Subject: Re: [PATCH] ARM: mach-bcm: drop "select GPIO_BCM"

On Tue, 2013-05-14 at 07:53 -0700, Christian Daudt wrote:
> We are planning on submitting the driver for this option for review
> over the next couple of weeks, to get it in the 3.11 cycle. So this
> patch won't be necessary.

I see. Did my web searches miss something or will that be the first time
you submit that driver for review?

Thanks,


Paul Bolle

2013-05-14 15:02:19

by Christian Daudt

Subject: Re: [PATCH] ARM: mach-bcm: drop "select GPIO_BCM"

On 13-05-14 07:58 AM, Paul Bolle wrote:
> On Tue, 2013-05-14 at 07:53 -0700, Christian Daudt wrote:
>> We are planning on submitting the driver for this option for review
>> over the next couple of weeks, to get it in the 3.11 cycle. So this
>> patch won't be necessary.
> I see. Did my web searches miss something or will that be the first time
> you submit that driver for review?
Your web searches are correct. The driver was not ready for review at
the time the initial SoC support was originally submitted, so the config
should have been removed. It leaked out :)

thanks,
csd