2013-05-15 01:35:56

by Libo Chen

Subject: [PATCH] usb: omap2430: fix memleak in err case

when omap_get_control_dev fail, we should release relational platform_device

Signed-off-by: Libo Chen <[email protected]>
---
drivers/usb/musb/omap2430.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
index 3551f1a..b626f19 100644
--- a/drivers/usb/musb/omap2430.c
+++ b/drivers/usb/musb/omap2430.c
@@ -549,7 +549,8 @@ static int omap2430_probe(struct platform_device *pdev)
glue->control_otghs = omap_get_control_dev();
if (IS_ERR(glue->control_otghs)) {
dev_vdbg(&pdev->dev, "Failed to get control device\n");
- return -ENODEV;
+ ret = -ENODEV;
+ goto err2;
}
} else {
glue->control_otghs = ERR_PTR(-ENODEV);
--
1.7.1

2013-05-15 11:55:50

by Sergei Shtylyov

Subject: Re: [PATCH] usb: omap2430: fix memleak in err case

Hello.

On 15-05-2013 5:35, Libo Chen wrote:

> when omap_get_control_dev fail, we should release relational platform_device

s/fail/fails/, s/relational/related/?

> Signed-off-by: Libo Chen <[email protected]>

You've posted this to the wrong mailing list, linux-mips;
devicetree-discuss also seems hardly related.

WBR, Sergei

2013-05-17 04:50:42

by Libo Chen

Subject: Re: [PATCH] usb: omap2430: fix memleak in err case

On 2013/5/15 19:55, Sergei Shtylyov wrote:
> Hello.
>
> On 15-05-2013 5:35, Libo Chen wrote:
>
>> when omap_get_control_dev fail, we should release relational platform_device
>
> s/fail/fails/, s/relational/related/?
>
>> Signed-off-by: Libo Chen <[email protected]>
>
> You've posted this to the wrong mailing list, linux-mips; devicetree-discuss also seems hardly related.
>
> WBR, Sergei
>
>
>

Hi Sergei,

Thank you for your remind.

2013-05-22 03:31:45

by Libo Chen

Subject: [PATCH v2] usb: omap2430: fix memleak in err case

when omap_get_control_dev faild, we should release related platform_device

* Changelog from v1:
* fix spell: s/fail/fails/, s/relational/related/ , thank Sergei <[email protected]>

Signed-off-by: Libo Chen <[email protected]>
---
drivers/usb/musb/omap2430.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
index 3551f1a..b626f19 100644
--- a/drivers/usb/musb/omap2430.c
+++ b/drivers/usb/musb/omap2430.c
@@ -549,7 +549,8 @@ static int omap2430_probe(struct platform_device *pdev)
glue->control_otghs = omap_get_control_dev();
if (IS_ERR(glue->control_otghs)) {
dev_vdbg(&pdev->dev, "Failed to get control device\n");
- return -ENODEV;
+ ret = -ENODEV;
+ goto err2;
}
} else {
glue->control_otghs = ERR_PTR(-ENODEV);
--
1.7.1

2013-05-28 12:44:39

by Libo Chen

Subject: Re: [PATCH v2] usb: omap2430: fix memleak in err case

ping...

On 2013/5/22 11:30, Libo Chen wrote:
>
> when omap_get_control_dev faild, we should release related platform_device
>
> * Changelog from v1:
> * fix spell: s/fail/fails/, s/relational/related/ , thank Sergei <[email protected]>
>
> Signed-off-by: Libo Chen <[email protected]>
> ---
> drivers/usb/musb/omap2430.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
> index 3551f1a..b626f19 100644
> --- a/drivers/usb/musb/omap2430.c
> +++ b/drivers/usb/musb/omap2430.c
> @@ -549,7 +549,8 @@ static int omap2430_probe(struct platform_device *pdev)
> glue->control_otghs = omap_get_control_dev();
> if (IS_ERR(glue->control_otghs)) {
> dev_vdbg(&pdev->dev, "Failed to get control device\n");
> - return -ENODEV;
> + ret = -ENODEV;
> + goto err2;
> }
> } else {
> glue->control_otghs = ERR_PTR(-ENODEV);
>

2013-05-28 15:34:20

by Andy Shevchenko

Subject: Re: [PATCH v2] usb: omap2430: fix memleak in err case

No go.

Check the 4b7e450fb5cefb5865c77999a675330206ab3b8a
And update you tree, please.

--
With Best Regards,
Andy Shevchenko

2013-05-28 17:40:29

by Sergei Shtylyov

Subject: Re: [PATCH v2] usb: omap2430: fix memleak in err case

Hello.

On 22-05-2013 7:30, Libo Chen wrote:

> when omap_get_control_dev faild, we should release related platform_device

> * Changelog from v1:
> * fix spell: s/fail/fails/, s/relational/related/ , thank Sergei <[email protected]>

It seems you've actually replaced "fail" with "faild", not "fails".

> Signed-off-by: Libo Chen <[email protected]>
> ---
> drivers/usb/musb/omap2430.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)

WBR, Sergei

2013-05-29 00:53:17

by Libo Chen

Subject: Re: [PATCH v2] usb: omap2430: fix memleak in err case

On 2013/5/28 23:34, Andy Shevchenko wrote:
> No go.
>
> Check the 4b7e450fb5cefb5865c77999a675330206ab3b8a
> And update you tree, please.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

It had been changed :(

Thanks,

Libo

2013-05-29 02:48:24

by Libo Chen

Subject: Re: [PATCH v2] usb: omap2430: fix memleak in err case

On 2013/5/29 1:40, Sergei Shtylyov wrote:
> Hello.
>
> On 22-05-2013 7:30, Libo Chen wrote:
>
>> when omap_get_control_dev faild, we should release related platform_device
>
>> * Changelog from v1:
>> * fix spell: s/fail/fails/, s/relational/related/ , thank Sergei <[email protected]>
>
> It seems you've actually replaced "fail" with "faild", not "fails".

sorry for my weak spell.


thanks again,

Libo


>
>> Signed-off-by: Libo Chen <[email protected]>
>> ---
>> drivers/usb/musb/omap2430.c | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> WBR, Sergei
>
>
>