2013-05-27 02:29:11

by Libo Chen

Subject: [PATCH 04/24] drivers/scsi/initio: Convert to module_pci_driver

use module_pci_driver instead of init/exit, make code clean.

Signed-off-by: Libo Chen <[email protected]>
---
drivers/scsi/initio.c | 13 +------------
1 files changed, 1 insertions(+), 12 deletions(-)

diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c
old mode 100644
new mode 100755
index 280d5af..1befc26
--- a/drivers/scsi/initio.c
+++ b/drivers/scsi/initio.c
@@ -2995,19 +2995,8 @@ static struct pci_driver initio_pci_driver = {
.remove = initio_remove_one,
};

-static int __init initio_init_driver(void)
-{
- return pci_register_driver(&initio_pci_driver);
-}
-
-static void __exit initio_exit_driver(void)
-{
- pci_unregister_driver(&initio_pci_driver);
-}
+module_pci_driver(initio_pci_driver);

MODULE_DESCRIPTION("Initio INI-9X00U/UW SCSI device driver");
MODULE_AUTHOR("Initio Corporation");
MODULE_LICENSE("GPL");
-
-module_init(initio_init_driver);
-module_exit(initio_exit_driver);
--
1.7.1

2013-05-27 06:38:36

by James Bottomley

Subject: Re: [PATCH 04/24] drivers/scsi/initio: Convert to module_pci_driver

On Mon, 2013-05-27 at 10:28 +0800, Libo Chen wrote:
> use module_pci_driver instead of init/exit, make code clean.

For the ancient drivers, like this, the principal is that we really
don't touch except for tested bug fixes. For the current ones (like
mvumi) it's up to the maintainer.

James

2013-05-27 07:42:08

by Libo Chen

Subject: Re: [PATCH 04/24] drivers/scsi/initio: Convert to module_pci_driver

On 2013/5/27 14:38, James Bottomley wrote:
> On Mon, 2013-05-27 at 10:28 +0800, Libo Chen wrote:
>> use module_pci_driver instead of init/exit, make code clean.
>
> For the ancient drivers, like this, the principal is that we really
> don't touch except for tested bug fixes. For the current ones (like
> mvumi) it's up to the maintainer.
>
> James
Hi james,

Thank you for your explanation!


>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>