2013-05-16 13:47:55

by Daniel Borkmann

Subject: [PATCH] ktime: minor: ktime_to_timespec_cond: add __must_check prefix

The function is currently mainly used in the networking code and
if others start using it, they must check the result, otherwise
it cannot be determined if the timespec conversion suceeded.
Currently no user lacks this check, but make future users aware of
a possible misusage.

Signed-off-by: Daniel Borkmann <[email protected]>
---
include/linux/ktime.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/linux/ktime.h b/include/linux/ktime.h
index bbca128..cededfd 100644
--- a/include/linux/ktime.h
+++ b/include/linux/ktime.h
@@ -338,7 +338,8 @@ extern ktime_t ktime_add_safe(const ktime_t lhs, const ktime_t rhs);
*
* Returns true if there was a successful conversion, false if kt was 0.
*/
-static inline bool ktime_to_timespec_cond(const ktime_t kt, struct timespec *ts)
+static inline __must_check bool ktime_to_timespec_cond(const ktime_t kt,
+ struct timespec *ts)
{
if (kt.tv64) {
*ts = ktime_to_timespec(kt);
--
1.7.11.7

2013-05-28 19:16:46

by John Stultz

Subject: Re: [PATCH] ktime: minor: ktime_to_timespec_cond: add __must_check prefix

On 05/16/2013 06:47 AM, Daniel Borkmann wrote:
> The function is currently mainly used in the networking code and
> if others start using it, they must check the result, otherwise
> it cannot be determined if the timespec conversion suceeded.
> Currently no user lacks this check, but make future users aware of
> a possible misusage.
>
> Signed-off-by: Daniel Borkmann <[email protected]>

I've got this queued for 3.11. Sorry for being slow to pick this up!

thanks!
-john