2013-05-29 02:34:30

by Libo Chen

Subject: [PATCH] driver: tty: add missing unregister in err case

when platform_driver_register broken, we should unregister ucc_uart_driver

Signed-off-by: Libo chen <[email protected]>
---
drivers/tty/serial/ucc_uart.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c
index 7355303..f86f447 100644
--- a/drivers/tty/serial/ucc_uart.c
+++ b/drivers/tty/serial/ucc_uart.c
@@ -1518,9 +1518,11 @@ static int __init ucc_uart_init(void)
}

ret = platform_driver_register(&ucc_uart_of_driver);
- if (ret)
+ if (ret) {
printk(KERN_ERR
"ucc-uart: could not register platform driver\n");
+ uart_unregister_driver(&ucc_uart_driver);
+ }

return ret;
}
--
1.7.1

2013-05-29 02:37:11

by Timur Tabi

Subject: Re: [PATCH] driver: tty: add missing unregister in err case

Libo Chen wrote:
> when platform_driver_register broken, we should unregister ucc_uart_driver
>
> Signed-off-by: Libo chen<[email protected]>

Acked-by: Timur Tabi <[email protected]>

Thanks for catching this.

--
Timur Tabi