2013-05-29 15:33:24

by Michal Simek

[permalink] [raw]

2013-05-29 16:04:55

by Michal Simek

[permalink] [raw]
Subject: Re: [PATCH 09/11] net: emaclite: Do not use microblaze and ppc IO functions

On 05/29/2013 05:33 PM, Michal Simek wrote:
> Emaclite can be used on ARM zynq where in_be32/out_be32 IO
> functions are not present. Use standard __raw_readl/__raw_writel
> IO functions instead.
>
> Signed-off-by: Michal Simek <[email protected]>
> ---
> drivers/net/ethernet/xilinx/xilinx_emaclite.c | 100 +++++++++++++-------------
> 1 file changed, 51 insertions(+), 49 deletions(-)
>
> diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> index 93bb14e..0d8515b 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> @@ -159,34 +159,34 @@ static void xemaclite_enable_interrupts(struct net_local *drvdata)
> u32 reg_data;
>
> /* Enable the Tx interrupts for the first Buffer */
> - reg_data = in_be32(drvdata->base_addr + XEL_TSR_OFFSET);
> - out_be32(drvdata->base_addr + XEL_TSR_OFFSET,
> + reg_data = __raw_readl(drvdata->base_addr + XEL_TSR_OFFSET);
> + __raw_writel(drvdata->base_addr + XEL_TSR_OFFSET,
> reg_data | XEL_TSR_XMIT_IE_MASK);

oou - this is completely wrong.
Will do v2.

Sorry for that.

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



Attachments:
signature.asc (263.00 B)
OpenPGP digital signature

2013-05-29 17:12:06

by Sergei Shtylyov

[permalink] [raw]
Subject: Re: [PATCH 11/11] net: emaclite: Update driver header

Hello.

On 05/29/2013 07:33 PM, Michal Simek wrote:

> Corrent email address and years.

s/Corrent/Correct/. Perhaps the committer can fix.

> Signed-off-by: Michal Simek <[email protected]>

WBR, Sergei

2013-05-30 05:14:47

by Michal Simek

[permalink] [raw]
Subject: Re: [PATCH 11/11] net: emaclite: Update driver header

On 05/29/2013 07:11 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 05/29/2013 07:33 PM, Michal Simek wrote:
>
>> Corrent email address and years.
>
> s/Corrent/Correct/. Perhaps the committer can fix.

I will fix it in v2, one patch is broken anyway.

Thanks,
Michal



--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



Attachments:
signature.asc (263.00 B)
OpenPGP digital signature