2013-06-07 12:08:56

by Dan Carpenter

Subject: [patch -mm] mm, vmalloc: unbreak __vunmap()

There is an extra semi-colon so the function always returns.

Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 91a1047..96b77a9 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -1453,7 +1453,7 @@ static void __vunmap(const void *addr, int deallocate_pages)
return;

if (WARN(!PAGE_ALIGNED(addr), "Trying to vfree() bad address (%p)\n",
- addr));
+ addr))
return;

area = remove_vm_area(addr);

2013-06-07 15:56:34

by Zhang Yanfei

Subject: Re: [patch -mm] mm, vmalloc: unbreak __vunmap()

On 06/07/2013 08:07 PM, Dan Carpenter wrote:
> There is an extra semi-colon so the function always returns.

Acked-by: Zhang Yanfei <[email protected]>

This is imported by using the macro PAGE_ALIGNED.

>
> Signed-off-by: Dan Carpenter <[email protected]>
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 91a1047..96b77a9 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -1453,7 +1453,7 @@ static void __vunmap(const void *addr, int deallocate_pages)
> return;
>
> if (WARN(!PAGE_ALIGNED(addr), "Trying to vfree() bad address (%p)\n",
> - addr));
> + addr))
> return;
>
> area = remove_vm_area(addr);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/